Merge lp:~inizan-yannick/granite/granite into lp:~elementary-pantheon/granite/granite

Proposed by INIZAN yannick
Status: Rejected
Rejected by: Zisu Andrei
Proposed branch: lp:~inizan-yannick/granite/granite
Merge into: lp:~elementary-pantheon/granite/granite
Diff against target: 11 lines (+0/-1)
1 file modified
lib/Widgets/SourceList.vala (+0/-1)
To merge this branch: bzr merge lp:~inizan-yannick/granite/granite
Reviewer Review Type Date Requested Status
Jeremy Wootten (community) code Needs Fixing
elementary Pantheon team Pending
Review via email:

Description of the change

Don't expand internal TreeView, SourceList cannot be packed & expanded into Box
(this branch fixes this problem)

To post a comment you must log in.
Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Making this change may break some existing applications assumptions.

A better solution would be to expose a "expand" property of SourceList which allows the user to set the expand property of the Tree.

review: Needs Fixing (code)

Unmerged revisions

992. By INIZAN yannick

Don't expand internal TreeView, SourceList cannot be expanded if it's packed into Box.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/Widgets/SourceList.vala'
2--- lib/Widgets/SourceList.vala 2016-06-09 01:28:31 +0000
3+++ lib/Widgets/SourceList.vala 2016-09-28 02:01:07 +0000
4@@ -1595,7 +1595,6 @@
5 set_model (data_model);
7 halign = valign = Gtk.Align.FILL;
8- expand = true;
10 enable_search = false;
11 headers_visible = false;


People subscribed via source and target branches