Code review comment for lp:~info-martin-konrad/epics-gateway/putlog

Revision history for this message
Ben Franksen (bfrk) wrote :

Am Donnerstag, 15. Mai 2014, 07:23:18 schrieb Ralph Lange:
> Review: Approve close look at the code, no testing
>
> To me, this patch looks good.
>
> I have not settled in well enough to have an environment to actually compile
> and test the code, though, so I would like Benjamin to also have a look and
> maybe take this for a test drive.

Sorry for not answering sooner, I was extremely busy with a side project of
mine...

Looking at https://code.launchpad.net/~info-martin-konrad/epics-gateway/putlog/+merge/213921

I have the feeling what the page shows me is not the whole change. For
instance, I am not seeing any caPutLog includes being added. Or maybe I see
only the latest change on the branch and not the whole diff? How can I see
that?

BTW, is there a way to look at differences side-by-side in launchpad?

Sorry for my stupidity w.r.t. lp UI
Ben

________________________________

Helmholtz-Zentrum Berlin für Materialien und Energie GmbH

Mitglied der Hermann von Helmholtz-Gemeinschaft Deutscher Forschungszentren e.V.

Aufsichtsrat: Vorsitzender Prof. Dr. Dr. h.c. mult. Joachim Treusch, stv. Vorsitzende Dr. Beatrix Vierkorn-Rudolph
Geschäftsführung: Prof. Dr. Anke Rita Kaysser-Pyzalla, Thomas Frederking

Sitz Berlin, AG Charlottenburg, 89 HRB 5583

Postadresse:
Hahn-Meitner-Platz 1
D-14109 Berlin

http://www.helmholtz-berlin.de

« Back to merge proposal