Code review comment for ~info-martin-konrad/epics-base:callbackQueueStatus

Revision history for this message
Andrew Johnson (anj) wrote :

Some older C compilers (MSVC, older GCC) will fail while building this code, there are several places where it declares variables after the first statement in a block. It's fine to do that in C++ code, but still not in our C code yet.

I don't understand the use of epicsAtomic functions for accessing callbackQueueSize. The queue size must be set before callbackIsInit and can't be changed after that (unless we go through callbackCleanup() but that clears callbackIsInit anyway and if callbackQueueStatus() is called then it returns an error). Did I miss something?

review: Needs Fixing

« Back to merge proposal