Merge ~ines-almeida/txpkgupload:add-logrotate-to-charm into txpkgupload:master

[Ines Almeida]

Add logrotate to txpkgupload charm

This is based on the logrotate files in ppa.lp.internal in production

[Simone Pelosi (pelpsi)]

LGTM!

review: Approve

[Colin Watson (cjwatson)]

review: Approve

diff --git a/charm/txpkgupload/reactive/txpkgupload.py b/charm/txpkgupload/reactive/txpkgupload.py
index 2ec1e90..a8a5b66 100644
--- a/charm/txpkgupload/reactive/txpkgupload.py
+++ b/charm/txpkgupload/reactive/txpkgupload.py
@@ -19,6 +19,16 @@ from charms.reactive import (
 from ols import base
 
 
+def configure_logrotate(config):
+    hookenv.log("Writing logrotate configuration.")
+    templating.render(
+        "logrotate.conf.j2",
+        "/etc/logrotate.d/txpkgupload",
+        config,
+        perms=0o644,
+    )
+
+
 def create_virtualenv(wheels_dir, codedir, python_exe):
     hookenv.log("Creating virtualenv for txpkgupload charm")
     subprocess.check_call(
@@ -131,6 +141,7 @@ def configure_txpkgupload(config: Dict):
         "/lib/systemd/system/txpkgupload.socket",
         config
     )
+    configure_logrotate(config)
 
     hookenv.log("Starting txpkgupload")
     subprocess.check_call(["systemctl", "daemon-reload"])
diff --git a/charm/txpkgupload/templates/logrotate.conf.j2 b/charm/txpkgupload/templates/logrotate.conf.j2
new file mode 100644
index 0000000..9d82965
--- /dev/null
+++ b/charm/txpkgupload/templates/logrotate.conf.j2
@@ -0,0 +1,15 @@
+{{ logs_dir }}/*.log 
+{
+    rotate 90
+    daily
+    dateext
+    delaycompress
+    compress
+    notifempty
+    missingok
+    create 0664 txpkgupload txpkgupload
+    sharedscripts
+    postrotate
+        systemctl reload txpkgupload.service
+    endscript
+}