txpkgupload

Merge ~ines-almeida/txpkgupload:update-build-tarball-command into txpkgupload:master

  1. Git
  2. lp:~ines-almeida/txpkgupload
  3. update-build-tarball-command
  4. Merge into master
Proposed by Ines Almeida
Status: Merged
Approved by: Ines Almeida
Approved revision: 6a936bb8d66d8ff6db87c0f8960ac199032995eb
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~ines-almeida/txpkgupload:update-build-tarball-command
Merge into: txpkgupload:master
Diff against target: 12 lines (+1/-0)
1 file modified
Makefile (+1/-0)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Simone Pelosi Approve
Review via email: mp+446202@code.launchpad.net

Commit message

Add version-info command to build-tarball

Description of the change

Build failed because we are not running neither `make` before which is where `version-info.py` gets created. Adding a line to add the `version-info` on build tarball (which sees like a sensible place to run it)

To post a comment you must log in.
Revision history for this message
Simone Pelosi (pelpsi) wrote :

LGTM!

review: Approve
Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Makefile b/Makefile
2index 3719e19..55d04d0 100644
3--- a/Makefile
4+++ b/Makefile
5@@ -106,6 +106,7 @@ build-tarball:
6 @echo "Creating deployment tarball at $(TARBALL_BUILD_PATH)"
7 rm -rf $(ENV)
8 $(MAKE) $(ENV)
9+ $(MAKE) $(VERSION_INFO)
10 $(PIP) wheel -f $(DEPENDENCY_DIR) --no-index -w $(WHEELS) \
11 -r bootstrap-requirements.txt -r requirements.txt
12 mkdir -p $(TARBALL_BUILD_DIR)

Subscribers

People subscribed via source and target branches

to all changes: