Merge ~ines-almeida/launchpad:fetch-service-buildd-manager-refactor into launchpad:master
Proposed by
Ines Almeida
Status: | Merged |
---|---|
Approved by: | Ines Almeida |
Approved revision: | 77953d20c0d4e7a7b5e49aefda025cd2a51da0bd |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~ines-almeida/launchpad:fetch-service-buildd-manager-refactor |
Merge into: | launchpad:master |
Diff against target: |
186 lines (+16/-26) 5 files modified
lib/lp/buildmaster/builderproxy.py (+4/-10) lib/lp/buildmaster/downloader.py (+2/-5) lib/lp/buildmaster/interactor.py (+1/-0) lib/lp/buildmaster/tests/fetchservice.py (+8/-6) lib/lp/snappy/tests/test_snapbuildbehaviour.py (+1/-5) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jürgen Gmach | Approve | ||
Review via email: mp+464684@code.launchpad.net |
Commit message
Refactor buildd-manager: remove unneeded variables, rename and add comments
- Removed the `/session` from the base URL for the fetch service control API endpoint, for consistency.
- The `proxy_username` was confirmed to not be necessary for the fetch service.
- Minor comment and variable refactoring
To post a comment you must log in.