Merge ~ines-almeida/launchpad:change-traverse-archive-redirect-status into launchpad:master

[Ines Almeida]

Update the redirection status code from 301 to 303 when traversing an archive

The 301 signals a permanent redirect, which means that these redirects get cached. This permanent redirection can lead to issues where the wrong redirection gets cached in a browser.

[Colin Watson (cjwatson)]

review: Approve

8a06d44... by Ines Almeida on 2023-10-03

Update the default value for the status code redirection tests

diff --git a/lib/lp/registry/browser/person.py b/lib/lp/registry/browser/person.py
index c359df7..3bd82ec 100644
--- a/lib/lp/registry/browser/person.py
+++ b/lib/lp/registry/browser/person.py
@@ -516,7 +516,8 @@ class PersonNavigation(BranchTraversalMixin, Navigation):
                     self.request.stepstogo.consume()
                 if redirect:
                     return self.redirectSubTree(
-                        canonical_url(ppa, request=self.request)
+                        canonical_url(ppa, request=self.request),
+                        status=303,
                     )
                 else:
                     return ppa
diff --git a/lib/lp/registry/browser/tests/test_person.py b/lib/lp/registry/browser/tests/test_person.py
index 098c2a6..88bca93 100644
--- a/lib/lp/registry/browser/tests/test_person.py
+++ b/lib/lp/registry/browser/tests/test_person.py
@@ -111,13 +111,14 @@ from lp.testing.views import create_initialized_view, create_view
 class TestPersonNavigation(TestCaseWithFactory):
     layer = DatabaseFunctionalLayer
 
-    def assertRedirect(self, path, redirect):
+    def assertRedirect(self, path, redirect, status_code=303):
         view = test_traverse(path)[1]
         self.assertIsInstance(view, RedirectionView)
         self.assertEqual(
             urljoin(allvhosts.configs["mainsite"].rooturl, redirect),
             removeSecurityProxy(view).target,
         )
+        self.assertEqual(status_code, removeSecurityProxy(view).status)
 
     def test_traverse_archive_distroful(self):
         archive = self.factory.makeArchive(purpose=ArchivePurpose.PPA)