Merge ~ines-almeida/launchpad:increase-signing-tests-timeout into launchpad:master

[Ines Almeida]

Increase timeout of signing tests from 30 to 45 seconds

Some tests are consistently failing during builds with a timeout error, even though they don't seem stuck - they just might take a few seconds longer. This will help make the builder more stable.

[Colin Watson (cjwatson)]

review: Approve

[Jürgen Gmach (jugmac00)]

review: Approve

321742e... by Ines Almeida on 2023-09-26

Add comment about timeout value in sign keys tests

diff --git a/lib/lp/archivepublisher/tests/test_sync_signingkeys.py b/lib/lp/archivepublisher/tests/test_sync_signingkeys.py
index 3c73754..7e8a1bb 100644
--- a/lib/lp/archivepublisher/tests/test_sync_signingkeys.py
+++ b/lib/lp/archivepublisher/tests/test_sync_signingkeys.py
@@ -53,7 +53,10 @@ from lp.testing.script import run_script
 
 class TestSyncSigningKeysScript(TestCaseWithFactory):
     layer = ZopelessDatabaseLayer
-    run_tests_with = AsynchronousDeferredRunTest.make_factory(timeout=30)
+    # A timeout of 30 seconds is slightly too short and can lead to
+    # non-relevant test failures. 45 seconds is a value estimated from trial
+    # and error.
+    run_tests_with = AsynchronousDeferredRunTest.make_factory(timeout=45)
 
     def setUp(self):
         super().setUp()