Merge ~ines-almeida/launchpad:project-tokens/interfaces into launchpad:master

[Ines Almeida]

Add interfaces to allow adding Project scoped access tokens through the UI and API

[Colin Watson (cjwatson)]

Remarkably little code here, but that's probably a sign of good design elsewhere. :-) (Of course this can't land until its prerequisite has landed.)

review: Approve

[Ines Almeida (ines-almeida)]

The 2 refactoring MPs I opened earlier took a lot of the code away from these others :)

Addressed the comment, this should be ready to merge once I merge its prerequisite

diff --git a/lib/lp/registry/browser/product.py b/lib/lp/registry/browser/product.py
index bc77dd9..c6dc562 100644
--- a/lib/lp/registry/browser/product.py
+++ b/lib/lp/registry/browser/product.py
@@ -469,6 +469,11 @@ class ProductEditLinksMixin(StructuralSubscriptionMenuMixin):
         return Link("+configure-blueprints", text, summary, icon="edit")
 
     @enabled_with_permission("launchpad.Edit")
+    def access_tokens(self):
+        text = "Manage access tokens"
+        return Link("+access-tokens", text, icon="edit")
+
+    @enabled_with_permission("launchpad.Edit")
     def branding(self):
         text = "Change branding"
         return Link("+branding", text, icon="edit")
@@ -546,6 +551,7 @@ class ProductActionNavigationMenu(NavigationMenu, ProductEditLinksMixin):
             "sharing",
             "search_oci_project",
             "new_oci_project",
+            "access_tokens",
             "webhooks",
         ]
         add_subscribe_link(links)
diff --git a/lib/lp/registry/interfaces/product.py b/lib/lp/registry/interfaces/product.py
index 790f77d..af127f0 100644
--- a/lib/lp/registry/interfaces/product.py
+++ b/lib/lp/registry/interfaces/product.py
@@ -117,6 +117,10 @@ from lp.registry.interfaces.role import (
     IHasDrivers,
     IHasOwner,
 )
+from lp.services.auth.interfaces import (
+    IAccessTokenTarget,
+    IAccessTokenTargetEdit,
+)
 from lp.services.fields import (
     Description,
     IconImageUpload,
@@ -606,6 +610,7 @@ class IProductView(
     IHasCodeImports,
     IServiceUsage,
     IHasGitRepositories,
+    IAccessTokenTarget,
 ):
     """Public IProduct properties."""
 
@@ -1099,7 +1104,11 @@ class IProductView(
         """
 
 
-class IProductEditRestricted(IOfficialBugTagTargetRestricted, IWebhookTarget):
+class IProductEditRestricted(
+    IOfficialBugTagTargetRestricted,
+    IWebhookTarget,
+    IAccessTokenTargetEdit,
+):
     """`IProduct` properties which require launchpad.Edit permission."""
 
     @mutator_for(IProductView["bug_sharing_policy"])
diff --git a/lib/lp/registry/model/product.py b/lib/lp/registry/model/product.py
index 4319feb..1ebe91c 100644
--- a/lib/lp/registry/model/product.py
+++ b/lib/lp/registry/model/product.py
@@ -151,6 +151,7 @@ from lp.registry.model.series import ACTIVE_STATUSES
 from lp.registry.model.sharingpolicy import SharingPolicyMixin
 from lp.registry.model.sourcepackagename import SourcePackageName
 from lp.registry.model.teammembership import TeamParticipation
+from lp.services.auth.model import AccessTokenTargetMixin
 from lp.services.database import bulk
 from lp.services.database.constants import UTC_NOW
 from lp.services.database.decoratedresultset import DecoratedResultSet
@@ -249,6 +250,7 @@ specification_policy_default = {
 @implementer(IBugSummaryDimension, IHasCustomLanguageCodes, IProduct)
 class Product(
     StormBase,
+    AccessTokenTargetMixin,
     BugTargetBase,
     HasDriversMixin,
     OfficialBugTagTargetMixin,
diff --git a/lib/lp/services/auth/tests/test_browser.py b/lib/lp/services/auth/tests/test_browser.py
index a1aba38..76e1221 100644
--- a/lib/lp/services/auth/tests/test_browser.py
+++ b/lib/lp/services/auth/tests/test_browser.py
@@ -74,9 +74,9 @@ class TestAccessTokenViewBase:
         return view
 
     def test_access_tokens_link(self):
-        target_url = canonical_url(self.target, rootsite="code")
+        target_url = canonical_url(self.target, rootsite=self.rootsite)
         expected_tokens_url = canonical_url(
-            self.target, view_name="+access-tokens", rootsite="code"
+            self.target, view_name="+access-tokens", rootsite=self.rootsite
         )
         browser = self.getUserBrowser(target_url, user=self.owner)
         tokens_link = browser.getLink("Manage access tokens")
@@ -114,20 +114,14 @@ class TestAccessTokenViewBase:
     def test_empty(self):
         self.assertThat(
             self.makeView("+access-tokens")(),
-            MatchesAll(
-                token_listing_constants,
-                soupmatchers.HTMLContains(token_listing_tag),
-            ),
+            MatchesAll(*self.getPageContent(token_matchers=[])),
         )
 
     def test_existing_tokens(self):
         token_matchers = self.makeTokensAndMatchers(10)
         self.assertThat(
             self.makeView("+access-tokens")(),
-            MatchesAll(
-                token_listing_constants,
-                soupmatchers.HTMLContains(token_listing_tag, *token_matchers),
-            ),
+            MatchesAll(*self.getPageContent(token_matchers)),
         )
 
     def test_revoke(self):
@@ -190,8 +184,29 @@ class TestAccessTokenViewBase:
 class TestAccessTokenViewGitRepository(
     TestAccessTokenViewBase, TestCaseWithFactory
 ):
+    rootsite = "code"
+
     def makeTarget(self):
         return self.factory.makeGitRepository()
 
     def getTraversalStack(self, obj):
         return [obj.target, obj]
+
+    def getPageContent(self, token_matchers):
+        return [
+            token_listing_constants,
+            soupmatchers.HTMLContains(token_listing_tag, *token_matchers),
+        ]
+
+
+class TestAccessTokenViewProject(TestAccessTokenViewBase, TestCaseWithFactory):
+    rootsite = None
+
+    def makeTarget(self):
+        return self.factory.makeProduct()
+
+    def getTraversalStack(self, obj):
+        return [obj]
+
+    def getPageContent(self, token_matchers):
+        return [soupmatchers.HTMLContains(token_listing_tag, *token_matchers)]
diff --git a/lib/lp/services/auth/tests/test_model.py b/lib/lp/services/auth/tests/test_model.py
index a02904a..80dda03 100644
--- a/lib/lp/services/auth/tests/test_model.py
+++ b/lib/lp/services/auth/tests/test_model.py
@@ -819,3 +819,10 @@ class TestAccessTokenTargetGitRepository(
             b"user.",
             response.body,
         )
+
+
+class TestAccessTokenTargetProject(
+    TestAccessTokenTargetBase, TestCaseWithFactory
+):
+    def makeTarget(self):
+        return self.factory.makeProduct()
diff --git a/lib/lp/services/webapp/tests/test_servers.py b/lib/lp/services/webapp/tests/test_servers.py
index e777ac2..491fed7 100644
--- a/lib/lp/services/webapp/tests/test_servers.py
+++ b/lib/lp/services/webapp/tests/test_servers.py
@@ -968,6 +968,13 @@ class TestWebServiceAccessTokensGitRepository(
         return self.factory.makeGitRepository(owner=owner)
 
 
+class TestWebServiceAccessTokensProject(
+    TestWebServiceAccessTokensBase, TestCaseWithFactory
+):
+    def makeTarget(self, owner=None):
+        return self.factory.makeProduct(owner=owner)
+
+
 def test_suite():
     suite = unittest.TestSuite()
     suite.addTest(