Merge ~ines-almeida/launchpad:update-queued-webhook-table-permissions into launchpad:master
Proposed by
Ines Almeida
Status: | Merged |
---|---|
Approved by: | Ines Almeida |
Approved revision: | 75f47e2defc8cfc26a20113eb2ceb63cc16f5c19 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~ines-almeida/launchpad:update-queued-webhook-table-permissions |
Merge into: | launchpad:master |
Diff against target: |
114 lines (+85/-0) 2 files modified
database/schema/security.cfg (+2/-0) lib/lp/soyuz/tests/test_packagecopyjob.py (+83/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson (community) | Approve | ||
Guruprasad | Approve | ||
Review via email: mp+445444@code.launchpad.net |
Commit message
Update 'queued' database permissions for webhook and webhookjob table
Add unit test to verify the change
Description of the change
We recently deployed the change that triggers webhooks on bugs creation/change.
Publishing a package with which bugs were fixed within the changelog, changes the status of those bugs to 'FIX RELEASED' which in turn will try to trigger webhooks if they are set up.
This was causing problems because the `queued` user didn'thave permissions to access the `webhook` and `webhookjob` tables.
This MP adds those permissions to the needed user.
The added unit test failed before the database permissions update, and passes after the change is applied.
To post a comment you must log in.
LGTM 👍