Merge ~ines-almeida/launchpad-layers:add-storm_cache_size-config into launchpad-layers:main
Proposed by
Ines Almeida
Status: | Merged |
---|---|
Approved by: | Ines Almeida |
Approved revision: | 07969165be6692a8843a8b164ce9ff531bba069e |
Merge reported by: | Ines Almeida |
Merged at revision: | 07969165be6692a8843a8b164ce9ff531bba069e |
Proposed branch: | ~ines-almeida/launchpad-layers:add-storm_cache_size-config |
Merge into: | launchpad-layers:main |
Diff against target: |
21 lines (+5/-0) 2 files modified
launchpad-db/config.yaml (+4/-0) launchpad-db/templates/launchpad-db-lazr.conf (+1/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson (community) | Approve | ||
Review via email: mp+449203@code.launchpad.net |
Commit message
Add storm_cache_size param to launchpad-db config.yaml
Description of the change
The value for this param will be overwritten in the ppa publisher charm, but its config should be within the launchpaddb layer
To post a comment you must log in.
I think you should also add `storm_cache_size: {{ storm_cache_size }}` to the `[database]` section in `launchpad- db/templates/ launchpad- db-lazr. conf`. It won't hurt since the default in the charm is the same as the default in the config schema, and it'll save a bit of work in the PPA publisher charm.