Merge ~ines-almeida/launchpad-buildd:close-session-for-fetch-service into launchpad-buildd:master
Proposed by
Ines Almeida
Status: | Rejected |
---|---|
Rejected by: | Ines Almeida |
Proposed branch: | ~ines-almeida/launchpad-buildd:close-session-for-fetch-service |
Merge into: | launchpad-buildd:master |
Prerequisite: | ~ines-almeida/launchpad-buildd:update-close-session-for-fetch-service |
Diff against target: |
215 lines (+139/-1) 5 files modified
lpbuildd/proxy.py (+22/-1) lpbuildd/snap.py (+7/-0) lpbuildd/tests/test_snap.py (+34/-0) lpbuildd/tests/test_util.py (+41/-0) lpbuildd/util.py (+35/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Launchpad code reviewers | Pending | ||
Review via email: mp+463119@code.launchpad.net |
Commit message
End proxy session and gather data when using the fetch service
We send an API request to the fetch service to end the proxy session, save the data from the response locally, and upload it as a build file
To post a comment you must log in.
I would still like to spend some more time going over where is the best place to call the method to save the fetch service data, but I think this is in a good enough state for a review.