Merge lp:~indicator-applet-developers/libindicator/ubuntu into lp:~ubuntu-desktop/libindicator/ubuntu

Proposed by Ted Gould
Status: Merged
Merged at revision: 366
Proposed branch: lp:~indicator-applet-developers/libindicator/ubuntu
Merge into: lp:~ubuntu-desktop/libindicator/ubuntu
Diff against target: 455 lines (+190/-25)
9 files modified
AUTHORS (+1/-0)
ChangeLog (+15/-0)
Makefile.in (+1/-0)
configure (+159/-24)
configure.ac (+4/-1)
debian/changelog (+7/-0)
libindicator/Makefile.in (+1/-0)
tests/Makefile.in (+1/-0)
tools/Makefile.in (+1/-0)
To merge this branch: bzr merge lp:~indicator-applet-developers/libindicator/ubuntu
Reviewer Review Type Date Requested Status
Ken VanDine Approve
Sebastien Bacher Pending
Review via email: mp+76139@code.launchpad.net

Description of the change

Updated release with FTBFS fix

To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'AUTHORS'
2--- AUTHORS 2011-07-14 18:33:11 +0000
3+++ AUTHORS 2011-09-20 03:44:24 +0000
4@@ -3,6 +3,7 @@
5 Aurelien Gateau
6 Cody Russell
7 Eitan Isaacson
8+ Evgeni Golov
9 Javier Jardón
10 Karl
11 Ken VanDine
12
13=== modified file 'ChangeLog'
14--- ChangeLog 2011-08-11 14:42:37 +0000
15+++ ChangeLog 2011-09-20 03:44:24 +0000
16@@ -1,5 +1,20 @@
17 # Generated by Makefile. Do not edit.
18
19+2011-09-19 Ted Gould <ted@gould.cx>
20+
21+ 0.4.0
22+
23+2011-09-16 Ted Gould <ted@gould.cx>
24+
25+ Add in libm
26+
27+2011-09-03 Evgeni Golov <evgeni@debian.org>
28+
29+ find and link libm
30+
31+ otherwise it will ftbfs with --as-needed because
32+ libindicator/indicator-image-helper.c uses round() but does not link to libm
33+
34 2011-08-11 Ted Gould <ted@gould.cx>
35
36 0.3.93
37
38=== modified file 'Makefile.in'
39--- Makefile.in 2011-08-11 14:43:07 +0000
40+++ Makefile.in 2011-09-20 03:44:24 +0000
41@@ -151,6 +151,7 @@
42 LIBDIR = @LIBDIR@
43 LIBINDICATOR_CFLAGS = @LIBINDICATOR_CFLAGS@
44 LIBINDICATOR_LIBS = @LIBINDICATOR_LIBS@
45+LIBM = @LIBM@
46 LIBOBJS = @LIBOBJS@
47 LIBS = @LIBS@
48 LIBTOOL = @LIBTOOL@
49
50=== modified file 'configure'
51--- configure 2011-08-11 14:43:07 +0000
52+++ configure 2011-09-20 03:44:24 +0000
53@@ -1,6 +1,6 @@
54 #! /bin/sh
55 # Guess values for system-dependent variables and create Makefiles.
56-# Generated by GNU Autoconf 2.68 for libindicator 0.3.93.
57+# Generated by GNU Autoconf 2.68 for libindicator 0.4.0.
58 #
59 # Report bugs to <http://bugs.launchpad.net/libindicator>.
60 #
61@@ -709,8 +709,8 @@
62 # Identity of this package.
63 PACKAGE_NAME='libindicator'
64 PACKAGE_TARNAME='libindicator'
65-PACKAGE_VERSION='0.3.93'
66-PACKAGE_STRING='libindicator 0.3.93'
67+PACKAGE_VERSION='0.4.0'
68+PACKAGE_STRING='libindicator 0.4.0'
69 PACKAGE_BUGREPORT='http://bugs.launchpad.net/libindicator'
70 PACKAGE_URL='http://launchpad.net/libindicator'
71
72@@ -760,6 +760,7 @@
73 SYSCONFDIR
74 PREFIX
75 EXPANDED_SYSCONFDIR
76+LIBM
77 USE_GTK3_FALSE
78 USE_GTK3_TRUE
79 LIBINDICATOR_LIBS
80@@ -1451,7 +1452,7 @@
81 # Omit some internal or obsolete options to make the list less imposing.
82 # This message is too long to be a string in the A/UX 3.1 sh.
83 cat <<_ACEOF
84-\`configure' configures libindicator 0.3.93 to adapt to many kinds of systems.
85+\`configure' configures libindicator 0.4.0 to adapt to many kinds of systems.
86
87 Usage: $0 [OPTION]... [VAR=VALUE]...
88
89@@ -1521,7 +1522,7 @@
90
91 if test -n "$ac_init_help"; then
92 case $ac_init_help in
93- short | recursive ) echo "Configuration of libindicator 0.3.93:";;
94+ short | recursive ) echo "Configuration of libindicator 0.4.0:";;
95 esac
96 cat <<\_ACEOF
97
98@@ -1637,7 +1638,7 @@
99 test -n "$ac_init_help" && exit $ac_status
100 if $ac_init_version; then
101 cat <<\_ACEOF
102-libindicator configure 0.3.93
103+libindicator configure 0.4.0
104 generated by GNU Autoconf 2.68
105
106 Copyright (C) 2010 Free Software Foundation, Inc.
107@@ -1915,7 +1916,7 @@
108 This file contains any messages produced by compilers while
109 running configure, to aid debugging if configure makes a mistake.
110
111-It was created by libindicator $as_me 0.3.93, which was
112+It was created by libindicator $as_me 0.4.0, which was
113 generated by GNU Autoconf 2.68. Invocation command line was
114
115 $ $0 $@
116@@ -2737,7 +2738,7 @@
117
118 # Define the identity of the package.
119 PACKAGE='libindicator'
120- VERSION='0.3.93'
121+ VERSION='0.4.0'
122
123
124 cat >>confdefs.h <<_ACEOF
125@@ -4685,13 +4686,13 @@
126 else
127 lt_cv_nm_interface="BSD nm"
128 echo "int some_variable = 0;" > conftest.$ac_ext
129- (eval echo "\"\$as_me:4688: $ac_compile\"" >&5)
130+ (eval echo "\"\$as_me:4689: $ac_compile\"" >&5)
131 (eval "$ac_compile" 2>conftest.err)
132 cat conftest.err >&5
133- (eval echo "\"\$as_me:4691: $NM \\\"conftest.$ac_objext\\\"\"" >&5)
134+ (eval echo "\"\$as_me:4692: $NM \\\"conftest.$ac_objext\\\"\"" >&5)
135 (eval "$NM \"conftest.$ac_objext\"" 2>conftest.err > conftest.out)
136 cat conftest.err >&5
137- (eval echo "\"\$as_me:4694: output\"" >&5)
138+ (eval echo "\"\$as_me:4695: output\"" >&5)
139 cat conftest.out >&5
140 if $GREP 'External.*some_variable' conftest.out > /dev/null; then
141 lt_cv_nm_interface="MS dumpbin"
142@@ -5897,7 +5898,7 @@
143 ;;
144 *-*-irix6*)
145 # Find out which ABI we are using.
146- echo '#line 5900 "configure"' > conftest.$ac_ext
147+ echo '#line 5901 "configure"' > conftest.$ac_ext
148 if { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_compile\""; } >&5
149 (eval $ac_compile) 2>&5
150 ac_status=$?
151@@ -7426,11 +7427,11 @@
152 -e 's:.*FLAGS}\{0,1\} :&$lt_compiler_flag :; t' \
153 -e 's: [^ ]*conftest\.: $lt_compiler_flag&:; t' \
154 -e 's:$: $lt_compiler_flag:'`
155- (eval echo "\"\$as_me:7429: $lt_compile\"" >&5)
156+ (eval echo "\"\$as_me:7430: $lt_compile\"" >&5)
157 (eval "$lt_compile" 2>conftest.err)
158 ac_status=$?
159 cat conftest.err >&5
160- echo "$as_me:7433: \$? = $ac_status" >&5
161+ echo "$as_me:7434: \$? = $ac_status" >&5
162 if (exit $ac_status) && test -s "$ac_outfile"; then
163 # The compiler can only warn and ignore the option if not recognized
164 # So say no if there are warnings other than the usual output.
165@@ -7765,11 +7766,11 @@
166 -e 's:.*FLAGS}\{0,1\} :&$lt_compiler_flag :; t' \
167 -e 's: [^ ]*conftest\.: $lt_compiler_flag&:; t' \
168 -e 's:$: $lt_compiler_flag:'`
169- (eval echo "\"\$as_me:7768: $lt_compile\"" >&5)
170+ (eval echo "\"\$as_me:7769: $lt_compile\"" >&5)
171 (eval "$lt_compile" 2>conftest.err)
172 ac_status=$?
173 cat conftest.err >&5
174- echo "$as_me:7772: \$? = $ac_status" >&5
175+ echo "$as_me:7773: \$? = $ac_status" >&5
176 if (exit $ac_status) && test -s "$ac_outfile"; then
177 # The compiler can only warn and ignore the option if not recognized
178 # So say no if there are warnings other than the usual output.
179@@ -7870,11 +7871,11 @@
180 -e 's:.*FLAGS}\{0,1\} :&$lt_compiler_flag :; t' \
181 -e 's: [^ ]*conftest\.: $lt_compiler_flag&:; t' \
182 -e 's:$: $lt_compiler_flag:'`
183- (eval echo "\"\$as_me:7873: $lt_compile\"" >&5)
184+ (eval echo "\"\$as_me:7874: $lt_compile\"" >&5)
185 (eval "$lt_compile" 2>out/conftest.err)
186 ac_status=$?
187 cat out/conftest.err >&5
188- echo "$as_me:7877: \$? = $ac_status" >&5
189+ echo "$as_me:7878: \$? = $ac_status" >&5
190 if (exit $ac_status) && test -s out/conftest2.$ac_objext
191 then
192 # The compiler can only warn and ignore the option if not recognized
193@@ -7925,11 +7926,11 @@
194 -e 's:.*FLAGS}\{0,1\} :&$lt_compiler_flag :; t' \
195 -e 's: [^ ]*conftest\.: $lt_compiler_flag&:; t' \
196 -e 's:$: $lt_compiler_flag:'`
197- (eval echo "\"\$as_me:7928: $lt_compile\"" >&5)
198+ (eval echo "\"\$as_me:7929: $lt_compile\"" >&5)
199 (eval "$lt_compile" 2>out/conftest.err)
200 ac_status=$?
201 cat out/conftest.err >&5
202- echo "$as_me:7932: \$? = $ac_status" >&5
203+ echo "$as_me:7933: \$? = $ac_status" >&5
204 if (exit $ac_status) && test -s out/conftest2.$ac_objext
205 then
206 # The compiler can only warn and ignore the option if not recognized
207@@ -10309,7 +10310,7 @@
208 lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
209 lt_status=$lt_dlunknown
210 cat > conftest.$ac_ext <<_LT_EOF
211-#line 10312 "configure"
212+#line 10313 "configure"
213 #include "confdefs.h"
214
215 #if HAVE_DLFCN_H
216@@ -10405,7 +10406,7 @@
217 lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
218 lt_status=$lt_dlunknown
219 cat > conftest.$ac_ext <<_LT_EOF
220-#line 10408 "configure"
221+#line 10409 "configure"
222 #include "confdefs.h"
223
224 #if HAVE_DLFCN_H
225@@ -11083,6 +11084,140 @@
226 fi
227
228
229+LIBM=
230+case $host in
231+*-*-beos* | *-*-cygwin* | *-*-pw32* | *-*-darwin*)
232+ # These system don't have libm, or don't need it
233+ ;;
234+*-ncr-sysv4.3*)
235+ { $as_echo "$as_me:${as_lineno-$LINENO}: checking for _mwvalidcheckl in -lmw" >&5
236+$as_echo_n "checking for _mwvalidcheckl in -lmw... " >&6; }
237+if ${ac_cv_lib_mw__mwvalidcheckl+:} false; then :
238+ $as_echo_n "(cached) " >&6
239+else
240+ ac_check_lib_save_LIBS=$LIBS
241+LIBS="-lmw $LIBS"
242+cat confdefs.h - <<_ACEOF >conftest.$ac_ext
243+/* end confdefs.h. */
244+
245+/* Override any GCC internal prototype to avoid an error.
246+ Use char because int might match the return type of a GCC
247+ builtin and then its argument prototype would still apply. */
248+#ifdef __cplusplus
249+extern "C"
250+#endif
251+char _mwvalidcheckl ();
252+int
253+main ()
254+{
255+return _mwvalidcheckl ();
256+ ;
257+ return 0;
258+}
259+_ACEOF
260+if ac_fn_c_try_link "$LINENO"; then :
261+ ac_cv_lib_mw__mwvalidcheckl=yes
262+else
263+ ac_cv_lib_mw__mwvalidcheckl=no
264+fi
265+rm -f core conftest.err conftest.$ac_objext \
266+ conftest$ac_exeext conftest.$ac_ext
267+LIBS=$ac_check_lib_save_LIBS
268+fi
269+{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_cv_lib_mw__mwvalidcheckl" >&5
270+$as_echo "$ac_cv_lib_mw__mwvalidcheckl" >&6; }
271+if test "x$ac_cv_lib_mw__mwvalidcheckl" = xyes; then :
272+ LIBM="-lmw"
273+fi
274+
275+ { $as_echo "$as_me:${as_lineno-$LINENO}: checking for cos in -lm" >&5
276+$as_echo_n "checking for cos in -lm... " >&6; }
277+if ${ac_cv_lib_m_cos+:} false; then :
278+ $as_echo_n "(cached) " >&6
279+else
280+ ac_check_lib_save_LIBS=$LIBS
281+LIBS="-lm $LIBS"
282+cat confdefs.h - <<_ACEOF >conftest.$ac_ext
283+/* end confdefs.h. */
284+
285+/* Override any GCC internal prototype to avoid an error.
286+ Use char because int might match the return type of a GCC
287+ builtin and then its argument prototype would still apply. */
288+#ifdef __cplusplus
289+extern "C"
290+#endif
291+char cos ();
292+int
293+main ()
294+{
295+return cos ();
296+ ;
297+ return 0;
298+}
299+_ACEOF
300+if ac_fn_c_try_link "$LINENO"; then :
301+ ac_cv_lib_m_cos=yes
302+else
303+ ac_cv_lib_m_cos=no
304+fi
305+rm -f core conftest.err conftest.$ac_objext \
306+ conftest$ac_exeext conftest.$ac_ext
307+LIBS=$ac_check_lib_save_LIBS
308+fi
309+{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_cv_lib_m_cos" >&5
310+$as_echo "$ac_cv_lib_m_cos" >&6; }
311+if test "x$ac_cv_lib_m_cos" = xyes; then :
312+ LIBM="$LIBM -lm"
313+fi
314+
315+ ;;
316+*)
317+ { $as_echo "$as_me:${as_lineno-$LINENO}: checking for cos in -lm" >&5
318+$as_echo_n "checking for cos in -lm... " >&6; }
319+if ${ac_cv_lib_m_cos+:} false; then :
320+ $as_echo_n "(cached) " >&6
321+else
322+ ac_check_lib_save_LIBS=$LIBS
323+LIBS="-lm $LIBS"
324+cat confdefs.h - <<_ACEOF >conftest.$ac_ext
325+/* end confdefs.h. */
326+
327+/* Override any GCC internal prototype to avoid an error.
328+ Use char because int might match the return type of a GCC
329+ builtin and then its argument prototype would still apply. */
330+#ifdef __cplusplus
331+extern "C"
332+#endif
333+char cos ();
334+int
335+main ()
336+{
337+return cos ();
338+ ;
339+ return 0;
340+}
341+_ACEOF
342+if ac_fn_c_try_link "$LINENO"; then :
343+ ac_cv_lib_m_cos=yes
344+else
345+ ac_cv_lib_m_cos=no
346+fi
347+rm -f core conftest.err conftest.$ac_objext \
348+ conftest$ac_exeext conftest.$ac_ext
349+LIBS=$ac_check_lib_save_LIBS
350+fi
351+{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_cv_lib_m_cos" >&5
352+$as_echo "$ac_cv_lib_m_cos" >&6; }
353+if test "x$ac_cv_lib_m_cos" = xyes; then :
354+ LIBM="-lm"
355+fi
356+
357+ ;;
358+esac
359+
360+
361+LIBINDICATOR_LIBS+="$LIBM"
362+
363 ##############################
364 # Custom Junk
365 ##############################
366@@ -11730,7 +11865,7 @@
367 # report actual input values of CONFIG_FILES etc. instead of their
368 # values after options handling.
369 ac_log="
370-This file was extended by libindicator $as_me 0.3.93, which was
371+This file was extended by libindicator $as_me 0.4.0, which was
372 generated by GNU Autoconf 2.68. Invocation command line was
373
374 CONFIG_FILES = $CONFIG_FILES
375@@ -11797,7 +11932,7 @@
376 cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
377 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"
378 ac_cs_version="\\
379-libindicator config.status 0.3.93
380+libindicator config.status 0.4.0
381 configured by $0, generated by GNU Autoconf 2.68,
382 with options \\"\$ac_cs_config\\"
383
384
385=== modified file 'configure.ac'
386--- configure.ac 2011-08-11 14:43:07 +0000
387+++ configure.ac 2011-09-20 03:44:24 +0000
388@@ -1,5 +1,5 @@
389 AC_INIT([libindicator],
390- [0.3.93],
391+ [0.4.0],
392 [http://bugs.launchpad.net/libindicator],
393 [libindicator],
394 [http://launchpad.net/libindicator])
395@@ -62,6 +62,9 @@
396 )
397 AM_CONDITIONAL(USE_GTK3, [test "x$with_gtk" = x3])
398
399+LT_LIB_M
400+LIBINDICATOR_LIBS+="$LIBM"
401+
402 ##############################
403 # Custom Junk
404 ##############################
405
406=== modified file 'debian/changelog'
407--- debian/changelog 2011-09-01 21:22:14 +0000
408+++ debian/changelog 2011-09-20 03:44:24 +0000
409@@ -1,3 +1,10 @@
410+libindicator (0.4.0-0ubuntu1~ppa1) oneiric; urgency=low
411+
412+ * New upstream release.
413+ * Add libm to linking to fix FTBFS (LP: #840514)
414+
415+ -- Ted Gould <ted@ubuntu.com> Mon, 19 Sep 2011 21:54:32 -0500
416+
417 libindicator (0.3.93-0ubuntu2) oneiric; urgency=low
418
419 * Drop the Breaks: against old versions of libindicator and libindicator3;
420
421=== modified file 'libindicator/Makefile.in'
422--- libindicator/Makefile.in 2011-08-11 14:43:07 +0000
423+++ libindicator/Makefile.in 2011-09-20 03:44:24 +0000
424@@ -205,6 +205,7 @@
425 LIBDIR = @LIBDIR@
426 LIBINDICATOR_CFLAGS = @LIBINDICATOR_CFLAGS@
427 LIBINDICATOR_LIBS = @LIBINDICATOR_LIBS@
428+LIBM = @LIBM@
429 LIBOBJS = @LIBOBJS@
430 LIBS = @LIBS@
431 LIBTOOL = @LIBTOOL@
432
433=== modified file 'tests/Makefile.in'
434--- tests/Makefile.in 2011-07-14 18:34:38 +0000
435+++ tests/Makefile.in 2011-09-20 03:44:24 +0000
436@@ -345,6 +345,7 @@
437 LIBDIR = @LIBDIR@
438 LIBINDICATOR_CFLAGS = @LIBINDICATOR_CFLAGS@
439 LIBINDICATOR_LIBS = @LIBINDICATOR_LIBS@
440+LIBM = @LIBM@
441 LIBOBJS = @LIBOBJS@
442 LIBS = @LIBS@
443 LIBTOOL = @LIBTOOL@
444
445=== modified file 'tools/Makefile.in'
446--- tools/Makefile.in 2011-07-14 18:34:38 +0000
447+++ tools/Makefile.in 2011-09-20 03:44:24 +0000
448@@ -166,6 +166,7 @@
449 LIBDIR = @LIBDIR@
450 LIBINDICATOR_CFLAGS = @LIBINDICATOR_CFLAGS@
451 LIBINDICATOR_LIBS = @LIBINDICATOR_LIBS@
452+LIBM = @LIBM@
453 LIBOBJS = @LIBOBJS@
454 LIBS = @LIBS@
455 LIBTOOL = @LIBTOOL@

Subscribers

People subscribed via source and target branches

to all changes: