Merge lp:~indicator-applet-developers/libindicator/ubuntu into lp:~ubuntu-desktop/libindicator/ubuntu

Proposed by Ted Gould
Status: Merged
Merged at revision: 275
Proposed branch: lp:~indicator-applet-developers/libindicator/ubuntu
Merge into: lp:~ubuntu-desktop/libindicator/ubuntu
Diff against target: 344 lines (+119/-36)
9 files modified
configure (+10/-10)
configure.ac (+2/-2)
debian/changelog (+7/-0)
libindicator/indicator-object-marshal.c (+39/-0)
libindicator/indicator-object-marshal.h (+8/-0)
libindicator/indicator-object-marshal.list (+1/-0)
libindicator/indicator-object.c (+36/-17)
libindicator/indicator-object.h (+8/-7)
tools/indicator-loader.c (+8/-0)
To merge this branch: bzr merge lp:~indicator-applet-developers/libindicator/ubuntu
Reviewer Review Type Date Requested Status
Ken VanDine Pending
Review via email: mp+35557@code.launchpad.net

Description of the change

0.3.13

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure'
2--- configure 2010-08-18 16:01:43 +0000
3+++ configure 2010-09-15 16:49:43 +0000
4@@ -1,6 +1,6 @@
5 #! /bin/sh
6 # Guess values for system-dependent variables and create Makefiles.
7-# Generated by GNU Autoconf 2.67 for libindicator 0.3.12.
8+# Generated by GNU Autoconf 2.67 for libindicator 0.3.13.
9 #
10 # Report bugs to <ted@canonical.com>.
11 #
12@@ -701,8 +701,8 @@
13 # Identity of this package.
14 PACKAGE_NAME='libindicator'
15 PACKAGE_TARNAME='libindicator'
16-PACKAGE_VERSION='0.3.12'
17-PACKAGE_STRING='libindicator 0.3.12'
18+PACKAGE_VERSION='0.3.13'
19+PACKAGE_STRING='libindicator 0.3.13'
20 PACKAGE_BUGREPORT='ted@canonical.com'
21 PACKAGE_URL=''
22
23@@ -1439,7 +1439,7 @@
24 # Omit some internal or obsolete options to make the list less imposing.
25 # This message is too long to be a string in the A/UX 3.1 sh.
26 cat <<_ACEOF
27-\`configure' configures libindicator 0.3.12 to adapt to many kinds of systems.
28+\`configure' configures libindicator 0.3.13 to adapt to many kinds of systems.
29
30 Usage: $0 [OPTION]... [VAR=VALUE]...
31
32@@ -1509,7 +1509,7 @@
33
34 if test -n "$ac_init_help"; then
35 case $ac_init_help in
36- short | recursive ) echo "Configuration of libindicator 0.3.12:";;
37+ short | recursive ) echo "Configuration of libindicator 0.3.13:";;
38 esac
39 cat <<\_ACEOF
40
41@@ -1622,7 +1622,7 @@
42 test -n "$ac_init_help" && exit $ac_status
43 if $ac_init_version; then
44 cat <<\_ACEOF
45-libindicator configure 0.3.12
46+libindicator configure 0.3.13
47 generated by GNU Autoconf 2.67
48
49 Copyright (C) 2010 Free Software Foundation, Inc.
50@@ -1900,7 +1900,7 @@
51 This file contains any messages produced by compilers while
52 running configure, to aid debugging if configure makes a mistake.
53
54-It was created by libindicator $as_me 0.3.12, which was
55+It was created by libindicator $as_me 0.3.13, which was
56 generated by GNU Autoconf 2.67. Invocation command line was
57
58 $ $0 $@
59@@ -2720,7 +2720,7 @@
60
61 # Define the identity of the package.
62 PACKAGE=libindicator
63- VERSION=0.3.12
64+ VERSION=0.3.13
65
66
67 cat >>confdefs.h <<_ACEOF
68@@ -12222,7 +12222,7 @@
69 # report actual input values of CONFIG_FILES etc. instead of their
70 # values after options handling.
71 ac_log="
72-This file was extended by libindicator $as_me 0.3.12, which was
73+This file was extended by libindicator $as_me 0.3.13, which was
74 generated by GNU Autoconf 2.67. Invocation command line was
75
76 CONFIG_FILES = $CONFIG_FILES
77@@ -12288,7 +12288,7 @@
78 cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
79 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"
80 ac_cs_version="\\
81-libindicator config.status 0.3.12
82+libindicator config.status 0.3.13
83 configured by $0, generated by GNU Autoconf 2.67,
84 with options \\"\$ac_cs_config\\"
85
86
87=== modified file 'configure.ac'
88--- configure.ac 2010-08-18 16:02:28 +0000
89+++ configure.ac 2010-09-15 16:49:43 +0000
90@@ -1,10 +1,10 @@
91
92-AC_INIT(libindicator, 0.3.12, ted@canonical.com)
93+AC_INIT(libindicator, 0.3.13, ted@canonical.com)
94
95 AC_PREREQ(2.53)
96
97 AM_CONFIG_HEADER(config.h)
98-AM_INIT_AUTOMAKE(libindicator, 0.3.12)
99+AM_INIT_AUTOMAKE(libindicator, 0.3.13)
100
101 AM_MAINTAINER_MODE
102 m4_ifdef([AM_SILENT_RULES],[AM_SILENT_RULES])
103
104=== modified file 'debian/changelog'
105--- debian/changelog 2010-08-18 16:48:09 +0000
106+++ debian/changelog 2010-09-15 16:49:43 +0000
107@@ -1,3 +1,10 @@
108+libindicator (0.3.13-0ubuntu1~ppa1) maverick; urgency=low
109+
110+ * New upstream release.
111+ * Adding a menu_show signal
112+
113+ -- Ted Gould <ted@ubuntu.com> Wed, 15 Sep 2010 11:46:37 -0500
114+
115 libindicator (0.3.12-0ubuntu1) maverick; urgency=low
116
117 * New upstream release.
118
119=== modified file 'libindicator/indicator-object-marshal.c'
120--- libindicator/indicator-object-marshal.c 2010-04-09 16:57:53 +0000
121+++ libindicator/indicator-object-marshal.c 2010-09-15 16:49:43 +0000
122@@ -22,6 +22,7 @@
123 #define g_marshal_value_peek_boxed(v) g_value_get_boxed (v)
124 #define g_marshal_value_peek_pointer(v) g_value_get_pointer (v)
125 #define g_marshal_value_peek_object(v) g_value_get_object (v)
126+#define g_marshal_value_peek_variant(v) g_value_get_variant (v)
127 #else /* !G_ENABLE_DEBUG */
128 /* WARNING: This code accesses GValues directly, which is UNSUPPORTED API.
129 * Do not access GValues directly in your code. Instead, use the
130@@ -45,6 +46,7 @@
131 #define g_marshal_value_peek_boxed(v) (v)->data[0].v_pointer
132 #define g_marshal_value_peek_pointer(v) (v)->data[0].v_pointer
133 #define g_marshal_value_peek_object(v) (v)->data[0].v_pointer
134+#define g_marshal_value_peek_variant(v) (v)->data[0].v_pointer
135 #endif /* !G_ENABLE_DEBUG */
136
137
138@@ -124,3 +126,40 @@
139 data2);
140 }
141
142+/* VOID:POINTER,UINT (./indicator-object-marshal.list:3) */
143+void
144+_indicator_object_marshal_VOID__POINTER_UINT (GClosure *closure,
145+ GValue *return_value G_GNUC_UNUSED,
146+ guint n_param_values,
147+ const GValue *param_values,
148+ gpointer invocation_hint G_GNUC_UNUSED,
149+ gpointer marshal_data)
150+{
151+ typedef void (*GMarshalFunc_VOID__POINTER_UINT) (gpointer data1,
152+ gpointer arg_1,
153+ guint arg_2,
154+ gpointer data2);
155+ register GMarshalFunc_VOID__POINTER_UINT callback;
156+ register GCClosure *cc = (GCClosure*) closure;
157+ register gpointer data1, data2;
158+
159+ g_return_if_fail (n_param_values == 3);
160+
161+ if (G_CCLOSURE_SWAP_DATA (closure))
162+ {
163+ data1 = closure->data;
164+ data2 = g_value_peek_pointer (param_values + 0);
165+ }
166+ else
167+ {
168+ data1 = g_value_peek_pointer (param_values + 0);
169+ data2 = closure->data;
170+ }
171+ callback = (GMarshalFunc_VOID__POINTER_UINT) (marshal_data ? marshal_data : cc->callback);
172+
173+ callback (data1,
174+ g_marshal_value_peek_pointer (param_values + 1),
175+ g_marshal_value_peek_uint (param_values + 2),
176+ data2);
177+}
178+
179
180=== modified file 'libindicator/indicator-object-marshal.h'
181--- libindicator/indicator-object-marshal.h 2010-04-09 16:57:53 +0000
182+++ libindicator/indicator-object-marshal.h 2010-09-15 16:49:43 +0000
183@@ -22,6 +22,14 @@
184 gpointer invocation_hint,
185 gpointer marshal_data);
186
187+/* VOID:POINTER,UINT (./indicator-object-marshal.list:3) */
188+extern void _indicator_object_marshal_VOID__POINTER_UINT (GClosure *closure,
189+ GValue *return_value,
190+ guint n_param_values,
191+ const GValue *param_values,
192+ gpointer invocation_hint,
193+ gpointer marshal_data);
194+
195 G_END_DECLS
196
197 #endif /* ___indicator_object_marshal_MARSHAL_H__ */
198
199=== modified file 'libindicator/indicator-object-marshal.list'
200--- libindicator/indicator-object-marshal.list 2010-03-16 16:40:14 +0000
201+++ libindicator/indicator-object-marshal.list 2010-09-15 16:49:43 +0000
202@@ -1,2 +1,3 @@
203 VOID: POINTER, UINT, UINT
204 VOID: UINT,ENUM
205+VOID: POINTER, UINT
206
207=== modified file 'libindicator/indicator-object.c'
208--- libindicator/indicator-object.c 2010-03-17 06:14:13 +0000
209+++ libindicator/indicator-object.c 2010-09-15 16:49:43 +0000
210@@ -57,7 +57,8 @@
211 ENTRY_ADDED,
212 ENTRY_REMOVED,
213 ENTRY_MOVED,
214- SCROLL,
215+ SCROLL,
216+ MENU_SHOW,
217 LAST_SIGNAL
218 };
219
220@@ -145,22 +146,40 @@
221 G_TYPE_NONE, 3, G_TYPE_POINTER, G_TYPE_UINT, G_TYPE_UINT, G_TYPE_NONE);
222
223
224- /**
225- IndicatorObject::scroll:
226- @arg0: The #IndicatorObject object
227- @arg1: The delta of the scroll event
228- @arg2: The orientation of the scroll event.
229-
230- When the indicator receives a mouse scroll wheel event
231- from the user, this signal is emitted.
232- */
233- signals[SCROLL] = g_signal_new (INDICATOR_OBJECT_SIGNAL_SCROLL,
234- G_TYPE_FROM_CLASS(klass),
235- G_SIGNAL_RUN_LAST,
236- G_STRUCT_OFFSET (IndicatorObjectClass, scroll),
237- NULL, NULL,
238- _indicator_object_marshal_VOID__UINT_ENUM,
239- G_TYPE_NONE, 2, G_TYPE_UINT, INDICATOR_OBJECT_TYPE_SCROLL_DIRECTION);
240+ /**
241+ IndicatorObject::scroll:
242+ @arg0: The #IndicatorObject object
243+ @arg1: The delta of the scroll event
244+ @arg2: The orientation of the scroll event.
245+
246+ When the indicator receives a mouse scroll wheel event
247+ from the user, this signal is emitted.
248+ */
249+ signals[SCROLL] = g_signal_new (INDICATOR_OBJECT_SIGNAL_SCROLL,
250+ G_TYPE_FROM_CLASS(klass),
251+ G_SIGNAL_RUN_LAST,
252+ G_STRUCT_OFFSET (IndicatorObjectClass, scroll),
253+ NULL, NULL,
254+ _indicator_object_marshal_VOID__UINT_ENUM,
255+ G_TYPE_NONE, 2, G_TYPE_UINT, INDICATOR_OBJECT_TYPE_SCROLL_DIRECTION);
256+
257+ /**
258+ IndicatorObject::menu-show:
259+ @arg0: The #IndicatorObject object
260+ @arg1: A pointer to the #IndicatorObjectEntry that
261+ is being shown.
262+ @arg2: The timestamp of the event
263+
264+ Used when the indicator wants to signal up the stack
265+ that the menu should be shown.
266+ */
267+ signals[MENU_SHOW] = g_signal_new (INDICATOR_OBJECT_SIGNAL_MENU_SHOW,
268+ G_TYPE_FROM_CLASS(klass),
269+ G_SIGNAL_RUN_LAST,
270+ G_STRUCT_OFFSET (IndicatorObjectClass, menu_show),
271+ NULL, NULL,
272+ _indicator_object_marshal_VOID__POINTER_UINT,
273+ G_TYPE_NONE, 2, G_TYPE_POINTER, G_TYPE_UINT);
274
275
276 return;
277
278=== modified file 'libindicator/indicator-object.h'
279--- libindicator/indicator-object.h 2010-03-16 20:31:15 +0000
280+++ libindicator/indicator-object.h 2010-09-15 16:49:43 +0000
281@@ -51,6 +51,8 @@
282 #define INDICATOR_OBJECT_SIGNAL_ENTRY_MOVED_ID (g_signal_lookup(INDICATOR_OBJECT_SIGNAL_ENTRY_MOVED, INDICATOR_OBJECT_TYPE))
283 #define INDICATOR_OBJECT_SIGNAL_SCROLL "scroll"
284 #define INDICATOR_OBJECT_SIGNAL_SCROLL_ID (g_signal_lookup(INDICATOR_OBJECT_SIGNAL_SCROLL, INDICATOR_OBJECT_TYPE))
285+#define INDICATOR_OBJECT_SIGNAL_MENU_SHOW "menu-show"
286+#define INDICATOR_OBJECT_SIGNAL_MENU_SHOW_ID (g_signal_lookup(INDICATOR_OBJECT_SIGNAL_MENU_SHOW, INDICATOR_OBJECT_TYPE))
287
288 typedef struct _IndicatorObject IndicatorObject;
289 typedef struct _IndicatorObjectClass IndicatorObjectClass;
290@@ -79,8 +81,7 @@
291 @entry_added: Slot for #IndicatorObject::entry-added
292 @entry_removed: Slot for #IndicatorObject::entry-removed
293 @entry_moved: Slot for #IndicatorObject::entry-moved
294- @indicator_object_reserved_1: Reserved for future use
295- @indicator_object_reserved_2: Reserved for future use
296+ @menu_show: Slot for #IndicatorObject::menu-show
297 */
298 struct _IndicatorObjectClass {
299 GObjectClass parent_class;
300@@ -94,13 +95,13 @@
301 guint (*get_location) (IndicatorObject * io, IndicatorObjectEntry * entry);
302
303 /* Signals */
304- void (*entry_added) (IndicatorObject * io, IndicatorObjectEntry * entry, gpointer user_data);
305- void (*entry_removed) (IndicatorObject * io, IndicatorObjectEntry * entry, gpointer user_data);
306- void (*entry_moved) (IndicatorObject * io, IndicatorObjectEntry * entry, guint old_pos, guint new_pos, gpointer user_data);
307- void (*scroll) (IndicatorObject * io, gint delta, IndicatorScrollDirection direction);
308+ void (*entry_added) (IndicatorObject * io, IndicatorObjectEntry * entry, gpointer user_data);
309+ void (*entry_removed) (IndicatorObject * io, IndicatorObjectEntry * entry, gpointer user_data);
310+ void (*entry_moved) (IndicatorObject * io, IndicatorObjectEntry * entry, guint old_pos, guint new_pos, gpointer user_data);
311+ void (*scroll) (IndicatorObject * io, gint delta, IndicatorScrollDirection direction);
312+ void (*menu_show) (IndicatorObject * io, IndicatorObjectEntry * entry, guint timestamp, gpointer user_data);
313
314 /* Reserved */
315- void (* indicator_object_reserved_1) (void);
316 };
317
318 /**
319
320=== modified file 'tools/indicator-loader.c'
321--- tools/indicator-loader.c 2009-12-10 16:32:31 +0000
322+++ tools/indicator-loader.c 2010-09-15 16:49:43 +0000
323@@ -79,6 +79,13 @@
324 return;
325 }
326
327+static void
328+menu_show (IndicatorObject * io, IndicatorObjectEntry * entry, guint timestamp, gpointer user_data)
329+{
330+ g_debug("Show Menu: %s", entry->label != NULL ? gtk_label_get_text(entry->label) : "No Label");
331+ return;
332+}
333+
334 static gboolean
335 load_module (const gchar * name, GtkWidget * menu)
336 {
337@@ -97,6 +104,7 @@
338 /* Connect to it's signals */
339 g_signal_connect(G_OBJECT(io), INDICATOR_OBJECT_SIGNAL_ENTRY_ADDED, G_CALLBACK(entry_added), menu);
340 g_signal_connect(G_OBJECT(io), INDICATOR_OBJECT_SIGNAL_ENTRY_REMOVED, G_CALLBACK(entry_removed), menu);
341+ g_signal_connect(G_OBJECT(io), INDICATOR_OBJECT_SIGNAL_MENU_SHOW, G_CALLBACK(menu_show), NULL);
342
343 /* Work on the entries */
344 GList * entries = indicator_object_get_entries(io);

Subscribers

People subscribed via source and target branches

to all changes: