Merge lp:~indicator-applet-developers/libindicator/ubuntu into lp:~ubuntu-desktop/libindicator/ubuntu

Proposed by Ted Gould
Status: Merged
Merged at revision: not available
Proposed branch: lp:~indicator-applet-developers/libindicator/ubuntu
Merge into: lp:~ubuntu-desktop/libindicator/ubuntu
Diff against target: 328 lines (+140/-17)
10 files modified
AUTHORS (+1/-0)
configure.ac (+5/-3)
debian/changelog (+8/-0)
debian/rules (+1/-1)
libindicator/Makefile.am (+27/-3)
libindicator/indicator-object-enum-types.c.template (+30/-0)
libindicator/indicator-object-enum-types.h.template (+27/-0)
libindicator/indicator-object-marshal.list (+1/-0)
libindicator/indicator-object.c (+24/-3)
libindicator/indicator-object.h (+16/-7)
To merge this branch: bzr merge lp:~indicator-applet-developers/libindicator/ubuntu
Reviewer Review Type Date Requested Status
Ken VanDine Pending
Review via email: mp+21653@code.launchpad.net

Description of the change

0.3.6

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'AUTHORS'
2--- AUTHORS 2009-02-11 21:59:42 +0000
3+++ AUTHORS 2010-03-18 16:33:19 +0000
4@@ -1,1 +1,2 @@
5 Ted Gould <ted@canonical.com>
6+Cody Russell <crussell@canonical.com>
7\ No newline at end of file
8
9=== modified file 'configure.ac'
10--- configure.ac 2010-03-11 20:22:51 +0000
11+++ configure.ac 2010-03-18 16:33:19 +0000
12@@ -1,10 +1,10 @@
13
14-AC_INIT(libindicator, 0.3.5, ted@canonical.com)
15+AC_INIT(libindicator, 0.3.6, ted@canonical.com)
16
17 AC_PREREQ(2.53)
18
19 AM_CONFIG_HEADER(config.h)
20-AM_INIT_AUTOMAKE(libindicator, 0.3.5)
21+AM_INIT_AUTOMAKE(libindicator, 0.3.6)
22
23 AM_MAINTAINER_MODE
24 m4_ifdef([AM_SILENT_RULES],[AM_SILENT_RULES])
25@@ -15,6 +15,8 @@
26 AC_STDC_HEADERS
27 AC_PROG_LIBTOOL
28
29+AC_PATH_PROG([GLIB_MKENUMS], [glib-mkenums])
30+
31 AC_PATH_PROG([GLIB_GENMARSHAL], [glib-genmarshal])
32
33 AC_SUBST(VERSION)
34@@ -66,7 +68,7 @@
35 REAL_PREFIX=$prefix
36 fi
37
38-# Have to go $sysconfdir->$prefix/etc->/usr/local/etc
39+# Have to go $sysconfdir->$prefix/etc->/usr/local/etc
40 # if you actually know how to code shell then fix this :-)
41 SYSCONFDIR_TMP="$sysconfdir"
42 old_prefix=$prefix
43
44=== modified file 'debian/changelog'
45--- debian/changelog 2010-03-11 21:52:27 +0000
46+++ debian/changelog 2010-03-18 16:33:19 +0000
47@@ -1,3 +1,11 @@
48+libindicator (0.3.6-0ubuntu1~ppa1) lucid; urgency=low
49+
50+ * Upstream release 0.3.6
51+ * Adding in scroll signals for the indicators
52+ * debian/rules: Updating shlibs
53+
54+ -- Ted Gould <ted@ubuntu.com> Thu, 18 Mar 2010 11:10:20 -0500
55+
56 libindicator (0.3.5-0ubuntu1) lucid; urgency=low
57
58 * Upstream release 0.3.5
59
60=== modified file 'debian/rules'
61--- debian/rules 2010-03-11 20:26:58 +0000
62+++ debian/rules 2010-03-18 16:33:19 +0000
63@@ -5,4 +5,4 @@
64
65 LDFLAGS += -Wl,-z,defs -Wl,--as-needed
66
67-DEB_DH_MAKESHLIBS_ARGS_libindicator0 += -V 'libindicator0 (>= 0.3.5)'
68+DEB_DH_MAKESHLIBS_ARGS_libindicator0 += -V 'libindicator0 (>= 0.3.6)'
69
70=== modified file 'libindicator/Makefile.am'
71--- libindicator/Makefile.am 2010-03-10 17:45:53 +0000
72+++ libindicator/Makefile.am 2010-03-18 16:33:19 +0000
73@@ -1,6 +1,6 @@
74-BUILT_SOURCES =
75-CLEANFILES =
76-DISTCLEANFILES =
77+BUILT_SOURCES = indicator-object-enum-types.h indicator-object-enum-types.c
78+CLEANFILES =
79+DISTCLEANFILES =
80 EXTRA_DIST = \
81 indicator.pc.in
82
83@@ -26,6 +26,7 @@
84 $(indicator_headers) \
85 dbus-shared.h \
86 indicator-object.c \
87+ indicator-object-enum-types.c \
88 indicator-desktop-shortcuts.c \
89 indicator-image-helper.c \
90 indicator-object-marshal.h \
91@@ -47,6 +48,29 @@
92 glib_marshal_list = indicator-object-marshal.list
93 glib_marshal_prefix = _indicator_object_marshal
94
95+indicator-object-enum-types.h: s-enum-types-h
96+ @true
97+s-enum-types-h: $(indicator_headers)
98+ ( cd $(srcdir) && $(GLIB_MKENUMS) --template $(srcdir)/indicator-object-enum-types.h.template \
99+ $(indicator_headers) ) >> tmp-indicator-object-enum-types.h \
100+ && (cmp -s tmp-indicator-object-enum-types.h indicator-object-enum-types.h || cp tmp-indicator-object-enum-types.h indicator-object-enum-types.h ) \
101+ && rm -f tmp-indicator-object-enum-types.h && echo timestamp > $(@F)
102+
103+indicator-object-enum-types.c: s-enum-types-c
104+ @true
105+s-enum-types-c: $(indicator_headers)
106+ ( cd $(srcdir) && $(GLIB_MKENUMS) --template $(srcdir)/indicator-object-enum-types.c.template \
107+ $(indicator_headers) ) > tmp-indicator-object-enum-types.c \
108+ && (cmp -s tmp-indicator-object-enum-types.c indicator-object-enum-types.c || cp tmp-indicator-object-enum-types.c indicator-object-enum-types.c ) \
109+ && rm -f tmp-indicator-object-enum-types.c
110+
111+EXTRA_DIST += indicator-object-enum-types.h
112+CLEANFILES += \
113+ indicator-object-enum-types.h \
114+ indicator-object-enum-types.c \
115+ s-enum-types-h \
116+ s-enum-types-c
117+
118 ##################################
119 # DBus Specs
120 ##################################
121
122=== added file 'libindicator/indicator-object-enum-types.c.template'
123--- libindicator/indicator-object-enum-types.c.template 1970-01-01 00:00:00 +0000
124+++ libindicator/indicator-object-enum-types.c.template 2010-03-18 16:33:19 +0000
125@@ -0,0 +1,30 @@
126+/*** BEGIN file-header ***/
127+#include "indicator-object-enum-types.h"
128+/*** END file-header ***/
129+
130+/*** BEGIN file-production ***/
131+/* enumerations from "@filename@" */
132+#include "@filename@"
133+/*** END file-production ***/
134+
135+/*** BEGIN value-header ***/
136+GType
137+@enum_name@_get_type (void) {
138+ static GType enum_type_id = 0;
139+ if (G_UNLIKELY (!enum_type_id))
140+ {
141+ static const G@Type@Value values[] = {
142+/*** END value-header ***/
143+
144+/*** BEGIN value-production ***/
145+ { @VALUENAME@, "@VALUENAME@", "@valuenick@" },
146+/*** END value-production ***/
147+
148+/*** BEGIN value-tail ***/
149+ { 0, NULL, NULL }
150+ };
151+ enum_type_id = g_@type@_register_static (g_intern_static_string ("@EnumName@"), values);
152+ }
153+ return enum_type_id;
154+}
155+/*** END value-tail ***/
156
157=== added file 'libindicator/indicator-object-enum-types.h.template'
158--- libindicator/indicator-object-enum-types.h.template 1970-01-01 00:00:00 +0000
159+++ libindicator/indicator-object-enum-types.h.template 2010-03-18 16:33:19 +0000
160@@ -0,0 +1,27 @@
161+/*** BEGIN file-header ***/
162+
163+#ifndef __INDICATOR_OBJECT_ENUM_TYPES_H__
164+#define __INDICATOR_OBJECT_ENUM_TYPES_H__
165+
166+#include <glib-object.h>
167+
168+G_BEGIN_DECLS
169+
170+/*** END file-header ***/
171+
172+/*** BEGIN file-production ***/
173+/* enumerations from "@filename@" */
174+/*** END file-production ***/
175+
176+/*** BEGIN file-tail ***/
177+G_END_DECLS
178+
179+#endif /* !__INDICATOR_OBJECT_ENUM_TYPES_H__ */
180+/*** END file-tail ***/
181+
182+/*** BEGIN value-header ***/
183+
184+GType @enum_name@_get_type (void) G_GNUC_CONST;
185+#define INDICATOR_OBJECT_TYPE_@ENUMSHORT@ (@enum_name@_get_type())
186+
187+/*** END value-header ***/
188
189=== modified file 'libindicator/indicator-object-marshal.list'
190--- libindicator/indicator-object-marshal.list 2010-01-15 21:16:30 +0000
191+++ libindicator/indicator-object-marshal.list 2010-03-18 16:33:19 +0000
192@@ -1,1 +1,2 @@
193 VOID: POINTER, UINT, UINT
194+VOID: UINT,ENUM
195
196=== modified file 'libindicator/indicator-object.c'
197--- libindicator/indicator-object.c 2010-01-15 22:08:35 +0000
198+++ libindicator/indicator-object.c 2010-03-18 16:33:19 +0000
199@@ -28,6 +28,7 @@
200 #include "indicator.h"
201 #include "indicator-object.h"
202 #include "indicator-object-marshal.h"
203+#include "indicator-object-enum-types.h"
204
205 /**
206 IndicatorObjectPrivate:
207@@ -56,6 +57,7 @@
208 ENTRY_ADDED,
209 ENTRY_REMOVED,
210 ENTRY_MOVED,
211+ SCROLL,
212 LAST_SIGNAL
213 };
214
215@@ -142,6 +144,25 @@
216 _indicator_object_marshal_VOID__POINTER_UINT_UINT,
217 G_TYPE_NONE, 3, G_TYPE_POINTER, G_TYPE_UINT, G_TYPE_UINT, G_TYPE_NONE);
218
219+
220+ /**
221+ IndicatorObject::scroll:
222+ @arg0: The #IndicatorObject object
223+ @arg1: The delta of the scroll event
224+ @arg2: The orientation of the scroll event.
225+
226+ When the indicator receives a mouse scroll wheel event
227+ from the user, this signal is emitted.
228+ */
229+ signals[SCROLL] = g_signal_new (INDICATOR_OBJECT_SIGNAL_SCROLL,
230+ G_TYPE_FROM_CLASS(klass),
231+ G_SIGNAL_RUN_LAST,
232+ G_STRUCT_OFFSET (IndicatorObjectClass, scroll),
233+ NULL, NULL,
234+ _indicator_object_marshal_VOID__UINT_ENUM,
235+ G_TYPE_NONE, 2, G_TYPE_UINT, INDICATOR_OBJECT_TYPE_SCROLL_DIRECTION);
236+
237+
238 return;
239 }
240
241@@ -188,7 +209,7 @@
242 indicator_object_finalize (GObject *object)
243 {
244 IndicatorObjectPrivate * priv = INDICATOR_OBJECT_GET_PRIVATE(object);
245-
246+
247 if (priv->module != NULL) {
248 /* Wow, this is convoluted. So basically we want to unref
249 the module which will cause the code it included to be
250@@ -211,7 +232,7 @@
251
252 This function builds an #IndicatorObject using the symbols
253 that are found in @file. The module is loaded and the
254- references are all kept by the object. To unload the
255+ references are all kept by the object. To unload the
256 module the object must be destroyed.
257
258 Return value: A valid #IndicatorObject or #NULL if error.
259@@ -304,7 +325,7 @@
260 /* The default get entries function uses the other single
261 entries in the class to create an entry structure and
262 put it into a list. This makes it simple for simple objects
263- to create the list. Small changes from the way they
264+ to create the list. Small changes from the way they
265 previously were. */
266 static GList *
267 get_entries_default (IndicatorObject * io)
268
269=== modified file 'libindicator/indicator-object.h'
270--- libindicator/indicator-object.h 2010-01-15 21:04:20 +0000
271+++ libindicator/indicator-object.h 2010-03-18 16:33:19 +0000
272@@ -24,11 +24,18 @@
273 #ifndef __INDICATOR_OBJECT_H__
274 #define __INDICATOR_OBJECT_H__
275
276-#include <glib.h>
277-#include <glib-object.h>
278+#include <gtk/gtk.h>
279
280 G_BEGIN_DECLS
281
282+typedef enum
283+{
284+ INDICATOR_OBJECT_SCROLL_UP,
285+ INDICATOR_OBJECT_SCROLL_DOWN,
286+ INDICATOR_OBJECT_SCROLL_LEFT,
287+ INDICATOR_OBJECT_SCROLL_RIGHT
288+} IndicatorScrollDirection;
289+
290 #define INDICATOR_OBJECT_TYPE (indicator_object_get_type ())
291 #define INDICATOR_OBJECT(obj) (G_TYPE_CHECK_INSTANCE_CAST ((obj), INDICATOR_OBJECT_TYPE, IndicatorObject))
292 #define INDICATOR_OBJECT_CLASS(klass) (G_TYPE_CHECK_CLASS_CAST ((klass), INDICATOR_OBJECT_TYPE, IndicatorObjectClass))
293@@ -42,6 +49,8 @@
294 #define INDICATOR_OBJECT_SIGNAL_ENTRY_REMOVED_ID (g_signal_lookup(INDICATOR_OBJECT_SIGNAL_ENTRY_REMOVED, INDICATOR_OBJECT_TYPE))
295 #define INDICATOR_OBJECT_SIGNAL_ENTRY_MOVED "entry-moved"
296 #define INDICATOR_OBJECT_SIGNAL_ENTRY_MOVED_ID (g_signal_lookup(INDICATOR_OBJECT_SIGNAL_ENTRY_MOVED, INDICATOR_OBJECT_TYPE))
297+#define INDICATOR_OBJECT_SIGNAL_SCROLL "scroll"
298+#define INDICATOR_OBJECT_SIGNAL_SCROLL_ID (g_signal_lookup(INDICATOR_OBJECT_SIGNAL_SCROLL, INDICATOR_OBJECT_TYPE))
299
300 typedef struct _IndicatorObject IndicatorObject;
301 typedef struct _IndicatorObjectClass IndicatorObjectClass;
302@@ -75,7 +84,7 @@
303 */
304 struct _IndicatorObjectClass {
305 GObjectClass parent_class;
306-
307+
308 /* Virtual Functions */
309 GtkLabel * (*get_label) (IndicatorObject * io);
310 GtkImage * (*get_image) (IndicatorObject * io);
311@@ -85,13 +94,13 @@
312 guint (*get_location) (IndicatorObject * io, IndicatorObjectEntry * entry);
313
314 /* Signals */
315- void (*entry_added) (IndicatorObject * io, IndicatorObjectEntry * entry, gpointer user_data);
316- void (*entry_removed) (IndicatorObject * io, IndicatorObjectEntry * entry, gpointer user_data);
317- void (*entry_moved) (IndicatorObject * io, IndicatorObjectEntry * entry, guint old_pos, guint new_pos, gpointer user_data);
318+ void (*entry_added) (IndicatorObject * io, IndicatorObjectEntry * entry, gpointer user_data);
319+ void (*entry_removed) (IndicatorObject * io, IndicatorObjectEntry * entry, gpointer user_data);
320+ void (*entry_moved) (IndicatorObject * io, IndicatorObjectEntry * entry, guint old_pos, guint new_pos, gpointer user_data);
321+ void (*scroll) (IndicatorObject * io, gint delta, IndicatorScrollDirection direction);
322
323 /* Reserved */
324 void (* indicator_object_reserved_1) (void);
325- void (* indicator_object_reserved_2) (void);
326 };
327
328 /**

Subscribers

People subscribed via source and target branches

to all changes: