Merge lp:~indicator-applet-developers/indicator-appmenu/catch-xerrors-correctly into lp:indicator-appmenu/0.3

Proposed by Neil J. Patel
Status: Merged
Approved by: David Barth
Approved revision: 68
Merged at revision: 68
Proposed branch: lp:~indicator-applet-developers/indicator-appmenu/catch-xerrors-correctly
Merge into: lp:indicator-appmenu/0.3
Diff against target: 29 lines (+4/-0)
2 files modified
src/gdk-get-func.c (+3/-0)
src/indicator-appmenu.c (+1/-0)
To merge this branch: bzr merge lp:~indicator-applet-developers/indicator-appmenu/catch-xerrors-correctly
Reviewer Review Type Date Requested Status
David Barth Approve
Review via email: mp+36062@code.launchpad.net

Description of the change

This catches xerrors properly

To post a comment you must log in.
Revision history for this message
David Barth (dbarth) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/gdk-get-func.c'
2--- src/gdk-get-func.c 2010-09-16 12:39:02 +0000
3+++ src/gdk-get-func.c 2010-09-20 19:37:48 +0000
4@@ -94,10 +94,13 @@
5
6 hints_atom = gdk_x11_get_xatom_by_name_for_display (display, _XA_MOTIF_WM_HINTS);
7
8+ gdk_error_trap_push ();
9 XGetWindowProperty (GDK_DISPLAY_XDISPLAY (display), window,
10 hints_atom, 0, sizeof (MotifWmHints)/sizeof (long),
11 False, AnyPropertyType, &type, &format, &nitems,
12 &bytes_after, &data);
13+ gdk_flush ();
14+ gdk_error_trap_pop ();
15
16 if (type == None)
17 return NULL;
18
19=== modified file 'src/indicator-appmenu.c'
20--- src/indicator-appmenu.c 2010-09-16 18:51:04 +0000
21+++ src/indicator-appmenu.c 2010-09-20 19:37:48 +0000
22@@ -428,6 +428,7 @@
23 False,
24 SubstructureRedirectMask | SubstructureNotifyMask,
25 &xev);
26+ gdk_flush ();
27 gdk_error_trap_pop ();
28
29 return;

Subscribers

People subscribed via source and target branches