Merge lp:~indicator-applet-developers/indicator-applet/ubuntu into lp:~ubuntu-desktop/indicator-applet/ubuntu

Proposed by Ted Gould
Status: Merged
Merged at revision: 268
Proposed branch: lp:~indicator-applet-developers/indicator-applet/ubuntu
Merge into: lp:~ubuntu-desktop/indicator-applet/ubuntu
Diff against target: 175 lines (+81/-3)
4 files modified
configure (+1/-1)
configure.ac (+1/-1)
debian/changelog (+38/-0)
src/applet-main.c (+41/-1)
To merge this branch: bzr merge lp:~indicator-applet-developers/indicator-applet/ubuntu
Reviewer Review Type Date Requested Status
Ken VanDine Pending
Review via email: mp+26823@code.launchpad.net

Description of the change

0.4.2

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure'
2--- configure 2010-05-27 20:08:59 +0000
3+++ configure 2010-06-04 16:44:23 +0000
4@@ -2844,7 +2844,7 @@
5
6 # Define the identity of the package.
7 PACKAGE=indicator-applet
8- VERSION=0.4.1
9+ VERSION=0.4.2
10
11
12 cat >>confdefs.h <<_ACEOF
13
14=== modified file 'configure.ac'
15--- configure.ac 2010-05-27 20:08:59 +0000
16+++ configure.ac 2010-06-04 16:44:23 +0000
17@@ -4,7 +4,7 @@
18 AC_PREREQ(2.53)
19
20 AM_CONFIG_HEADER(config.h)
21-AM_INIT_AUTOMAKE(indicator-applet, 0.4.1)
22+AM_INIT_AUTOMAKE(indicator-applet, 0.4.2)
23
24 AM_MAINTAINER_MODE
25 m4_ifdef([AM_SILENT_RULES],[AM_SILENT_RULES])
26
27=== modified file 'debian/changelog'
28--- debian/changelog 2010-05-27 20:53:21 +0000
29+++ debian/changelog 2010-06-04 16:44:23 +0000
30@@ -1,3 +1,10 @@
31+indicator-applet (0.4.2-0ubuntu1~ppa1) lucid; urgency=low
32+
33+ * New upstream release.
34+ * Support hiding of entries if their label and/or image hides
35+
36+ -- Ted Gould <ted@ubuntu.com> Fri, 04 Jun 2010 11:21:55 -0500
37+
38 indicator-applet (0.4.1-0ubuntu1) maverick; urgency=low
39
40 * New upstream release.
41@@ -12,6 +19,22 @@
42
43 -- Ted Gould <ted@ubuntu.com> Thu, 27 May 2010 15:09:57 -0500
44
45+indicator-applet (0.4.1-0ubuntu1~ppa1) lucid; urgency=low
46+
47+ * New upstream release.
48+ * Fix build of Bonobo server files
49+
50+ -- Ted Gould <ted@ubuntu.com> Thu, 27 May 2010 15:09:57 -0500
51+
52+indicator-applet (0.4.0-0ubuntu1~ppa1) lucid; urgency=low
53+
54+ * New upstream release.
55+ * Creating a new binary target indicator-applet-appmenu
56+ * debian/control, debian/indicator-applet-appmenu.install: Adding
57+ a new binary package for indicator-applet-appmenu
58+
59+ -- Ted Gould <ted@ubuntu.com> Thu, 27 May 2010 12:32:26 -0500
60+
61 indicator-applet (0.3.7-0ubuntu1) lucid-proposed; urgency=low
62
63 * New upstream release.
64@@ -21,12 +44,27 @@
65
66 -- Ted Gould <ted@ubuntu.com> Tue, 04 May 2010 19:44:02 +0200
67
68+indicator-applet (0.3.6-0ubuntu3~ppa1) lucid; urgency=low
69+
70+ * Upstream Merge
71+ * Compiler cleanups
72+ * Support for vertical panels
73+
74+ -- Ted Gould <ted@ubuntu.com> Tue, 27 Apr 2010 11:57:38 -0500
75+
76 indicator-applet (0.3.6-0ubuntu2) lucid; urgency=low
77
78 * Backport change to fix keyboard grabbing issues (lp: #553918)
79
80 -- Sebastien Bacher <seb128@ubuntu.com> Fri, 02 Apr 2010 19:35:18 +0200
81
82+indicator-applet (0.3.6-0ubuntu2~ppa1) lucid; urgency=low
83+
84+ * Upstream Merge
85+ * Fix active flags for keybinding. (LP: #553918)
86+
87+ -- Ted Gould <ted@ubuntu.com> Fri, 02 Apr 2010 12:36:55 -0500
88+
89 indicator-applet (0.3.6-0ubuntu1) lucid; urgency=low
90
91 * New upstream release.
92
93=== modified file 'src/applet-main.c'
94--- src/applet-main.c 2010-05-27 17:30:14 +0000
95+++ src/applet-main.c 2010-06-04 16:44:23 +0000
96@@ -192,9 +192,24 @@
97 }
98
99 static void
100+something_shown (GtkWidget * widget, gpointer user_data)
101+{
102+ GtkWidget * menuitem = GTK_WIDGET(user_data);
103+ gtk_widget_show(menuitem);
104+}
105+
106+static void
107+something_hidden (GtkWidget * widget, gpointer user_data)
108+{
109+ GtkWidget * menuitem = GTK_WIDGET(user_data);
110+ gtk_widget_hide(menuitem);
111+}
112+
113+static void
114 entry_added (IndicatorObject * io, IndicatorObjectEntry * entry, GtkWidget * menubar)
115 {
116 g_debug("Signal: Entry Added");
117+ gboolean something_visible = FALSE;
118
119 GtkWidget * menuitem = gtk_menu_item_new();
120 GtkWidget * box = (packdirection == GTK_PACK_DIRECTION_LTR) ?
121@@ -205,6 +220,12 @@
122
123 if (entry->image != NULL) {
124 gtk_box_pack_start(GTK_BOX(box), GTK_WIDGET(entry->image), FALSE, FALSE, 0);
125+ if (gtk_widget_get_visible(GTK_WIDGET(entry->image))) {
126+ something_visible = TRUE;
127+ }
128+
129+ g_signal_connect(G_OBJECT(entry->image), "show", G_CALLBACK(something_shown), menuitem);
130+ g_signal_connect(G_OBJECT(entry->image), "hide", G_CALLBACK(something_hidden), menuitem);
131 }
132 if (entry->label != NULL) {
133 switch(packdirection) {
134@@ -220,6 +241,12 @@
135 break;
136 }
137 gtk_box_pack_start(GTK_BOX(box), GTK_WIDGET(entry->label), FALSE, FALSE, 0);
138+ if (gtk_widget_get_visible(GTK_WIDGET(entry->label))) {
139+ something_visible = TRUE;
140+ }
141+
142+ g_signal_connect(G_OBJECT(entry->label), "show", G_CALLBACK(something_shown), menuitem);
143+ g_signal_connect(G_OBJECT(entry->label), "hide", G_CALLBACK(something_hidden), menuitem);
144 }
145 gtk_container_add(GTK_CONTAINER(menuitem), box);
146 gtk_widget_show(box);
147@@ -237,7 +264,10 @@
148 gtk_container_foreach(GTK_CONTAINER(menubar), place_in_menu, &position);
149
150 gtk_menu_shell_insert(GTK_MENU_SHELL(menubar), menuitem, position.menupos);
151- gtk_widget_show(menuitem);
152+
153+ if (something_visible) {
154+ gtk_widget_show(menuitem);
155+ }
156
157 g_object_set_data(G_OBJECT(menuitem), MENU_DATA_INDICATOR_ENTRY, entry);
158 g_object_set_data(G_OBJECT(menuitem), MENU_DATA_INDICATOR_OBJECT, io);
159@@ -254,6 +284,16 @@
160 return;
161 }
162
163+ IndicatorObjectEntry * entry = (IndicatorObjectEntry *)data;
164+ if (entry->label != NULL) {
165+ g_signal_handlers_disconnect_by_func(G_OBJECT(entry->label), G_CALLBACK(something_shown), widget);
166+ g_signal_handlers_disconnect_by_func(G_OBJECT(entry->label), G_CALLBACK(something_hidden), widget);
167+ }
168+ if (entry->image != NULL) {
169+ g_signal_handlers_disconnect_by_func(G_OBJECT(entry->image), G_CALLBACK(something_shown), widget);
170+ g_signal_handlers_disconnect_by_func(G_OBJECT(entry->image), G_CALLBACK(something_hidden), widget);
171+ }
172+
173 gtk_widget_destroy(widget);
174 return;
175 }

Subscribers

People subscribed via source and target branches