Unity HUD

Merge lp:~indicator-applet-developers/hud/g_action_map_lookup_action into lp:hud/13.10

  1. g_action_map_lookup_action
  2. Merge into trunk.13.10
Proposed by Antti Kaijanmäki
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 314
Merged at revision: 314
Proposed branch: lp:~indicator-applet-developers/hud/g_action_map_lookup_action
Merge into: lp:hud/13.10
Diff against target: 12 lines (+1/-1)
1 file modified
tests/test-application-source.c (+1/-1)
To merge this branch: bzr merge lp:~indicator-applet-developers/hud/g_action_map_lookup_action
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Lars Karlitski (community) Approve
Review via email: mp+181508@code.launchpad.net

Commit message

g_simple_action_group_lookup() was deprecated. use g_action_map_lookup_action() instead.

Description of the change

g_simple_action_group_lookup() was deprecated. use g_action_map_lookup_action() instead.

To post a comment you must log in.
Revision history for this message
Lars Karlitski (larsu) wrote :

Looks correct, thanks.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:314
http://jenkins.qa.ubuntu.com/job/hud-ci/114/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-saucy-amd64-ci/75
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-saucy-armhf-ci/6
    FAILURE: http://jenkins.qa.ubuntu.com/job/hud-saucy-i386-ci/75/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/hud-ci/114/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

some random glitch with i386. rebuilding.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/hud-autolanding/71/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-saucy-amd64-autolanding/54
    FAILURE: http://jenkins.qa.ubuntu.com/job/hud-saucy-armhf-autolanding/7/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-saucy-i386-autolanding/54

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/test-application-source.c'
2--- tests/test-application-source.c 2013-08-22 02:07:03 +0000
3+++ tests/test-application-source.c 2013-08-22 09:44:36 +0000
4@@ -130,7 +130,7 @@
5 g_action_map_add_action(G_ACTION_MAP(simple_group), G_ACTION(g_simple_action_new("action-name", NULL)));
6 GActionGroup * group = G_ACTION_GROUP(simple_group);
7 g_assert(group);
8- g_assert(g_simple_action_group_lookup(simple_group, "action-name"));
9+ g_assert(g_action_map_lookup_action(G_ACTION_MAP(simple_group), "action-name"));
10
11 GMenu * menu_none = g_menu_new();
12 g_menu_append(menu_none, "Elephant", "action-name");

Subscribers

People subscribed via source and target branches

to all changes: