Code review comment for lp:~indicator-applet-developers/evolution-indicator/fix-preferences

Revision history for this message
Neil J. Patel (njpatel) wrote :

This branch handles the changes to evolution-indicator to make it fit into the preferences mockup on

It handles:

1. Moving the "When new mail arrives in blah" group to the top of the General page, and
2. Giving evolution-indicator an idea about how many accounts the user has configured, so it can amend the text in the '...Arrives In Inbox' text to '...Arrives In Any Inbox' if there is more than one account.

The work to make evolution-indicator show separate mailboxes in the messaging-menu will build on the code here (update_accounts will do much more, as will the accounts_changed callback).

The remaining work to the preferences window is out-of-scope for evolution-indicator, and rather needs to be a patch to evolution itself.

« Back to merge proposal