Merge lp:~indicator-applet-developers/evolution-indicator/fix-message-count into lp:evolution-indicator

Proposed by Neil J. Patel
Status: Merged
Merged at revision: not available
Proposed branch: lp:~indicator-applet-developers/evolution-indicator/fix-message-count
Merge into: lp:evolution-indicator
Diff against target: None lines
To merge this branch: bzr merge lp:~indicator-applet-developers/evolution-indicator/fix-message-count
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+11860@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Neil J. Patel (njpatel) wrote :

Just resets the message_count when evolution is shown or the user requests it to be shown, so the message count shown by the notification doesn't keep incrementing during a session.

Revision history for this message
Ted Gould (ted) wrote :

On Wed, 2009-09-16 at 10:10 +0000, Neil J. Patel wrote:
> Just resets the message_count when evolution is shown or the
> user requests it to be shown, so the message count shown by
> the notification doesn't keep incrementing during a session.

Oh, a two line change! Did you run valgrind to ensure that setting
these int's isn't an issue? ;) j/k

Looks good.

  review approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/evolution-indicator.c'
2--- src/evolution-indicator.c 2009-09-10 16:44:38 +0000
3+++ src/evolution-indicator.c 2009-09-16 09:52:29 +0000
4@@ -347,6 +347,7 @@
5 indicate_indicator_get_property (indicator, "name"));
6
7 }
8+ message_count = 0;
9
10 g_static_mutex_unlock (&mlock);
11 }
12@@ -974,6 +975,7 @@
13 indicate_indicator_get_property (indicator, "name"));
14
15 }
16+ message_count = 0;
17 }
18 else
19 {

Subscribers

People subscribed via source and target branches