Merge lp:~inddiana/sisb/aguadarrama_sisb_fix_sisb_purchase_manager into lp:sisb

Proposed by Angel A. Guadarrama B.
Status: Merged
Approved by: Aristóbulo Meneses
Approved revision: 208
Merged at revision: 206
Proposed branch: lp:~inddiana/sisb/aguadarrama_sisb_fix_sisb_purchase_manager
Merge into: lp:sisb
Diff against target: 22 lines (+12/-1)
1 file modified
sisb_purchase_management/model/purchase_management.py (+12/-1)
To merge this branch: bzr merge lp:~inddiana/sisb/aguadarrama_sisb_fix_sisb_purchase_manager
Reviewer Review Type Date Requested Status
Aristóbulo Meneses Pending
Review via email: mp+104724@code.launchpad.net

This proposal supersedes a proposal from 2012-05-03.

Description of the change

[FIX] Eliminados parametros innecesarios.

To post a comment you must log in.
Revision history for this message
Aristóbulo Meneses (aristobulo) wrote : Posted in a previous version of this proposal

if purc_o_l2.price_unit <= 0 or purc_o_l2.price_unit <= 0 ???

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sisb_purchase_management/model/purchase_management.py'
2--- sisb_purchase_management/model/purchase_management.py 2012-04-30 18:15:54 +0000
3+++ sisb_purchase_management/model/purchase_management.py 2012-05-04 12:26:19 +0000
4@@ -374,7 +374,18 @@
5 })
6
7 def wkf_confirm_order(self, cr, uid, ids, context=None):
8- po_obj = self.browse(cr, uid, ids, context=context)
9+ po_obj = self.browse(cr, uid, ids, context=context)
10+
11+ for po in po_obj:
12+ if po.amount_total <= 0:
13+ raise osv.except_osv(_('Error !'),_('El total presupuestado no puede ser menor o igual a cero.'))
14+
15+ id_purc_o_l2 = self.pool.get('purchase.order.line').search(cr, uid, [('order_id', '=', po_obj[0].id)])
16+ for po2 in id_purc_o_l2:
17+ purc_o_l2 = self.pool.get('purchase.order.line').browse(cr, uid, po2) #Cantidad que se aprueba purchase.order.line
18+ if purc_o_l2.price_unit <= 0:
19+ raise osv.except_osv(_('Error !'),_('Los precios unitarios o subtotales en la ordenes de compras no pueden ser menor o igual a cero.'))
20+
21 if po_obj[0].requisition_id.id and not (po_obj[0].requisition_id.state == 'approved' or po_obj[0].requisition_id.state == 'done') :
22 raise osv.except_osv(_('Error !'),_('Debe aprobar la solicitud de compra previamente.'))
23

Subscribers

People subscribed via source and target branches