Merge lp:~imbrandon/ubuntu-accomplishments-system/viewer into lp:ubuntu-accomplishments-system/viewer

Proposed by Brandon Holtsclaw
Status: Needs review
Proposed branch: lp:~imbrandon/ubuntu-accomplishments-system/viewer
Merge into: lp:ubuntu-accomplishments-system/viewer
Diff against target: 414 lines (+93/-96)
1 file modified
data/css/information.txt (+93/-96)
To merge this branch: bzr merge lp:~imbrandon/ubuntu-accomplishments-system/viewer
Reviewer Review Type Date Requested Status
Jason Robinson (community) Needs Information
Jono Bacon Pending
Review via email: mp+119844@code.launchpad.net

Description of the change

Correct color for the links at the top of the trophy case ...

To post a comment you must log in.
Revision history for this message
Jason Robinson (jaywink) wrote :

Is there a reason to remove "-moz-border-radius" and "-webkit-border-radius" - afaik don't they offer more support for older browsers?

Also this caught my eye, is it a fix or some error caused by character encoding etc?

125 - content: '\00020';
126 + content: '�0020';

Thanks for info!

review: Needs Information
Revision history for this message
Jason Robinson (jaywink) wrote :

> Is there a reason to remove "-moz-border-radius" and "-webkit-border-radius" -
> afaik don't they offer more support for older browsers?

Just realized this is for the viewer app - so forget about these :)

Unmerged revisions

116. By Brandon Holtsclaw

fix for the links the wrong color and adding the minor fixes from the web code so the markup matches [trivial]

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/css/information.txt'
2--- data/css/information.txt 2012-04-09 00:21:55 +0000
3+++ data/css/information.txt 2012-08-16 06:59:18 +0000
4@@ -1,85 +1,76 @@
5 a {
6- color: #dd4814;
7- text-decoration: none;
8- font-weight: 700;
9+ color: #dd4814;
10+ text-decoration: none;
11+ font-weight: 700;
12 }
13
14+
15 #accomplishment {
16- -moz-border-radius: 4px;
17- -webkit-border-radius: 4px;
18+ border-radius: 4px;
19 background: #fff;
20 border: 1px solid #eee;
21- border-radius: 4px;
22- padding: 0
23+ padding: 0;
24 }
25
26 #accomplishment .block {
27- margin-top: 10px
28+ margin-top: 10px;
29 }
30
31 #accomplishment-badge {
32- -moz-border-radius: 4px;
33- -webkit-border-radius: 4px;
34+ border-radius: 4px;
35 background: #DD4814;
36 border: 0;
37- border-radius: 4px;
38 color: #fff;
39 font-size: 100%;
40 margin: 0;
41 padding: 0;
42- text-align: left
43+ text-align: left;
44 }
45
46 #accomplishment-badge .icon {
47- -moz-border-radius: 4px;
48- -webkit-border-radius: 4px;
49+ border-radius: 4px;
50 background-color: #fff;
51- border-radius: 4px;
52 float: left;
53 height: 100px;
54 margin: 10px;
55- padding: 10px
56+ padding: 10px;
57 }
58
59 #accomplishment-badge p {
60- font-size: 80%
61+ font-size: 80%;
62 }
63
64 #accomplishment-badge ul {
65- margin-left: -40px
66+ margin-left: -40px;
67 }
68
69 #accomplishment-more {
70- -moz-border-radius: 4px;
71- -webkit-border-radius: 4px;
72- background: #fff;
73- border: 1px solid #eee;
74 border-radius: 4px;
75- padding: 0
76+ background: #fff;
77+ border: 1px solid #eee;
78+ padding: 0;
79 }
80
81 #accomplishment-more {
82- background: #fff url("../media/circle.png") no-repeat -20px -30px;
83+ background: #fff url("../media/circle.png") no-repeat -20px -30px;
84 }
85
86 #divider {
87- border-right: 1px dotted #333
88+ border-right: 1px dotted #333;
89 }
90
91 #tipspitfalls {
92- -moz-border-radius: 4px;
93- -webkit-border-radius: 4px;
94+ border-radius: 4px;
95 background-color: #eee;
96 border: 0;
97- border-radius: 4px;
98 font-style: italic;
99 margin: 0 auto;
100 overflow: hidden;
101- padding: 0
102+ padding: 0;
103 }
104
105 .alpha {
106- margin-left: 0
107+ margin-left: 0;
108 }
109
110 .clear {
111@@ -88,170 +79,170 @@
112 height: 0;
113 overflow: hidden;
114 visibility: hidden;
115- width: 0
116+ width: 0;
117 }
118
119 .clearfix:after {
120- clear: both
121+ clear: both;
122 }
123
124 .clearfix:before,.clearfix:after {
125- content: '\00020';
126+ content: '�0020';
127 display: block;
128 height: 0;
129 overflow: hidden;
130 visibility: hidden;
131- width: 0
132+ width: 0;
133 }
134
135 .container_8 {
136 margin-left: auto;
137 margin-right: auto;
138- width: 696px
139+ width: 696px;
140 }
141
142 .container_8 .grid_1 {
143- width: 67px
144+ width: 67px;
145 }
146
147 .container_8 .grid_2 {
148- width: 154px
149+ width: 154px;
150 }
151
152 .container_8 .grid_3 {
153- width: 241px
154+ width: 241px;
155 }
156
157 .container_8 .grid_4 {
158- width: 328px
159+ width: 328px;
160 }
161
162 .container_8 .grid_5 {
163- width: 415px
164+ width: 415px;
165 }
166
167 .container_8 .grid_6 {
168- width: 502px
169+ width: 502px;
170 }
171
172 .container_8 .grid_7 {
173- width: 589px
174+ width: 589px;
175 }
176
177 .container_8 .grid_8 {
178- width: 676px
179+ width: 676px;
180 }
181
182 .container_8 .prefix_1 {
183- padding-left: 87px
184+ padding-left: 87px;
185 }
186
187 .container_8 .prefix_2 {
188- padding-left: 174px
189+ padding-left: 174px;
190 }
191
192 .container_8 .prefix_3 {
193- padding-left: 261px
194+ padding-left: 261px;
195 }
196
197 .container_8 .prefix_4 {
198- padding-left: 348px
199+ padding-left: 348px;
200 }
201
202 .container_8 .prefix_5 {
203- padding-left: 435px
204+ padding-left: 435px;
205 }
206
207 .container_8 .prefix_6 {
208- padding-left: 522px
209+ padding-left: 522px;
210 }
211
212 .container_8 .prefix_7 {
213- padding-left: 609px
214+ padding-left: 609px;
215 }
216
217 .container_8 .pull_1 {
218- left: -87px
219+ left: -87px;
220 }
221
222 .container_8 .pull_2 {
223- left: -174px
224+ left: -174px;
225 }
226
227 .container_8 .pull_3 {
228- left: -261px
229+ left: -261px;
230 }
231
232 .container_8 .pull_4 {
233- left: -348px
234+ left: -348px;
235 }
236
237 .container_8 .pull_5 {
238- left: -435px
239+ left: -435px;
240 }
241
242 .container_8 .pull_6 {
243- left: -522px
244+ left: -522px;
245 }
246
247 .container_8 .pull_7 {
248- left: -609px
249+ left: -609px;
250 }
251
252 .container_8 .push_1 {
253- left: 87px
254+ left: 87px;
255 }
256
257 .container_8 .push_2 {
258- left: 174px
259+ left: 174px;
260 }
261
262 .container_8 .push_3 {
263- left: 261px
264+ left: 261px;
265 }
266
267 .container_8 .push_4 {
268- left: 348px
269+ left: 348px;
270 }
271
272 .container_8 .push_5 {
273- left: 435px
274+ left: 435px;
275 }
276
277 .container_8 .push_6 {
278- left: 522px
279+ left: 522px;
280 }
281
282 .container_8 .push_7 {
283- left: 609px
284+ left: 609px;
285 }
286
287 .container_8 .suffix_1 {
288- padding-right: 87px
289+ padding-right: 87px;
290 }
291
292 .container_8 .suffix_2 {
293- padding-right: 174px
294+ padding-right: 174px;
295 }
296
297 .container_8 .suffix_3 {
298- padding-right: 261px
299+ padding-right: 261px;
300 }
301
302 .container_8 .suffix_4 {
303- padding-right: 348px
304+ padding-right: 348px;
305 }
306
307 .container_8 .suffix_5 {
308- padding-right: 435px
309+ padding-right: 435px;
310 }
311
312 .container_8 .suffix_6 {
313- padding-right: 522px
314+ padding-right: 522px;
315 }
316
317 .container_8 .suffix_7 {
318- padding-right: 609px
319+ padding-right: 609px;
320 }
321
322 .grid_1,.grid_2,.grid_3,.grid_4,.grid_5,.grid_6,.grid_7,.grid_8 {
323@@ -259,32 +250,31 @@
324 float: left;
325 margin-left: 10px;
326 margin-right: 10px;
327- position: relative
328+ position: relative;
329 }
330
331 .left {
332 float: left;
333 margin-bottom: -1000px;
334- padding-bottom: 1000px
335+ padding-bottom: 1000px;
336 }
337
338 .omega {
339- margin-right: 0
340+ margin-right: 0;
341 }
342
343-.push_1,.pull_1,.push_2,.pull_2,.push_3,.pull_3,.push_4,.pull_4,.push_5,.pull_5,.push_6,.pull_6,.push_7,.pull_7,.push_8,.pull_8
344- {
345- position: relative
346+.push_1,.pull_1,.push_2,.pull_2,.push_3,.pull_3,.push_4,.pull_4,.push_5,.pull_5,.push_6,.pull_6,.push_7,.pull_7,.push_8,.pull_8 {
347+ position: relative;
348 }
349
350 body {
351 color: #333;
352 font-family: Ubuntu, Times, serif;
353- min-width: 696px
354+ min-width: 696px;
355 }
356
357 h2 {
358- text-decoration: underline dotted
359+ text-decoration: underline dotted;
360 }
361
362 ol {
363@@ -293,27 +283,34 @@
364 }
365
366 li {
367- padding-bottom: 5px;
368+ padding-bottom: 5px;
369 }
370+
371 ul {
372 font-size: 80%;
373- font-style: italic
374+ font-style: italic;
375 }
376
377 ul.none {
378- list-style-type: none
379-}
380-
381-div#howto ol{
382- padding-top: 20px;
383-}
384-
385-div#howto i{
386- color: #fff;
387- float: left;
388- font-size: 3em;
389-}
390-
391-div#howto h2{
392- margin-left: 100px;
393+ list-style-type: none;
394+}
395+
396+div#howto ol {
397+ padding-top: 20px;
398+}
399+
400+div#howto i {
401+ color: #fff;
402+ float: left;
403+ font-size: 3em;
404+}
405+
406+div#howto h2 {
407+ margin-left: 100px;
408+}
409+
410+#accomplishment a,#accomplishment a:hover,#accomplishment a:visited,#accomplishment a:active {
411+ color: #fff;
412+ text-decoration: none;
413+ font-weight: 700;
414 }

Subscribers

People subscribed via source and target branches

to all changes: