Merge lp:~ilidrissi.amine/update-manager/update-manager.fix-288912 into lp:update-manager

Proposed by Mohamed Amine Ilidrissi
Status: Merged
Merged at revision: 1895
Proposed branch: lp:~ilidrissi.amine/update-manager/update-manager.fix-288912
Merge into: lp:update-manager
Diff against target: 39 lines (+14/-0)
2 files modified
DistUpgrade/DistUpgradeView.py (+6/-0)
debian/changelog (+8/-0)
To merge this branch: bzr merge lp:~ilidrissi.amine/update-manager/update-manager.fix-288912
Reviewer Review Type Date Requested Status
Michael Vogt Pending
Review via email: mp+32367@code.launchpad.net

Description of the change

This fixes bug 288912.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'DistUpgrade/DistUpgradeView.py'
2--- DistUpgrade/DistUpgradeView.py 2010-07-12 14:19:33 +0000
3+++ DistUpgrade/DistUpgradeView.py 2010-08-11 19:03:44 +0000
4@@ -66,6 +66,9 @@
5
6 # now assemble the string
7 if days > 0:
8+ # Don't print str_hours if it's an empty string, see LP: #288912
9+ if map["str_hours"] == '':
10+ return map["str_days"]
11 # TRANSLATORS: you can alter the ordering of the remaining time
12 # information here if you shuffle %(str_days)s %(str_hours)s %(str_minutes)s
13 # around. Make sure to keep all '$(str_*)s' in the translated string
14@@ -81,6 +84,9 @@
15 return map["str_hours"]
16 # when we are near the end, become more precise again
17 elif hours > 0:
18+ # Don't print str_minutes if it's an empty string, see LP: #288912
19+ if map["str_minutes"] == '':
20+ return map["str_hours"]
21 # TRANSLATORS: you can alter the ordering of the remaining time
22 # information here if you shuffle %(str_hours)s %(str_minutes)s
23 # around. Make sure to keep all '$(str_*)s' in the translated string
24
25=== modified file 'debian/changelog'
26--- debian/changelog 2010-08-11 07:07:48 +0000
27+++ debian/changelog 2010-08-11 19:03:44 +0000
28@@ -1,3 +1,11 @@
29+update-manager (1:0.142.8) UNRELEASED; urgency=low
30+
31+ * DistUpgrade/DistUpgradeView.py: There won't be two spaces in
32+ FuzzyTimeToStr when days or hours are > 0 and hours or minutes are
33+ equal to 0 (LP: #288912)
34+
35+ -- Mohamed Amine IL Idrissi <ilidrissiamine@gmail.com> Wed, 11 Aug 2010 18:03:33 +0000
36+
37 update-manager (1:0.142.7) maverick; urgency=low
38
39 [ Mohamed Amine IL Idrissi ]

Subscribers

People subscribed via source and target branches

to status/vote changes: