Merge lp:~ilidrissi.amine/software-center/addons-no-recommends into lp:software-center

Proposed by Mohamed Amine Ilidrissi on 2010-09-01
Status: Rejected
Rejected by: Michael Vogt on 2012-01-05
Proposed branch: lp:~ilidrissi.amine/software-center/addons-no-recommends
Merge into: lp:software-center
Diff against target: 59 lines (+18/-6) (has conflicts)
2 files modified
debian/changelog (+9/-0)
softwarecenter/apt/aptcache.py (+9/-6)
Text conflict in debian/changelog
To merge this branch: bzr merge lp:~ilidrissi.amine/software-center/addons-no-recommends
Reviewer Review Type Date Requested Status
Matthew Paul Thomas 2010-09-01 Disapprove on 2010-09-21
Review via email: mp+34295@code.launchpad.net

Description of the change

Recommended add-ons will not be shown when the app is not installed, since they are automatically installed.

To post a comment you must log in.
Michael Vogt (mvo) wrote :

A good example to test this is gnumeric

Matthew Paul Thomas (mpt) wrote :

To me, Gnumeric looks like an example of why this would be undesirable. gnumeric Recommends: evince | evince-gtk, lp-solve, and gnumeric-doc. And you might reasonably want to install Gnumeric without any of those three. (It seems lp-solve currently isn't displayed only because openoffice.org-calc Depends: on it.)

Either Recommends: is just a synonym for Depends:, or it isn't. If it is, then it will seem redundant to new developers, making packaging unduly complicated. If it isn't, then we can report and fix inappropriate Recommends: values in existing packages, in the same way that we've been fixing bad package titles and descriptions.

review: Disapprove

mpt, recommended packages are not shown already, I just thought they were shown, my bad :(

Matthew Paul Thomas (mpt) wrote :

Recommended packages are shown for me in 2.1.22.3.

Michael Vogt (mvo) wrote :

Thanks for your work on this!

I still mark this as rejected for now as mpt disagrees with the design. Sorry for that and looking forward for more branches from you :)

Happy new year,
 Michael

Unmerged revisions

1094. By Mohamed Amine Ilidrissi on 2010-09-01

softwarecenter/apt/aptcache.py: Recommended add-ons will not be
shown when the app is not installed, since they are automatically
installed

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-09-01 14:47:12 +0000
3+++ debian/changelog 2010-09-01 14:50:32 +0000
4@@ -32,6 +32,7 @@
5 pathbar no longer shrinking to available width (LP: #625210),
6 many thanks Matthew McGowan!
7
8+<<<<<<< TREE
9 [ Kiwinote ]
10 * data/dialogs.ui:
11 - only display vscrollbar if needed for dependency removal alert
12@@ -67,6 +68,14 @@
13 - don't show as 'untitled window' in taskbar
14
15 -- Michael Vogt <michael.vogt@ubuntu.com> Wed, 01 Sep 2010 09:50:07 +0200
16+=======
17+ [ Mohamed Amine IL Idrissi ]
18+ * softwarecenter/apt/aptcache.py: Recommended add-ons will not be
19+ shown when the app is not installed, since they are automatically
20+ installed
21+
22+ -- Mohamed Amine IL Idrissi <ilidrissiamine@gmail.com> Wed, 01 Sep 2010 13:42:51 +0000
23+>>>>>>> MERGE-SOURCE
24
25 software-center (2.1.14.2) maverick; urgency=low
26
27
28=== modified file 'softwarecenter/apt/aptcache.py'
29--- softwarecenter/apt/aptcache.py 2010-08-31 15:47:29 +0000
30+++ softwarecenter/apt/aptcache.py 2010-09-01 14:50:32 +0000
31@@ -385,8 +385,10 @@
32 pkg = self._cache[pkgname]
33
34 # recommended addons
35- addons_rec = self.get_recommends(pkg)
36- LOG.debug("recommends: %s" % addons_rec)
37+ addons_rec = []
38+ if pkg.installed:
39+ addons_rec = self.get_recommends(pkg)
40+ LOG.debug("recommends: %s" % addons_rec)
41 # suggested addons and renhances
42 addons_sug = self.get_suggests(pkg)
43 LOG.debug("suggests: %s" % addons_sug)
44@@ -416,10 +418,11 @@
45 pkgdep = self._cache[dep]
46 if len(self.get_rdepends(pkgdep)) == 1:
47 # pkg is the only known package that depends on pkgdep
48- pkgdep_rec = self.get_recommends(pkgdep)
49- LOG.debug("recommends from lonley dependency %s: %s" % (
50- pkgdep, pkgdep_rec))
51- addons_rec += pkgdep_rec
52+ if pkg.installed:
53+ pkgdep_rec = self.get_recommends(pkgdep)
54+ LOG.debug("recommends from lonley dependency %s: %s" % (
55+ pkgdep, pkgdep_rec))
56+ addons_rec += pkgdep_rec
57 pkgdep_sug = self.get_suggests(pkgdep)
58 LOG.debug("suggests from lonley dependency %s: %s" % (
59 pkgdep, pkgdep_sug))

Subscribers

People subscribed via source and target branches