Merge lp:~ilidrissi.amine/software-center/addons-no-recommends into lp:software-center

[Mohamed Amine Ilidrissi]

Recommended add-ons will not be shown when the app is not installed, since they are automatically installed.

[Michael Vogt (mvo)]

A good example to test this is gnumeric

[Matthew Paul Thomas (mpt)]

To me, Gnumeric looks like an example of why this would be undesirable. gnumeric Recommends: evince | evince-gtk, lp-solve, and gnumeric-doc. And you might reasonably want to install Gnumeric without any of those three. (It seems lp-solve currently isn't displayed only because openoffice.org-calc Depends: on it.)

Either Recommends: is just a synonym for Depends:, or it isn't. If it is, then it will seem redundant to new developers, making packaging unduly complicated. If it isn't, then we can report and fix inappropriate Recommends: values in existing packages, in the same way that we've been fixing bad package titles and descriptions.

review: Disapprove

[Mohamed Amine Ilidrissi (ilidrissi.amine)]

mpt, recommended packages are not shown already, I just thought they were shown, my bad :(

[Matthew Paul Thomas (mpt)]

Recommended packages are shown for me in 2.1.22.3.

[Michael Vogt (mvo)]

Thanks for your work on this!

I still mark this as rejected for now as mpt disagrees with the design. Sorry for that and looking forward for more branches from you :)

Happy new year,
 Michael

Unmerged revisions

1094. By Mohamed Amine Ilidrissi on 2010-09-01

softwarecenter/apt/aptcache.py: Recommended add-ons will not be
shown when the app is not installed, since they are automatically
installed

=== modified file 'debian/changelog'
--- debian/changelog	2010-09-01 14:47:12 +0000
+++ debian/changelog	2010-09-01 14:50:32 +0000
@@ -32,6 +32,7 @@
     pathbar no longer shrinking to available width (LP: #625210),
     many thanks Matthew McGowan!
 
+<<<<<<< TREE
   [ Kiwinote ]
   * data/dialogs.ui:
     - only display vscrollbar if needed for dependency removal alert
@@ -67,6 +68,14 @@
     - don't show as 'untitled window' in taskbar
 
  -- Michael Vogt <[e-mail]>  Wed, 01 Sep 2010 09:50:07 +0200
+=======
+  [ Mohamed Amine IL Idrissi ]
+  * softwarecenter/apt/aptcache.py: Recommended add-ons will not be
+    shown when the app is not installed, since they are automatically
+    installed
+
+ -- Mohamed Amine IL Idrissi <[e-mail]>  Wed, 01 Sep 2010 13:42:51 +0000
+>>>>>>> MERGE-SOURCE
 
 software-center (2.1.14.2) maverick; urgency=low
 

=== modified file 'softwarecenter/apt/aptcache.py'
--- softwarecenter/apt/aptcache.py	2010-08-31 15:47:29 +0000
+++ softwarecenter/apt/aptcache.py	2010-09-01 14:50:32 +0000
@@ -385,8 +385,10 @@
         pkg = self._cache[pkgname]
 
         # recommended addons
-        addons_rec = self.get_recommends(pkg)
-        LOG.debug("recommends: %s" % addons_rec)
+        addons_rec = []
+        if pkg.installed:
+            addons_rec = self.get_recommends(pkg)
+            LOG.debug("recommends: %s" % addons_rec)
         # suggested addons and renhances
         addons_sug = self.get_suggests(pkg)
         LOG.debug("suggests: %s" % addons_sug)
@@ -416,10 +418,11 @@
                 pkgdep = self._cache[dep]
                 if len(self.get_rdepends(pkgdep)) == 1:
                     # pkg is the only known package that depends on pkgdep
-                    pkgdep_rec =  self.get_recommends(pkgdep)
-                    LOG.debug("recommends from lonley dependency %s: %s" % (
-                            pkgdep, pkgdep_rec))
-                    addons_rec += pkgdep_rec
+                    if pkg.installed:
+                        pkgdep_rec =  self.get_recommends(pkgdep)
+                        LOG.debug("recommends from lonley dependency %s: %s" % (
+                                pkgdep, pkgdep_rec))
+                        addons_rec += pkgdep_rec
                     pkgdep_sug =  self.get_suggests(pkgdep)
                     LOG.debug("suggests from lonley dependency %s: %s" % (
                             pkgdep, pkgdep_sug))