~ilasc/turnip:bug-1870080

Last commit made on 2020-04-06
Get this branch:
git clone -b bug-1870080 https://git.launchpad.net/~ilasc/turnip
Only Ioana Lasc can upload to this branch. If you are Ioana Lasc please log in for upload directions.

Branch merges

Branch information

Name:
bug-1870080
Repository:
lp:~ilasc/turnip

Recent commits

798da5c... by Ioana Lasc

Add version to the set of safe params

After parsing the extra params after 2 NUL bytes for git clients with
version 2 we need to allow the version param to pass through the
Git pack protocol conversion proxy (PackFrontendServerProtocol).

cd0a912... by Ioana Lasc

Address code review comments

Made small changes to decode_request recommended in code review.

d153c80... by Ioana Lasc

Parse extra parameters

Instead of discarding the extra params that
follow 2 NUL bytes we parse them.

8f3a5c4... by Ioana Lasc

Hide extra params after 2 NUL bytes

LP: #1870080

4e3d27e... by Colin Watson

Upgrade to Twisted 20.3.0

Merged from https://code.launchpad.net/~cjwatson/turnip/+git/turnip/+merge/381014

24b4710... by Colin Watson

Upgrade to Twisted 20.3.0

twisted.test.proto_helpers has been deprecated in favour of
twisted.internet.testing, so I updated all uses of the old name.

f445753... by Colin Watson

Fix SmartHTTPFrontendResource test setup

The test configuration needs to include main_site_root, since the
service will generate redirects to it.

e59724e... by Colin Watson

Fix leak in PackVirtServerProtocol.requestReceived

Merged from https://code.launchpad.net/~cjwatson/turnip/+git/turnip/+merge/380646

a83f614... by Colin Watson

Fix assertEqual ordering

4606c45... by Colin Watson

Fix leak in PackVirtServerProtocol.requestReceived

PackClientFactory called its Deferred's errback on failure, but didn't
callback on success. As a result,
PackVirtServerProtocol.requestReceived never returned in the successful
case, causing significant memory leaks over time.

LP: #1867028