turnip

Merge ~ilasc/turnip:shorten-line-charm-turnip-base into turnip:master

  1. Git
  2. lp:~ilasc/turnip
  3. shorten-line-charm-turnip-base
  4. Merge into master
Proposed by Ioana Lasc
Status: Merged
Approved by: Ioana Lasc
Approved revision: 249cfc3989fdb974a2439ccb1afcfc974cc05ea6
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~ilasc/turnip:shorten-line-charm-turnip-base
Merge into: turnip:master
Diff against target: 12 lines (+2/-1)
1 file modified
charm/layer/turnip-base/lib/charms/turnip/base.py (+2/-1)
Reviewer Review Type Date Requested Status
Thiago F. Pappacena (community) Approve
Review via email: mp+399504@code.launchpad.net

Commit message

Shorten line in 320 charm-turnip-base

Description of the change

Shortening line 320 :

"description='Git E2E {} (hint: check nfs-ganesha status)'.format(url),

to get it to pass make lint.

To post a comment you must log in.
Revision history for this message
Thiago F. Pappacena (pappacena) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charm/layer/turnip-base/lib/charms/turnip/base.py b/charm/layer/turnip-base/lib/charms/turnip/base.py
2index 19184f0..4cd1f55 100644
3--- a/charm/layer/turnip-base/lib/charms/turnip/base.py
4+++ b/charm/layer/turnip-base/lib/charms/turnip/base.py
5@@ -320,7 +320,8 @@ def add_nagios_e2e_checks(nagios):
6 nagios.add_check(
7 [os.path.join(nrpe_dir(), 'check_git_refs'), url],
8 name='check_turnip_git_refs_{}'.format(i),
9- description='Git E2E {} (hint: check nfs-ganesha status)'.format(url),
10+ description='Git E2E {} (hint: check nfs-ganesha status)'.format(
11+ url),
12 context=config['nagios_context'])
13
14

Subscribers

People subscribed via source and target branches