~ilasc/launchpad:call-download-api-without-file-id

Branch merges

Propose for merging

Merged into launchpad:master

Colin Watson (community): Approve on 2022-09-05

Diff: 819 lines (+59/-420)

10 files modified

lib/lp/code/errors.py (+1/-8)
lib/lp/code/interfaces/branchhosting.py (+2/-18)
lib/lp/code/model/branch.py (+1/-62)
lib/lp/code/model/branchhosting.py (+4/-29)
lib/lp/code/model/tests/test_branch.py (+6/-149)
lib/lp/code/model/tests/test_branchhosting.py (+21/-77)
lib/lp/code/tests/helpers.py (+0/-14)
lib/lp/services/webapp/publisher.py (+1/-6)
lib/lp/snappy/browser/tests/test_snap.py (+2/-7)
lib/lp/snappy/tests/test_snap.py (+21/-50)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

06bfe18... by Ioana Lasc on 2022-09-06

Address code review comments

2bbe8d3... by Ioana Lasc on 2022-09-05

Call new Loggerhead download API without file-id

06b8ef8... by Colin Watson on 2022-09-02

Implement __str__ for all Matcher subclasses

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/429363

73c2fe2... by Colin Watson on 2022-09-02

Adjust expected URLs for Python >= 3.7

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/429369

cbf7281... by Colin Watson on 2022-09-02

Make TestRevisionStatusReport.test_latest_log reliable

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/429370

902a6a2... by Colin Watson on 2022-09-02

Make TestRevisionStatusReport.test_latest_log reliable

`RevisionStatusArtifact`s created in the same transaction have the same
creation date by default. Override this so that `latest_log` has a
predictable result.

6e4385e... by Colin Watson on 2022-09-02

Tie-break snap listing sort on creation date

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/429362

bf2f40b... by Colin Watson on 2022-09-02

Adjust expected URLs for Python >= 3.7

Python 3.7 updated `urllib` quoting to RFC 3986, adding `~` to the set
of reserved characters. This broke a couple of doctests.

cbb5ab4... by Colin Watson on 2022-09-02

Implement __str__ for all Matcher subclasses

Matchers must implement `__str__` as well as `match`, but the base
`Matcher.__str__` raises `NotImplementedError`. Implement it properly.
This avoids unhelpful exceptions in some cases when matchers fail to
match.

8ee1d32... by Colin Watson on 2022-09-02

Tie-break snap listing sort on creation date

This allows fixing a couple of tests that listed multiple snaps with
identical modification times (because they were modified in the same
transaction) and so had unpredictable ordering.