Merge ~ilasc/launchpad:eslint-fix-no-new into launchpad:master

[Ioana Lasc]

Fix no-new in test_team_mailinglists.js

We need the new operator in there otherwise we fail with:

Failure in '
 '/home/ilasc/launchpad/launchpad/lib/lp/registry/javascript/tests/test_team_mailinglists.html.Team '
 'Mailinglists.test_nav: Unexpected error: undefined is not a function '
 "(evaluating 'this._initBase(cfg)'

[Colin Watson (cjwatson)]

Generally LGTM, but could you use `eslint-disable-next-line` rather than `eslint-disable`? As I understand it, `eslint-disable` disables the rule for the rest of the block or until a matching `eslint-enable` is reached, and we don't need to be that extensive here.

review: Approve

[Ioana Lasc (ilasc)]

Totally agreed (in fact that's what I meant to do), thanks for catching this Colin!
Tweaked and landing.

diff --git a/lib/lp/registry/javascript/tests/test_team_mailinglists.js b/lib/lp/registry/javascript/tests/test_team_mailinglists.js
index a196b0f..2932f59 100644
--- a/lib/lp/registry/javascript/tests/test_team_mailinglists.js
+++ b/lib/lp/registry/javascript/tests/test_team_mailinglists.js
@@ -54,6 +54,7 @@ YUI.add('lp.registry.team.mailinglists.test', function (Y) {
                 forwards_navigation: Y.all('.last,.next'),
                 backwards_navigation: Y.all('.first,.previous')
             };
+            // eslint-disable-next-line no-new
             new Y.lp.registry.team.mailinglists.MessageList(config);
 
             var fired = false;