Merge ~ilasc/launchpad:eslint-fix-no-console into launchpad:master

Proposed by Ioana Lasc
Status: Merged
Approved by: Ioana Lasc
Approved revision: c8d7199a84387078e5aea5149c29d04eebd639e5
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~ilasc/launchpad:eslint-fix-no-console
Merge into: launchpad:master
Diff against target: 12 lines (+1/-0)
1 file modified
lib/lp/app/javascript/lp-links.js (+1/-0)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+406996@code.launchpad.net

Commit message

Allow console log in lp-links.js

Description of the change

In this particular we will want to allow that console.log call so I added a disable of no-console only for the next line.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/app/javascript/lp-links.js b/lib/lp/app/javascript/lp-links.js
2index 60b49de..eb4740e 100644
3--- a/lib/lp/app/javascript/lp-links.js
4+++ b/lib/lp/app/javascript/lp-links.js
5@@ -80,6 +80,7 @@ YUI.add('lp.app.links', function(Y) {
6 failure: function(id, response, args) {
7 // If we have firebug installed, log the error.
8 if( Y.Lang.isValue(console) ) {
9+ // eslint-disable-next-line no-console
10 console.log("Link Check Error: " + args + ': '
11 + response.status + ' - ' +
12 response.statusText + ' - '

Subscribers

People subscribed via source and target branches

to status/vote changes: