Merge ~ilasc/launchpad:top50-repos-for-repack into launchpad:master

[Ioana Lasc]

Add a getTop50RepositoriesForRepack endpoint

[Cristian Gonzalez (cristiangsp)]

I have suggested a couple of tweaks but open for debate!

review: Needs Information

[Ioana Lasc (ilasc)]

Thanks Cristian, no debate, agreed with the comments and adjusted accordingly.
MP ready for review.

[Cristian Gonzalez (cristiangsp)]

Some little comments about comments added :P

[Ioana Lasc (ilasc)]

Comments about comments addressed :-) Thanks Cristian!

[Cristian Gonzalez (cristiangsp)]

Awesome job! Thanks.

review: Approve

diff --git a/lib/lp/code/interfaces/gitrepository.py b/lib/lp/code/interfaces/gitrepository.py
index dbd7870..5771d11 100644
--- a/lib/lp/code/interfaces/gitrepository.py
+++ b/lib/lp/code/interfaces/gitrepository.py
@@ -1223,6 +1223,18 @@ class IGitRepositorySet(Interface):
             Projects that do not have default repositories are omitted.
         """
 
+    @operation_parameters(limit=Int())
+    @export_read_operation()
+    @operation_for_version("devel")
+    def getRepositoriesForRepack(limit=50):
+        """Get the top badly packed repositories.
+
+        :param limit: The number of badly packed repositories
+            that the endpoint should return - it is 50 by default.
+
+        :return: A list of the worst badly packed repositories.
+        """
+
 
 class IGitRepositoryDelta(Interface):
     """The quantitative changes made to a Git repository that was edited or
diff --git a/lib/lp/code/model/gitrepository.py b/lib/lp/code/model/gitrepository.py
index 58c298c..d0ac773 100644
--- a/lib/lp/code/model/gitrepository.py
+++ b/lib/lp/code/model/gitrepository.py
@@ -1996,6 +1996,22 @@ class GitRepositorySet:
         return {
             repository.project_id: repository for repository in repositories}
 
+    def getRepositoriesForRepack(self, limit=50):
+        """See `IGitRepositorySet`."""
+        repos = IStore(GitRepository).find(
+            GitRepository,
+            Or(
+                GitRepository.loose_object_count >=
+                    config.codehosting.loose_objects_threshold,
+                GitRepository.pack_count >=
+                    config.codehosting.packs_threshold,
+                ),
+            GitRepository.status == GitRepositoryStatus.AVAILABLE,
+        ).order_by(
+            Desc(GitRepository.loose_object_count)).config(limit=limit)
+
+        return list(repos)
+
 
 @implementer(IMacaroonIssuer)
 class GitRepositoryMacaroonIssuer(MacaroonIssuerBase):
diff --git a/lib/lp/code/model/tests/test_gitrepository.py b/lib/lp/code/model/tests/test_gitrepository.py
index a0d0baa..ff79c65 100644
--- a/lib/lp/code/model/tests/test_gitrepository.py
+++ b/lib/lp/code/model/tests/test_gitrepository.py
@@ -4069,6 +4069,44 @@ class TestGitRepositoryWebservice(TestCaseWithFactory):
     def test_getRepositories_personal(self):
         self.assertGetRepositoriesWorks(self.factory.makePerson())
 
+    def test_getRepositoriesForRepack(self):
+        person = self.factory.makePerson()
+        webservice = webservice_for_person(
+            person, permission=OAuthPermission.WRITE_PUBLIC)
+        webservice.default_api_version = "devel"
+        response = webservice.named_get(
+            "/+git", "getRepositoriesForRepack", limit=3)
+        self.assertEqual(200, response.status)
+        self.assertEqual([], response.jsonBody())
+        with person_logged_in(person):
+            repo = []
+            for i in range(5):
+                repo.append(self.factory.makeGitRepository())
+            for i in range(3):
+                removeSecurityProxy(repo[i]).loose_object_count = 7000 + i
+                removeSecurityProxy(repo[i]).pack_count = 43
+
+        # We have a total of 3 candidates now
+        response = webservice.named_get(
+            "/+git", "getRepositoriesForRepack", limit=10)
+        self.assertEqual(200, response.status)
+        self.assertContentEqual(
+            [7002, 7001, 7000],
+            [entry['loose_object_count']
+             for entry in response.jsonBody()])
+
+        # When we have 5 repack candidates but limit at 4
+        # we should only get back 4 repos from the query.
+        removeSecurityProxy(repo[3]).loose_object_count = 7003
+        removeSecurityProxy(repo[4]).loose_object_count = 7004
+        response = webservice.named_get(
+            "/+git", "getRepositoriesForRepack", limit=4)
+        self.assertEqual(200, response.status)
+        self.assertContentEqual(
+            [7004, 7003, 7002, 7001],
+            [entry['loose_object_count']
+             for entry in response.jsonBody()])
+
     def test_getNumberRepositoriesForRepack(self):
         person = self.factory.makePerson()
         webservice = webservice_for_person(