Merge ~ilasc/launchpad:db-git-repo-repack-indexes into launchpad:master

[Ioana Lasc]

Add GitRepository(loose_object_count, pack_count) index

[Colin Watson (cjwatson)]

LGTM, just tiny nits. Adding William for a second DB review as usual.

review: Approve

[William Grant (wgrant)]

What is the purpose of the status filter?

review: Needs Information (db)

[Ioana Lasc (ilasc)]

Thanks Colin.

William the purpose of the status filter is to target only available repositories, extra precaution.

[William Grant (wgrant)]

There should be very few repositories that don't have that status. I think a partial index here is more of a trap than a positive, so I'd remove the status filter.

[Ioana Lasc (ilasc)]

Makes sense, thanks William, done, MP ready for another look.

[William Grant (wgrant)]

review: Approve (db)

diff --git a/database/schema/patch-2210-28-0.sql b/database/schema/patch-2210-28-0.sql
new file mode 100644
index 0000000..8cd7afb
--- /dev/null
+++ b/database/schema/patch-2210-28-0.sql
@@ -0,0 +1,9 @@
+-- Copyright 2021 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+CREATE INDEX gitrepository__loose_object_count__pack_count__idx
+    ON GitRepository(loose_object_count, pack_count);
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2210, 28, 0);