Launchpad itself

Merge ~ilasc/launchpad:add-repack-thresholds into launchpad:master

  1. Git
  2. lp:~ilasc/launchpad
  3. add-repack-thresholds
  4. Merge into master
Proposed by Ioana Lasc
Status: Merged
Approved by: Ioana Lasc
Approved revision: 67e31579dda9ca60fade471caf20c63c9c3bafe5
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~ilasc/launchpad:add-repack-thresholds
Merge into: launchpad:master
Diff against target: 28 lines (+6/-0)
2 files modified
configs/development/launchpad-lazr.conf (+2/-0)
lib/lp/services/config/schema-lazr.conf (+4/-0)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Cristian Gonzalez (community) Approve
Review via email: mp+398119@code.launchpad.net

Commit message

Add git repository repack thresholds

To post a comment you must log in.
Revision history for this message
Cristian Gonzalez (cristiangsp) wrote :

Looks good!

review: Approve
Revision history for this message
Colin Watson (cjwatson) wrote :

I think these should be in the [codehosting] section rather than [launchpad], but otherwise seems OK. (Normally I would only add new config items along with the code that uses them, but if you want to do it separately then it doesn't cause a problem.)

review: Approve
Revision history for this message
Ioana Lasc (ilasc) wrote :

Agreed they belong under codehosting, moved, thanks Colin.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/configs/development/launchpad-lazr.conf b/configs/development/launchpad-lazr.conf
2index ee141fb..5c0f74a 100644
3--- a/configs/development/launchpad-lazr.conf
4+++ b/configs/development/launchpad-lazr.conf
5@@ -52,6 +52,8 @@ internal_git_api_endpoint: http://git.launchpad.test:19417/
6 git_browse_root: https://git.launchpad.test/
7 git_anon_root: git://git.launchpad.test/
8 git_ssh_root: git+ssh://git.launchpad.test/
9+loose_objects_threshold: 4350
10+packs_threshold: 30
11
12 [codeimport]
13 bazaar_branch_store: file:///tmp/bazaar-branches
14diff --git a/lib/lp/services/config/schema-lazr.conf b/lib/lp/services/config/schema-lazr.conf
15index 3a61db5..7b35f3a 100644
16--- a/lib/lp/services/config/schema-lazr.conf
17+++ b/lib/lp/services/config/schema-lazr.conf
18@@ -377,6 +377,10 @@ related_bugs_from_source_limit: 1000
19 # Secret key for Git access tokens issued to Launchpad users.
20 git_macaroon_secret_key: none
21
22+# Git repository repack thresholds.
23+loose_objects_threshold: 4350
24+packs_threshold: 30
25+
26
27 [codeimport]
28 # Where the Bazaar imports are stored.

Subscribers

People subscribed via source and target branches

to status/vote changes: