Merge ~ilasc/launchpad:add-person-livefs-index-view into launchpad:master

[Ioana Lasc]

Add Person:+livefs index view

Added livefs index view to provide the UI list of all the live filesystems owned by a given person.

[Colin Watson (cjwatson)]

I have various nitpicks below, but I think you can go ahead and land this once you've fixed those. Thanks!

review: Approve

diff --git a/lib/lp/registry/browser/configure.zcml b/lib/lp/registry/browser/configure.zcml
index b8dc1bb..3991dd5 100644
--- a/lib/lp/registry/browser/configure.zcml
+++ b/lib/lp/registry/browser/configure.zcml
@@ -1231,6 +1231,13 @@
         template="../templates/person-oauth-tokens.pt"
         />
     <browser:page
+        name="+livefs"
+        for="lp.registry.interfaces.person.IPerson"
+        class="lp.registry.browser.person.PersonLiveFSView"
+        permission="launchpad.View"
+        template="../templates/person-livefses.pt"
+        />
+    <browser:page
         name="+index"
         for="lp.registry.interfaces.person.ITeam"
         class="lp.registry.browser.team.TeamIndexView"
diff --git a/lib/lp/registry/browser/person.py b/lib/lp/registry/browser/person.py
index 8677ecd..d512b7b 100644
--- a/lib/lp/registry/browser/person.py
+++ b/lib/lp/registry/browser/person.py
@@ -27,6 +27,7 @@ __all__ = [
     'PersonIndexView',
     'PersonKarmaView',
     'PersonLanguagesView',
+    'PersonLiveFSView',
     'PersonNavigation',
     'PersonOAuthTokensView',
     'PersonOverviewMenu',
@@ -3620,6 +3621,28 @@ class PersonOAuthTokensView(LaunchpadView):
             canonical_url(self.context, view_name='+oauth-tokens'))
 
 
+class PersonLiveFSView(LaunchpadView):
+    """Default view for the list of live filesystems owned by a person."""
+    page_title = 'LiveFS'
+
+    @property
+    def label(self):
+        return 'Live filesystems for %s' % self.context.display_name
+
+    @property
+    def livefses(self):
+        livefses = getUtility(ILiveFSSet).getByPerson(self.context)
+        return livefses.order_by('name')
+
+    @property
+    def livefses_navigator(self):
+        return BatchNavigator(self.livefses, self.request)
+
+    @cachedproperty
+    def count(self):
+        return self.livefses_navigator.batch.total()
+
+
 class PersonTimeZoneForm(Interface):
 
     time_zone = Choice(
diff --git a/lib/lp/registry/browser/tests/test_person.py b/lib/lp/registry/browser/tests/test_person.py
index 626cab4..10bbba7 100644
--- a/lib/lp/registry/browser/tests/test_person.py
+++ b/lib/lp/registry/browser/tests/test_person.py
@@ -1,10 +1,14 @@
-# Copyright 2009-2017 Canonical Ltd.  This software is licensed under the
+# -*- coding: utf-8 -*-
+# Copyright 2009-2020 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
+from __future__ import unicode_literals
+
 __metaclass__ = type
 
 import doctest
 import email
+from operator import attrgetter
 import re
 from textwrap import dedent
 
@@ -24,6 +28,7 @@ from zope.publisher.interfaces import NotFound
 from zope.security.proxy import removeSecurityProxy
 
 from lp.app.browser.lazrjs import TextAreaEditorWidget
+from lp.app.browser.tales import DateTimeFormatterAPI
 from lp.app.enums import InformationType
 from lp.app.errors import NotFoundError
 from lp.app.interfaces.launchpad import ILaunchpadCelebrities
@@ -43,6 +48,7 @@ from lp.registry.model.karma import KarmaCategory
 from lp.registry.model.milestone import milestone_sort_key
 from lp.scripts.garbo import PopulateLatestPersonSourcePackageReleaseCache
 from lp.services.config import config
+from lp.services.features.testing import FeatureFixture
 from lp.services.identity.interfaces.account import AccountStatus
 from lp.services.identity.interfaces.emailaddress import IEmailAddressSet
 from lp.services.log.logger import DevNullLogger
@@ -61,6 +67,7 @@ from lp.soyuz.enums import (
     ArchiveStatus,
     PackagePublishingStatus,
     )
+from lp.soyuz.interfaces.livefs import LIVEFS_FEATURE_FLAG
 from lp.soyuz.tests.test_publishing import SoyuzTestPublisher
 from lp.testing import (
     ANONYMOUS,
@@ -1274,6 +1281,147 @@ class TestPersonRelatedProjectsView(TestCaseWithFactory):
         self.assertThat(view(), next_match)
 
 
+class TestPersonLiveFSView(BrowserTestCase):
+    layer = DatabaseFunctionalLayer
+
+    def setUp(self):
+        super(TestPersonLiveFSView, self).setUp()
+        self.useFixture(FeatureFixture({LIVEFS_FEATURE_FLAG: "on"}))
+        self.person = self.factory.makePerson(
+            name="test-person", displayname="Test Person")
+
+    def makeLiveFS(self, count=1):
+        with person_logged_in(self.person):
+            return [
+                self.factory.makeLiveFS(
+                    registrant=self.person, owner=self.person)
+                for _ in range(count)]
+
+    def test_displays_livefs(self):
+        livefs = self.factory.makeLiveFS(
+            registrant=self.person, owner=self.person)
+        view = create_initialized_view(
+            self.person, "+livefs", principal=self.person)
+
+        expected_url = "/~%s/+livefs/%s/%s/%s" % (
+                livefs.owner.name, livefs.distro_series.distribution.name,
+                livefs.distro_series.name, livefs.name)
+        link_match = soupmatchers.HTMLContains(
+            soupmatchers.Tag(
+                'Livefs name link', 'a',
+                attrs={'href': expected_url},
+                text=livefs.name))
+        date_formatter = DateTimeFormatterAPI(livefs.date_created)
+        date_created_match = soupmatchers.HTMLContains(
+            soupmatchers.Tag(
+                'Livefs date created', 'td',
+                text='%s' % date_formatter.displaydate()))
+        with person_logged_in(self.person):
+            self.assertThat(view.render(), link_match)
+            self.assertThat(view.render(), date_created_match)
+
+    def test_displays_no_livefs(self):
+        view = create_initialized_view(
+            self.person, "+livefs", principal=self.person)
+        no_livefs_match = soupmatchers.HTMLContains(
+            soupmatchers.Tag(
+                'No livefs', 'p',
+                text='There are no live filesystems for %s'
+                % self.person.display_name))
+        with person_logged_in(self.person):
+            self.assertThat(view.render(), no_livefs_match)
+
+    def test_paginates_livefs(self):
+        batch_size = 5
+        self.pushConfig("launchpad", default_batch_size=batch_size)
+        livefs = self.makeLiveFS(10)
+        view = create_initialized_view(
+            self.person, "+livefs", principal=self.person)
+        no_livefs_match = soupmatchers.HTMLContains(
+            soupmatchers.Tag(
+                'Top livefs paragraph', 'strong',
+                text="10"))
+        first_match = soupmatchers.HTMLContains(
+            soupmatchers.Tag(
+                'Navigation first', 'span',
+                attrs={'class': 'first inactive'},
+                text="First"))
+        previous_match = soupmatchers.HTMLContains(
+            soupmatchers.Tag(
+                'Navigation previous', 'span',
+                attrs={'class': 'previous inactive'},
+                text="Previous"))
+        with person_logged_in(self.person):
+            self.assertThat(view.render(), no_livefs_match)
+            self.assertThat(view.render(), first_match)
+            self.assertThat(view.render(), previous_match)
+            self.assertThat(view.render(), soupmatchers.HTMLContains(
+                soupmatchers.Within(
+                    soupmatchers.Tag(
+                        "next element", "a",
+                        attrs={"id": "lower-batch-nav-batchnav-next"}),
+                    soupmatchers.Tag(
+                        "next link", "strong",
+                        text='Next'))))
+            self.assertThat(view.render(), soupmatchers.HTMLContains(
+                    soupmatchers.Tag(
+                        "last element", "a",
+                        attrs={"id": "lower-batch-nav-batchnav-last"},
+                        text='Last')))
+
+            # Assert we're listing the first set of live filesystems
+            items = sorted(livefs, key=attrgetter('name'))
+            for lfs in items[:batch_size]:
+                expected_url = "/~%s/+livefs/%s/%s/%s" % (
+                    lfs.owner.name, lfs.distro_series.distribution.name,
+                    lfs.distro_series.name, lfs.name)
+                link_match = soupmatchers.HTMLContains(
+                    soupmatchers.Tag(
+                        'Livefs name link', 'a',
+                        attrs={'href': expected_url},
+                        text=lfs.name))
+                self.assertThat(view.render(), link_match)
+
+    def test_displays_livefs_only_for_owner(self):
+        livefs = self.factory.makeLiveFS(
+            registrant=self.person, owner=self.person)
+        different_owner = self.factory.makePerson(
+            name="different-person", displayname="Different Person")
+        livefs_different_owner = self.factory.makeLiveFS(
+            registrant=different_owner, owner=different_owner)
+        view = create_initialized_view(
+            self.person, "+livefs", principal=self.person)
+        expected_url = "/~%s/+livefs/%s/%s/%s" % (
+                livefs.owner.name, livefs.distro_series.distribution.name,
+                livefs.distro_series.name, livefs.name)
+        link_match = soupmatchers.HTMLContains(
+            soupmatchers.Tag(
+                'Livefs name link', 'a',
+                attrs={'href': expected_url},
+                text=livefs.name))
+        date_formatter = DateTimeFormatterAPI(livefs.date_created)
+        date_created_match = soupmatchers.HTMLContains(
+            soupmatchers.Tag(
+                'Livefs date created', 'td',
+                text='%s' % date_formatter.displaydate()))
+
+        different_owner_url = "/~%s/+livefs/%s/%s/%s" % (
+                livefs_different_owner.owner.name,
+                livefs_different_owner.distro_series.distribution.name,
+                livefs_different_owner.distro_series.name,
+                livefs_different_owner.name)
+        different_owner_match = soupmatchers.HTMLContains(
+            soupmatchers.Tag(
+                'Livefs name link', 'a',
+                attrs={'href': different_owner_url},
+                text=livefs_different_owner.name))
+
+        with person_logged_in(self.person):
+            self.assertThat(view.render(), link_match)
+            self.assertThat(view.render(), date_created_match)
+            self.assertNotIn(different_owner_match, view.render())
+
+
 class TestPersonRelatedPackagesFailedBuild(TestCaseWithFactory):
     """The related packages views display links to failed builds."""
 
diff --git a/lib/lp/registry/templates/person-livefses.pt b/lib/lp/registry/templates/person-livefses.pt
new file mode 100644
index 0000000..b292801
--- /dev/null
+++ b/lib/lp/registry/templates/person-livefses.pt
@@ -0,0 +1,46 @@
+<html
+  xmlns="http://www.w3.org/1999/xhtml"
+  xmlns:tal="http://xml.zope.org/namespaces/tal"
+  xmlns:metal="http://xml.zope.org/namespaces/metal"
+  xmlns:i18n="http://xml.zope.org/namespaces/i18n"
+  metal:use-macro="view/macro:page/main_side"
+  i18n:domain="launchpad"
+>
+
+<body>
+  <metal:side fill-slot="side">
+    <div tal:replace="structure context/@@+global-actions"/>
+  </metal:side>
+
+  <div metal:fill-slot="main">
+      <div class="main-portlet">
+        <p tal:define="count view/count" tal:condition="count">
+          <span tal:condition="python: count == 1">There is <strong>1</strong> live filesystem</span>
+          <span tal:condition="python: count != 1">There are <strong tal:content="count"/> live filesystems</span>
+          registered for <tal:owner replace="context/display_name" />.
+        </p>
+        <p tal:condition="not: view/count">There are no live filesystems for <tal:owner replace="context/display_name"/></p>
+      </div>
+
+      <table class="listing" id="livefses_list" tal:condition="view/count">
+        <tbody>
+          <tr class="head">
+            <th>Name</th>
+            <th>Date created</th>
+          </tr>
+
+          <tr tal:repeat="filesystem view/livefses">
+            <td>
+              <a tal:content="filesystem/name"
+                 tal:attributes="href filesystem/fmt:url" />
+            </td>
+            <td tal:content="filesystem/date_created/fmt:displaydate" />
+          </tr>
+        </tbody>
+      </table>
+
+      <tal:navigation replace="structure view/livefses_navigator/@@+navigation-links-lower" />
+  </div>
+
+</body>
+</html>