Percona XtraBackup moved to https://jira.percona.com/projects/PXB

Code review comment for lp:~igor-tverdovskiy/percona-xtrabackup/move-back_opt

  1. move-back_opt
  2. Merge into 2.0
Revision history for this message
Alexey Kopytov (akopytov) wrote :

There's still one conflict in the pod section of innobackupex:

176 -innobackupex --copy-back [--defaults-file=MY.CNF] [--defaults-group=GROUP-NAME] BACKUP-DIR
177 +<<<<<<< TREE
178 +innobackupex --copy-back [--defaults-file=MY.CNF] [--defaults-group=GROUP-NAME] BACKUP-DIR
179 +=======
180 +innobackupex --copy-back [--defaults-file=MY.CNF] [--defaults-group=GROUP-NAME] BACKUP-DIR
181 + --move-back [--defaults-file=MY.CNF] [--defaults-group=GROUP-NAME] BACKUP-DIR
182 +>>>>>>> MERGE-SOURCE

I would create a separate line in the help text, rather than add --move-back to the existing one describing the --copy-back synopsis, i.e.:

innobackupex --copy-back [--defaults-file=MY.CNF] [--defaults-group=GROUP-NAME] BACKUP-DIR

innobackupex --move-back [--defaults-file=MY.CNF] [--defaults-group=GROUP-NAME] BACKUP-DIR

review: Needs Fixing

« Back to merge proposal