Merge lp:~ignacio-nin/percona-xtradb-cluster/5.5.29-nonconflicting-libmysqlclient into lp:percona-xtradb-cluster/percona-xtradb-cluster-5.5

Proposed by Ignacio Nin
Status: Merged
Merged at revision: 387
Proposed branch: lp:~ignacio-nin/percona-xtradb-cluster/5.5.29-nonconflicting-libmysqlclient
Merge into: lp:percona-xtradb-cluster/percona-xtradb-cluster-5.5
Prerequisite: lp:~percona-core/percona-xtradb-cluster/release-5.5.29
Diff against target: 61 lines (+9/-4)
2 files modified
build/percona-shared-compat.spec (+4/-0)
build/percona-xtradb-cluster.spec (+5/-4)
To merge this branch: bzr merge lp:~ignacio-nin/percona-xtradb-cluster/5.5.29-nonconflicting-libmysqlclient
Reviewer Review Type Date Requested Status
Raghavendra D Prabhu (community) Approve
Review via email: mp+155290@code.launchpad.net

This proposal supersedes a proposal from 2013-03-09.

Description of the change

Changes for solving the RPM shared packages related bugs.

This works together with lp:~ignacio-nin/percona-server/5.0-nonconflicting-libmysqlclient, lp:~ignacio-nin/percona-server/5.1-nonconflicting-libmysqlclient and lp:~ignacio-nin/percona-server/5.5-nonconflicting-libmysqlclient for the products becoming compatible when installing the percona-server-shared package.

To post a comment you must log in.
Revision history for this message
Raghavendra D Prabhu (raghavendra-prabhu) wrote : Posted in a previous version of this proposal

I don't think

-SET(WSREP_PATCH_VERSION "7.1")
+SET(WSREP_PATCH_VERSION "7.2")

should be part of this patch since it is bumped upstream. (and it is 7.3 now).

review: Needs Fixing
Revision history for this message
Ignacio Nin (ignacio-nin) wrote : Posted in a previous version of this proposal

> I don't think
>
> -SET(WSREP_PATCH_VERSION "7.1")
> +SET(WSREP_PATCH_VERSION "7.2")
>
> should be part of this patch since it is bumped upstream. (and it is 7.3 now).

Right now in the target branch Percona-Server/cmake/wsrep.cmake contains 7.1. Also, what's upstream in this context?

Revision history for this message
Raghavendra D Prabhu (raghavendra-prabhu) wrote : Posted in a previous version of this proposal

In the upstream file it is 7.3, ie.

SET(WSREP_PATCH_VERSION "7.3")

Revision history for this message
Ignacio Nin (ignacio-nin) wrote :

I've resubmitted the branch and listed lp:~percona-core/percona-server/release-5.5.29 as a prerrequisite branch, which is where that change originated.

Revision history for this message
Raghavendra D Prabhu (raghavendra-prabhu) wrote :

Merged.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'build/percona-shared-compat.spec'
2--- build/percona-shared-compat.spec 2013-01-22 16:19:45 +0000
3+++ build/percona-shared-compat.spec 2013-03-25 17:17:31 +0000
4@@ -47,7 +47,11 @@
5 Version: %{version55}
6 Release: %{release}.%{gotrevision}.rhel%{redhatversion}
7 BuildRoot: %{_tmppath}/%{name}-%{version}-build
8+%if "%{redhatversion}" == "5"
9+Obsoletes: MySQL-shared mysql
10+%else
11 Obsoletes: MySQL-shared mysql-libs
12+%endif
13 Provides: MySQL-shared mysql-libs
14 Summary: MySQL shared client libraries for MySQL %{version}, %{version50}, %{version41} and %{version40}
15
16
17=== modified file 'build/percona-xtradb-cluster.spec'
18--- build/percona-xtradb-cluster.spec 2013-03-25 17:17:31 +0000
19+++ build/percona-xtradb-cluster.spec 2013-03-25 17:17:31 +0000
20@@ -263,7 +263,7 @@
21 %package -n Percona-XtraDB-Cluster-server%{product_suffix}
22 Summary: Percona XtraDB Cluster - server package
23 Group: Applications/Databases
24-Requires: %{distro_requires} mysql-libs Percona-XtraDB-Cluster-galera%{product_suffix} xtrabackup >= 1.9.0 tar nc rsync
25+Requires: %{distro_requires} Percona-XtraDB-Cluster-client%{product_suffix} Percona-XtraDB-Cluster-shared%{product_suffix} Percona-XtraDB-Cluster-galera%{product_suffix} xtrabackup >= 1.9.0 tar nc rsync
26 Provides: mysql-server MySQL-server Percona-Server-server
27 Conflicts: Percona-Server-server-55 Percona-Server-server-51
28
29@@ -288,7 +288,7 @@
30 %package -n Percona-XtraDB-Cluster-client%{product_suffix}
31 Summary: Percona XtraDB Cluster - client package
32 Group: Applications/Databases
33-Requires: mysql-libs
34+Requires: Percona-XtraDB-Cluster-shared%{product_suffix}
35 Provides: mysql-client MySQL-client mysql MySQL Percona-XtraDB-Cluster-client
36 Conflicts: Percona-Server-client-55 Percona-Server-client-51 Percona-SQL-client-50
37
38@@ -362,7 +362,7 @@
39 Summary: Percona XtraDB Cluster - Shared libraries
40 Group: Applications/Databases
41 Provides: mysql-shared mysql-libs Percona-Server-shared
42-Conflicts: Percona-Server-shared-55 Percona-Server-shared-51
43+Conflicts: Percona-Server-shared-55
44
45 %description -n Percona-XtraDB-Cluster-shared%{product_suffix}
46 Percona XtraDB Cluster is based on the Percona Server database server and
47@@ -1168,12 +1168,13 @@
48 %{_libdir}/mysql/libmysqlservices.a
49 %{_libdir}/mysql/libhsclient.a
50 %{_libdir}/libhsclient.la
51+%{_libdir}/*.so
52
53 # ----------------------------------------------------------------------------
54 %files -n Percona-XtraDB-Cluster-shared%{product_suffix}
55 %defattr(-, root, root, 0755)
56 # Shared libraries (omit for architectures that don't support them)
57-%{_libdir}/libmysql*.so*
58+%{_libdir}/libmysql*.so.*
59 # Maatkit UDF libs
60 %{_libdir}/mysql/plugin/libfnv1a_udf.a
61 %{_libdir}/mysql/plugin/libfnv1a_udf.la

Subscribers

People subscribed via source and target branches

to all changes: