Merge lp:~ignacio-nin/percona-server/5.6-bug1225189 into lp:percona-server/5.6

Proposed by Ignacio Nin
Status: Merged
Approved by: Laurynas Biveinis
Approved revision: no longer in the source branch.
Merged at revision: 471
Proposed branch: lp:~ignacio-nin/percona-server/5.6-bug1225189
Merge into: lp:percona-server/5.6
Diff against target: 54 lines (+7/-3)
1 file modified
Percona-Server/scripts/mysql_install_db.pl.in (+7/-3)
To merge this branch: bzr merge lp:~ignacio-nin/percona-server/5.6-bug1225189
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Approve
Review via email: mp+188472@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Percona-Server/scripts/mysql_install_db.pl.in'
2--- Percona-Server/scripts/mysql_install_db.pl.in 2013-02-28 13:32:03 +0000
3+++ Percona-Server/scripts/mysql_install_db.pl.in 2013-09-30 21:51:22 +0000
4@@ -421,6 +421,7 @@
5 -x $print_defaults or -f "$print_defaults.exe"
6 or cannot_find_file($print_defaults);
7
8+<<'CONFIGFILE_BUG1225189';
9 my $config_file;
10 my $copy_cfg_file;
11
12@@ -457,6 +458,7 @@
13 $failed_write_cfg= 1;
14 }
15 close TEMPL;
16+CONFIGFILE_BUG1225189
17
18 # ----------------------------------------------------------------------
19 # Now we can get arguments from the groups [mysqld] and [mysql_install_db]
20@@ -466,15 +468,15 @@
21 my $print_def_file;
22 if ( $opt->{'defaults-file'} )
23 {
24- $print_def_file= $opt->{'defaults-file'};
25+ $print_def_file= "--defaults-file=$opt->{'defaults-file'}";
26 }
27 else
28 {
29- $print_def_file= $config_file;
30+ $print_def_file= "";
31 }
32
33 my @default_options;
34-my $cmd = quote_options($print_defaults,"--defaults-file=$print_def_file",
35+my $cmd = quote_options($print_defaults, $print_def_file,
36 "mysqld","mysql_install_db");
37 open(PIPE, "$cmd |") or error($opt,"can't run $cmd: $!");
38 while ( <PIPE> )
39@@ -846,6 +848,7 @@
40 "",
41 "Support MySQL by buying support/licenses at http://shop.mysql.com");
42
43+<<'CONFIGFILE_BUG1225189';
44 if ($copy_cfg_file eq $config_file and !$failed_write_cfg)
45 {
46 report($opt,
47@@ -871,6 +874,7 @@
48 "The new default config file was created as $copy_cfg_file,",
49 "please compare it with your file and take the changes you need.");
50 }
51+CONFIGFILE_BUG1225189
52 foreach my $cfg ( "/etc/my.cnf", "/etc/mysql/my.cnf" )
53 {
54 check_sys_cfg_file ($opt, $cfg);

Subscribers

People subscribed via source and target branches