Merge lp:~ignacio-nin/percona-server/5.1-debian---source into lp:percona-server/5.1

Proposed by Ignacio Nin
Status: Merged
Approved by: Laurynas Biveinis
Approved revision: no longer in the source branch.
Merged at revision: 560
Proposed branch: lp:~ignacio-nin/percona-server/5.1-debian---source
Merge into: lp:percona-server/5.1
Prerequisite: lp:~ignacio-nin/percona-server/5.1-debian---epoch
Diff against target: 75 lines (+9/-7)
3 files modified
build/build-dpkg.sh (+7/-5)
build/debian/control (+1/-1)
build/debian/rules (+1/-1)
To merge this branch: bzr merge lp:~ignacio-nin/percona-server/5.1-debian---source
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Approve
Review via email: mp+162044@code.launchpad.net

This proposal supersedes a proposal from 2013-05-02.

Description of the change

Add a --source parameter to the debian builder.
Do not run checks by default, instead, a parameter needs to be passed for check to be run (dpkg).
Adjust the Build-Requires for debian.

To post a comment you must log in.
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

I assume that commit 492 is the one to be reviewed.
But prerequisite branch commits come after this one, not before, probably that's why the diff does not exclude prerequisite changes.

review: Approve
Revision history for this message
Ignacio Nin (ignacio-nin) wrote :

Hello,

Commits 492-494 are the new ones, commits 495 and 496 are just to prevent conflicts since they work on the same lines. Yes, I set a prerrequiste branch that's the one that includes 496 (already approved, but not merged to trunk).

Piggybacked commits.

Commit 493 is the change from "ifeq ... nocheck" to "ifneq ... check", so we change the default.

Commit 494 is the change in BuildRequires (removing doxygen which is not used).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'build/build-dpkg.sh'
2--- build/build-dpkg.sh 2013-05-02 08:18:31 +0000
3+++ build/build-dpkg.sh 2013-05-02 08:18:32 +0000
4@@ -12,14 +12,15 @@
5 set -ue
6
7 # Examine parameters
8-go_out="$(getopt --options "k:Ke:b" --longoptions key:,nosign,epoch:,binary \
9+go_out="$(getopt --options "k:Ke:bS" \
10+ --longoptions key:,nosign,epoch:,binary,source \
11 --name "$(basename "$0")" -- "$@")"
12 test $? -eq 0 || exit 1
13 eval set -- $go_out
14
15 BUILDPKG_KEY=''
16 EPOCH=''
17-BINARY=''
18+DPKG_BINSRC=''
19
20 for arg
21 do
22@@ -28,7 +29,8 @@
23 -k | --key ) shift; BUILDPKG_KEY="-pgpg -k$1"; shift;;
24 -K | --nosign ) shift; BUILDPKG_KEY="-uc -us";;
25 -e | --epoch ) shift; EPOCH="$1:"; shift;;
26- -b | --binary ) shift; BINARY='-b';;
27+ -b | --binary ) shift; DPKG_BINSRC='-b';;
28+ -S | --source ) shift; DPKG_BINSRC='-S';;
29 esac
30 done
31
32@@ -76,7 +78,7 @@
33
34 # Build information
35 export BB_PERCONA_REVISION="$(cd "$SOURCEDIR"; bzr revno)"
36-export DEB_BUILD_OPTIONS='debug nocheck'
37+export DEB_BUILD_OPTIONS='debug'
38 export MYSQL_BUILD_CC='gcc'
39 export MYSQL_BUILD_CXX='gcc'
40 export HS_CXX=${HS_CXX:-g++}
41@@ -107,7 +109,7 @@
42 # Update distribution name
43 dch -m -D "$DEBIAN_VERSION" --force-distribution -v "$EPOCH$MYSQL_VERSION-$PERCONA_SERVER_VERSION-$BB_PERCONA_REVISION.$DEBIAN_VERSION" 'Update distribution'
44
45- dpkg-buildpackage $BINARY -rfakeroot $BUILDPKG_KEY
46+ dpkg-buildpackage $DPKG_BINSRC -rfakeroot $BUILDPKG_KEY
47
48 )
49
50
51=== modified file 'build/debian/control'
52--- build/debian/control 2013-04-10 15:15:58 +0000
53+++ build/debian/control 2013-05-02 08:18:32 +0000
54@@ -3,7 +3,7 @@
55 Priority: optional
56 Maintainer: Percona Server Development Team <mysql-dev@percona.com>
57 Uploaders: Ignacio Nin <ignacio.nin@percona.com>
58-Build-Depends: libtool (>= 1.4.2-7), procps | hurd, debhelper (>= 7.0.50), file (>= 3.28-1), libncurses5-dev (>= 5.0-6), perl (>= 5.6.0), libwrap0-dev (>= 7.6-8.3), zlib1g-dev (>= 1:1.1.3-5), psmisc, po-debconf, chrpath, automake (>= 1.9), doxygen, dpatch, gawk, bison, lsb-release, fakeroot
59+Build-Depends: libtool (>= 1.4.2-7), procps | hurd, debhelper (>= 7.0.50), libncurses5-dev (>= 5.0-6), perl (>= 5.6.0), libwrap0-dev (>= 7.6-8.3), zlib1g-dev (>= 1:1.1.3-5), po-debconf, chrpath, automake (>= 1.9), dpatch, gawk, bison, lsb-release, fakeroot, libssl-dev
60 Standards-Version: 7.0.0
61 Homepage: http://www.percona.com/software/
62 Vcs-Bzr: lp:percona-server/5.1
63
64=== modified file 'build/debian/rules'
65--- build/debian/rules 2013-04-10 08:10:51 +0000
66+++ build/debian/rules 2013-05-02 08:18:32 +0000
67@@ -119,7 +119,7 @@
68 dh_testdir
69
70 $(MAKE) $(MAKE_J)
71-ifeq ($(findstring nocheck,$(DEB_BUILD_OPTIONS)),)
72+ifneq ($(findstring check,$(DEB_BUILD_OPTIONS)),)
73 if [ ! -f testsuite-stamp ] ; then \
74 $(MAKE) $(MAKE_TEST_TARGET) || $(TESTSUITE_FAIL_CMD) ; \
75 fi

Subscribers

People subscribed via source and target branches