Code review comment for lp:~ignacio-nin/percona-server/5.1-bug1104977

Revision history for this message
Ignacio Nin (ignacio-nin) wrote :

> Perhaps the lib64 preference over lib is better solved by setting LDFLAGS in
> the build scripts instead of patching Autoconf macros?

Note that /usr/lib64/ will be added anyway (implicitely) to the LD search path. So in the way the file is written now, the first test, the one that checks for /usr/lib/, will always succeed and will add /usr/lib to the library path.

In the end this won't cause problems because the libraries will be rejected and the ones in /usr/lib64/ are used anyway, but no before polluting the output with many a "incompatible library" errors when trying to use /usr/lib/. So actually, unless another directory than /usr/ is used (and we use /usr), this is just a cosmetic change -- adding /usr/lib64/ to LDFLAGS wouldn't be needed.

Please advise!

« Back to merge proposal