Merge lp:~icsergio/stock-logistic-warehouse/improve_reordering_rules into lp:stock-logistic-warehouse

[Sergio Corato]

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

__openerp__.py:
 * The description does not allow to understand what the module does
 * merge init_xml and update_xml in 'data'

l.126
from openerp.osv import orm, fields

l.128,152
inherit from orm.Model

l.150,161
remove the instantiation

l.137,144,147
context propagation is missing

l.138
why do you skip the update when you have 1 product?

l.139
unreadable query: use multiple lines

l.139
the product ids should not be substituted in the str, they must be an argument in cr.execute()

l.146
this is bug prone because you initialized res at l.135 and reuse it for each product.
Just remove the l.146 and do the write as follows:
    self.write(cr, uid, reord_rules_ids, {'product_max_qty': val[1]}, context=context)

l.158
why is 3 casted to int?

l.178-180
Instead of forcing the 'string' in the view, you better have to directly write the correct string in the python ``fields``.

On pep8 [1]
take a look on the pep8 recommandations for the whitespaces [2], 1 space after a comma or a colon (l.144,157,158...)

[1] http://www.python.org/dev/peps/pep-0008/
[2] http://www.python.org/dev/peps/pep-0008/#whitespace-in-expressions-and-statements

review: Needs Fixing (code review, no test)

[lp:~icsergio/stock-logistic-warehouse/improve_reordering_rules]

30. By Sergio Corato on 2013-02-18

[FIX] Code and description review

[Sergio Corato (icsergio)]

Thanks a lot, I uploaded the code reviewed with your useful tips.

For
"l.138
why do you skip the update when you have 1 product?"
it's because if there is only a service product it gives a non-blocking error, even not visible by the user (only in console).
If it's admitted, it can be removed (as I did in the last release).

[Sergio Corato (icsergio)]

Perhaps is better if I check if the product is a service before executing, I'd test this one first.

[lp:~icsergio/stock-logistic-warehouse/improve_reordering_rules]

31. By Sergio Corato on 2013-02-19

[FIX] Improved SQL query to search only product of type product

32. By Sergio Corato on 2013-02-19

[IMP] Improved usage description

[Sergio Corato (icsergio)]

Now it would be ok, for me.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Looks good to me. Any idea if it works correctly in multi-company?

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

(I ask that because the SQL query bypass the record rules)

[Sergio Corato (icsergio)]

I've done some tests and it looks ok even in multi-company.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Nice.

LGTM

review: Approve (code review, no test)

=== added directory 'stock_reord_rule'
=== added file 'stock_reord_rule/__init__.py'
--- stock_reord_rule/__init__.py	1970-01-01 00:00:00 +0000
+++ stock_reord_rule/__init__.py	2013-02-19 21:36:22 +0000
@@ -0,0 +1,22 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    Vehicle management for OpenERP
+#    Copyright (C) 2012 Sergio Corato (<http://www.icstools.it>)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+import stock_reord_rule

=== added file 'stock_reord_rule/__openerp__.py'
--- stock_reord_rule/__openerp__.py	1970-01-01 00:00:00 +0000
+++ stock_reord_rule/__openerp__.py	2013-02-19 21:36:22 +0000
@@ -0,0 +1,51 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    Improved reordering rules for OpenERP
+#    Copyright (C) 2012 Sergio Corato (<http://www.icstools.it>)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+{
+    'name': 'Improved reordering rules',
+    'version': '0.2',
+    'category': 'Tools',
+    'description': """
+    This module allows to improve reordering rules of stock module.
+    
+    It works forecasting the stock needed per product for n days of sales, with the next formula:
+    (( Qty sold in days_stats * (1+forecast_gap)) / days_stats * days_warehouse)
+    where:
+    - days_stats = days on wich calculate sales stats;
+    - forecast_gap = forecast of increase/decrease on sales (%);
+    - days_warehouse = days of stock to keep in the warehouse.
+
+    Usage:
+    insert days_stats, forecast_gap and days_warehouse vars in product form
+    and create a reordering rule for the same product, without inserting nothing (neither maximum or
+    minimum quantity are required). The cron job will be executed daily and will update the maximum
+    quantity in the reordering rule (you can force it to start changing the date and hour of 
+    execution).
+    This module doesn't need purchase module to work, but it's useful with that module.'""",
+    'author': 'Sergio Corato',
+    'website': 'http://www.icstools.it',
+    'depends': ['procurement','sale',],
+    'demo_xml' : [],
+    'data': ['stock_reord_rule_view.xml','cron_data.xml',],
+    'images': [],
+    'active': False,
+    'installable': True,
+}

=== added file 'stock_reord_rule/cron_data.xml'
--- stock_reord_rule/cron_data.xml	1970-01-01 00:00:00 +0000
+++ stock_reord_rule/cron_data.xml	2013-02-19 21:36:22 +0000
@@ -0,0 +1,15 @@
+<?xml version="1.0"?>
+<openerp>
+    <data noupdate="1">
+        <record model="ir.cron" id="update_reordering_quantity_cron">
+            <field name="name">Update quantity for reordering rules</field>
+            <field name="interval_number">1</field>
+            <field name="interval_type">days</field>
+            <field name="numbercall">-1</field>
+            <field name="doall" eval="False"></field>
+            <field eval="'stock.warehouse.orderpoint'" name="model"/>
+            <field eval="'_qty_orderpoint_days'" name="function"/>
+            <field eval="'[[],{}]'" name="args"/>
+        </record>
+    </data>
+</openerp>

=== added directory 'stock_reord_rule/i18n'
=== added directory 'stock_reord_rule/security'
=== added file 'stock_reord_rule/security/ir.model.access.csv'
--- stock_reord_rule/security/ir.model.access.csv	1970-01-01 00:00:00 +0000
+++ stock_reord_rule/security/ir.model.access.csv	2013-02-19 21:36:22 +0000
@@ -0,0 +1,2 @@
+"id","name","model_id:id","group_id:id","perm_read","perm_write","perm_create","perm_unlink"
+

=== added file 'stock_reord_rule/stock_reord_rule.py'
--- stock_reord_rule/stock_reord_rule.py	1970-01-01 00:00:00 +0000
+++ stock_reord_rule/stock_reord_rule.py	2013-02-19 21:36:22 +0000
@@ -0,0 +1,59 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    Automatic Stock Procurement by days for OpenERP
+#    Copyright (C) 2012 Sergio Corato (<http://www.icstools.it>)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openerp.osv import orm, fields
+
+class stock_warehouse_orderpoint(orm.Model):
+    _inherit = "stock.warehouse.orderpoint"
+
+    def _qty_orderpoint_days(self, cr, uid, ids, context=None):
+        """Calculate quantity to create warehouse stock for n days of sales.
+        (( Qty sold in days_stats * (1+forecast_gap)) / days_stats * days_warehouse)"""
+
+        obj_product = self.pool.get('product.product')
+        product_ids = tuple(obj_product.search(cr, uid, [], context=context))
+        sql= """SELECT sol.product_id AS product_id, 
+        (sum( product_uos_qty )/pp.days_stats*(1+pp.forecast_gap/100) * pp.days_warehouse) 
+        AS quantity FROM sale_order_line sol JOIN sale_order so ON so.id = sol.order_id 
+        JOIN product_product pp ON pp.id = sol.product_id 
+        JOIN product_template pt ON pt.id = pp.product_tmpl_id
+        WHERE sol.state in ('done','confirmed') AND pt.type = 'product'
+        AND sol.product_id IN %s AND date_order > (date(now()) - pp.days_stats) 
+        GROUP BY sol.product_uom, sol.product_id, pp.days_stats, pp.forecast_gap,
+        pp.days_warehouse;"""
+        cr.execute(sql, (product_ids,))
+        sql_res = cr.fetchall()
+        if sql_res:
+            for val in sql_res:
+                if val:
+                    reord_rules_ids = self.search(cr, uid, [('product_id', '=', val[0])], context=context)
+                    if reord_rules_ids:
+                        self.write(cr, uid, reord_rules_ids, {'product_max_qty': val[1]}, context=context)
+        return True
+
+class product_product(orm.Model):
+    _inherit = "product.product"
+
+    _columns = {
+        'days_warehouse': fields.integer('Days of needed warehouse stock'),
+        'days_stats': fields.integer('Days of sale statistics'),
+        'forecast_gap': fields.float('Expected sales variation (percent +/-)', digits=(6,3)),
+        }

=== added file 'stock_reord_rule/stock_reord_rule_view.xml'
--- stock_reord_rule/stock_reord_rule_view.xml	1970-01-01 00:00:00 +0000
+++ stock_reord_rule/stock_reord_rule_view.xml	2013-02-19 21:36:22 +0000
@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+    <data>
+
+        <record id="product_normal_form_view_procurement_by_days" model="ir.ui.view">
+            <field name="name">product.normal.form_procurement_by_days</field>
+            <field name="model">product.product</field>
+            <field name="inherit_id" ref="product.product_normal_form_view"/>
+            <field name="arch" type="xml">
+                <group name="procurement" position="after">
+                    <group name="Stock Procurement By Days">
+                    <field name="days_warehouse"/>
+                    <field name="days_stats"/>
+                    <field name="forecast_gap"/>
+                    </group>
+                </group>
+            </field>
+        </record>
+
+    </data>
+</openerp>
+