Merge lp:~iceyers/gsettings-qt/fix-link-path into lp:gsettings-qt

Proposed by Iceyer
Status: Needs review
Proposed branch: lp:~iceyers/gsettings-qt/fix-link-path
Merge into: lp:gsettings-qt
Diff against target: 51 lines (+10/-3)
4 files modified
GSettings/gsettings-qt.pro (+1/-1)
gsettings-qt.pro (+6/-1)
tests/cpptest.pro (+2/-1)
tests/tests.pro (+1/-0)
To merge this branch: bzr merge lp:~iceyers/gsettings-qt/fix-link-path
Reviewer Review Type Date Requested Status
Lars Karlitski Pending
Review via email: mp+328566@code.launchpad.net

This proposal supersedes a proposal from 2017-07-21.

Description of the change

1. Add CONFIG+=ordered to void build failed
2. Fix include path to relative path
3. Add QMAKE_RPATHDIR to fix make check failed

To post a comment you must log in.
Revision history for this message
Iceyer (iceyers) wrote : Posted in a previous version of this proposal

The subdir tests depends src, add ordered to avoid multi-thread build failed.

Revision history for this message
Khurshid Alam (khurshid-alam) wrote :

@iceyers

It still failing due to mismatched symbols issues on 17.10

Log:
----------------------------------------------------
make[1]: Entering directory '/<<BUILDDIR>>/gsettings-qt-0.1+16.04.20160329+201708220715~ubuntu17.10.1'
dh_makeshlibs -- -c4
dpkg-gensymbols: warning: some new symbols appeared in the symbols file: see diff output below
dpkg-gensymbols: warning: debian/libgsettings-qt1/DEBIAN/symbols doesn't match completely debian/libgsettings-qt1.symbols
--- debian/libgsettings-qt1.symbols (libgsettings-qt1_0.1+16.04.20160329+201708220715~ubuntu17.10.1_i386)
+++ dpkg-gensymbolsRs4cJ4 2017-08-22 07:18:42.671110748 +0000
@@ -25,6 +25,10 @@
  (c++)"QMapNode<QString, QVariant>::copy(QMapData<QString, QVariant>*) const@Base" 0.1+14.10.20140801.1
  (c++)"QMapNode<QString, QVariant>::destroySubTree()@Base" 0.1+14.10.20140801.1
  (c++)"QString::~QString()@Base" 0.1+14.04.20140408
+ _ZN4QMapI7QString8QVariantEC1ERKS2_@Base 0.1+16.04.20160329+201708220715~ubuntu17.10.1
+ _ZN4QMapI7QString8QVariantEC2ERKS2_@Base 0.1+16.04.20160329+201708220715~ubuntu17.10.1
+ _ZN5QListI7QStringEC1ERKS1_@Base 0.1+16.04.20160329+201708220715~ubuntu17.10.1
+ _ZN5QListI7QStringEC2ERKS1_@Base 0.1+16.04.20160329+201708220715~ubuntu17.10.1
  (optional=templinst)_ZN8QMapDataI7QString8QVariantE7destroyEv@Base 0.1+16.04.20160329-0ubuntu2
  (c++)"qconf_types_collect_from_variant(_GVariantType const*, QVariant const&)@Base" 0.1+14.04.20140408
  (c++)"qconf_types_convert(_GVariantType const*)@Base" 0.1+14.04.20140408
dh_makeshlibs: failing due to earlier errors

https://launchpadlibrarian.net/334153567/buildlog_ubuntu-artful-i386.gsettings-qt_0.1+16.04.20160329+201708220715~ubuntu17.10.1_BUILDING.txt.gz

Unmerged revisions

86. By Iceyer

Fix make check failed

85. By Iceyer

Add ordered config

84. By iceyer@iceyer-PC

Fix link path error

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'GSettings/gsettings-qt.pro'
2--- GSettings/gsettings-qt.pro 2013-08-06 13:34:21 +0000
3+++ GSettings/gsettings-qt.pro 2017-08-04 11:10:22 +0000
4@@ -4,7 +4,7 @@
5 CONFIG += qt plugin no_keywords link_pkgconfig
6 PKGCONFIG += gio-2.0
7 INCLUDEPATH += ../src .
8-LIBS += -L../src -lgsettings-qt
9+LIBS += -L$$(PWD)/../src -lgsettings-qt
10
11 TARGET = GSettingsQmlPlugin
12
13
14=== modified file 'gsettings-qt.pro'
15--- gsettings-qt.pro 2015-06-02 13:39:14 +0000
16+++ gsettings-qt.pro 2017-08-04 11:10:22 +0000
17@@ -1,2 +1,7 @@
18 TEMPLATE = subdirs
19-SUBDIRS += src/gsettings-qt.pro GSettings/gsettings-qt.pro tests/tests.pro tests/cpptest.pro
20+CONFIG += ordered
21+SUBDIRS += \
22+ src/gsettings-qt.pro \
23+ GSettings/gsettings-qt.pro \
24+ tests/tests.pro \
25+ tests/cpptest.pro
26
27=== modified file 'tests/cpptest.pro'
28--- tests/cpptest.pro 2016-07-26 06:49:27 +0000
29+++ tests/cpptest.pro 2017-08-04 11:10:22 +0000
30@@ -3,7 +3,8 @@
31 QT -= gui
32 CONFIG += testcase link_pkgconfig
33 TARGET = cpptest
34-IMPORTPATH = $$PWD/..
35+IMPORTPATH = $$(PWD)/..
36+QMAKE_RPATHDIR += $$(PWD)/../src
37 SOURCES = cpptest.cpp
38 INCLUDEPATH += $$(PWD)/../src
39 LIBS += -L$$(PWD)/../src -lgsettings-qt
40
41=== modified file 'tests/tests.pro'
42--- tests/tests.pro 2016-07-26 06:49:27 +0000
43+++ tests/tests.pro 2017-08-04 11:10:22 +0000
44@@ -4,6 +4,7 @@
45 CONFIG += qmltestcase
46 TARGET = test
47 IMPORTPATH = $$PWD/..
48+QMAKE_RPATHDIR += $$PWD/../src
49 SOURCES = test.cpp
50
51 schema.target = gschemas.compiled

Subscribers

People subscribed via source and target branches

to all changes: