Code review comment for lp:~ibid-core/ibid/feature-discovery-399667

Revision history for this message
marcog (marco-gallotta) wrote :

> > We use ellipses here, but the usage strings use <foo> notation. Consistency?
>
> Yeah, not ideal but <brackets> don't seem to work there grammatically.

Ok, I'll grudgingly let that slip for now. However, I do feel the inconsistency is quite poor long-term.

> > Query: what silly fun stuff do you do?
> > Response: Got it
>
> There are a hell of a lot of those type of things. I'd say let's ignore them
> for 0.1.

Fair enough.

> > Query: how do i use rot
> > Response: I'm afraid I don't know what you are asking about. Ask "what can
> you
> > do" to browse my features
> >
> > Would be nice if it suggested "Did you mean rot13"?
>
> That is possible via substring searches. Don't know how vital it is.

I think at the very least, we should look for the same feature in plural/singular form (i.e. drop/add an 's'). This is the source of the most failed lookups.

« Back to merge proposal