Merge lp:~ibelieve/ubuntu-ui-toolkit/themeImprovements into lp:ubuntu-ui-toolkit
Status: | Rejected |
---|---|
Rejected by: | Tim Peeters |
Proposed branch: | lp:~ibelieve/ubuntu-ui-toolkit/themeImprovements |
Merge into: | lp:ubuntu-ui-toolkit |
Diff against target: |
281 lines (+75/-20) 10 files modified
modules/Ubuntu/Components/ListItems/LabelVisual.qml (+2/-2) modules/Ubuntu/Components/Popups/ComposerSheet.qml (+3/-3) modules/Ubuntu/Components/Popups/DefaultSheet.qml (+3/-3) modules/Ubuntu/Components/Themes/Ambiance/CheckBoxStyle.qml (+1/-1) modules/Ubuntu/Components/Themes/Ambiance/OptionSelectorStyle.qml (+2/-0) modules/Ubuntu/Components/Themes/Ambiance/Palette.qml (+3/-1) modules/Ubuntu/Components/Themes/Ambiance/PickerStyle.qml (+1/-1) modules/Ubuntu/Components/Themes/Ambiance/SheetForegroundStyle.qml (+54/-7) modules/Ubuntu/Components/Themes/SuruDark/Palette.qml (+3/-1) modules/Ubuntu/Components/Themes/SuruGradient/Palette.qml (+3/-1) |
To merge this branch: | bzr merge lp:~ibelieve/ubuntu-ui-toolkit/themeImprovements |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Peeters | Needs Resubmitting | ||
Zsombor Egri | Needs Information | ||
Review via email:
|
Commit message
Improves and fixes various visual inconsistencies
Description of the change
This fixes some visual inconsistencies and also improves the style of sheets.
It contains the following changes:
* Fixes the text colors for list items in a Popover (no longer black and is now the color that list items are outside of a Popover using the non-Suru theme)
* Fixes the background color of OptionSelectors and Pickers to match that of TextFields
* Fixes the text color for TextFields and TextAreas when the text area is not focused in the SuruGradient theme
* Fixes the unselected color of CheckBoxes to look awesome with a dark Suru background
* A new style for Sheets based on the UbuntuShape
* Fixes the text for Sheet buttons so they are properly capitalized
Screenshot of the Sheet design: http://
Unmerged revisions
- 975. By Michael Spencer
-
Fixed text field color for SuruGradient theme when text field is not focused
- 974. By Michael Spencer
-
Improved checkbox color
- 973. By Michael Spencer
-
Lots of color fixes and other visual improvements
- 972. By Tim Peeters
-
move TabBar into HeaderStyle
- 971. By Tim Peeters
-
link bug
- 970. By Tim Peeters
-
fix unit tests
- 969. By Tim Peeters
-
move selectedIndex property to the tabs model
- 968. By Launchpad Translations on behalf of ubuntu-sdk-team
-
Launchpad automatic translations update.
Has these changes been confirmed by the UI team?