Merge lp:~ibelieve/ubuntu-filemanager-app/fixed-progress-dialog into lp:ubuntu-filemanager-app
Proposed by
Michael Spencer
Status: | Merged | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Approved by: | Nicholas Skaggs | ||||||||||||
Approved revision: | 67 | ||||||||||||
Merged at revision: | 63 | ||||||||||||
Proposed branch: | lp:~ibelieve/ubuntu-filemanager-app/fixed-progress-dialog | ||||||||||||
Merge into: | lp:ubuntu-filemanager-app | ||||||||||||
Diff against target: |
473 lines (+113/-114) 6 files modified
FileOperationProgressDialog.qml (+24/-6) FolderListPage.qml (+55/-95) FolderListView.qml (+1/-9) Makefile (+8/-0) PlacesSidebar.qml (+1/-1) ubuntu-filemanager-app.qml (+24/-3) |
||||||||||||
To merge this branch: | bzr merge lp:~ibelieve/ubuntu-filemanager-app/fixed-progress-dialog | ||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Nicholas Skaggs (community) | Approve | ||
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Review via email: mp+186103@code.launchpad.net |
Commit message
Fixed the progress dialog, blurry icons, header covering content, and made the the toolbar hidden by default
Description of the change
This makes the following changes:
* Fixes the header from covering content
* Hides the progress dialog unless it is needed
* Fixes the blurry icons on the phone
* Hides the toolbar in phone mode and shows it in wide mode
To post a comment you must log in.
FAILED: Continuous integration, rev:66 91.189. 93.70:8080/ job/ubuntu- filemanager- app-ci/ 36/ 91.189. 93.70:8080/ job/generic- mediumtests/ 397/console 91.189. 93.70:8080/ job/ubuntu- filemanager- app-precise- amd64-ci/ 36/console 91.189. 93.70:8080/ job/ubuntu- filemanager- app-quantal- amd64-ci/ 36/console 91.189. 93.70:8080/ job/ubuntu- filemanager- app-raring- amd64-ci/ 36/console 91.189. 93.70:8080/ job/ubuntu- filemanager- app-saucy- amd64-ci/ 36/console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/ubuntu- filemanager- app-ci/ 36/rebuild
http://