Merge lp:~ibelieve/music-app/improved-nomusic-msg into lp:music-app/trusty
Proposed by
Michael Spencer
Status: | Merged |
---|---|
Approved by: | Victor Thompson |
Approved revision: | 353 |
Merged at revision: | 357 |
Proposed branch: | lp:~ibelieve/music-app/improved-nomusic-msg |
Merge into: | lp:music-app/trusty |
Diff against target: |
127 lines (+55/-22) 1 file modified
music-app.qml (+55/-22) |
To merge this branch: | bzr merge lp:~ibelieve/music-app/improved-nomusic-msg |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Victor Thompson | Approve | ||
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Review via email:
|
Commit message
Improved the no music message
Description of the change
Currently, when there is no music available, a message is displayed explaining what needs to happen. This doesn't make much sense without a message explaining the problem.
This adds a large & bold header stating that there is no music available. This follows the design used in Friends when no accounts are set up.
To post a comment you must log in.
PASSED: Continuous integration, rev:352 91.189. 93.70:8080/ job/music- app-ci/ 593/ 91.189. 93.70:8080/ job/generic- mediumtests- trusty/ 1463 91.189. 93.70:8080/ job/music- app-raring- amd64-ci/ 593 91.189. 93.70:8080/ job/music- app-saucy- amd64-ci/ 595 91.189. 93.70:8080/ job/music- app-trusty- amd64-ci/ 314
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/music- app-ci/ 593/rebuild
http://