Merge lp:~ian-weisser/ubuntu-community-website/asknot-php into lp:ubuntu-community-website
| Status: | Rejected |
|---|---|
| Rejected by: | Michael Hall on 2015-01-13 |
| Proposed branch: | lp:~ian-weisser/ubuntu-community-website/asknot-php |
| Merge into: | lp:ubuntu-community-website |
| Diff against target: |
654 lines (+595/-1) 6 files modified
guidance_wizard.php (+190/-0) guidance_wizard_header.php (+14/-0) header.php (+10/-0) library/css/guidance_wizard.css (+160/-0) library/js/guidance_wizard.js (+213/-0) page.php (+8/-1) |
| To merge this branch: | bzr merge lp:~ian-weisser/ubuntu-community-website/asknot-php |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Hall (community) | 2015-01-05 | Disapprove on 2015-01-13 | |
| Ubuntu Community Website Admins | 2015-01-04 | Pending | |
|
Review via email:
|
|||
Description of the Change
Added a version of the Mozilla AskNot volunteer tool. Work item from the Ubuntu Community Team.
- Content changed to match many Ubuntu community roles.
- Format modified to conform with Ubuntu website design guidelines.
- HTML uses standard tags (<p>, <li>, etc) to inherit Ubuntu website CSS.
- HTML and CSS use non-conflicting class names and id names.
Sources: https:/
License: Mozilla Public License - https:/
This version has data as a php template (guidance_
1) Remove the template hook from the bottom of page.php
2) Copy the content of guidance_wizard.php into the content of the page.
3) Fix the nine image links in the content. May need to upload the images instead of storing them in library/
(Obviously I can't do steps 2 and 3 in this branch since it doesn't include the database)
Data in PHP Template vs in MySQL Content:
The branch has been tested both ways, and works equally well.
When teams want to change the volunteer roles they advertise:
- If you want bug reports, and you change the HTML manually, use content in MySQL.
- If you want teams to edit the HTML themselves, and push merge requests to you, use PHP Template.
I recommend staying with the PHP Template. In my testing, I found it simpler to maintain.
Testing:
- This branch will, of course, try to replace any 'Ubuntu' Wordpress theme you already have installed.
- Create a sample page titled 'Contribute'. The hooks in header.php and page.php look for that page name.
- jQuery.js is required for AskNot to work, and is included in Wordpress, but is not loaded by trunk nor this branch (apparently it's loaded by something else outside this branch). A jQuery loader for testing is in for testing is in guidance_
- Once you have a 'Contribute' page and enabled jQuery, the tool should automatically show up on that page.
- For troubleshooting, a non-wordpress version of the same HTML/CSS/JS is at https:/
How to change the content without breaking the tool:
See the bottom of the README at https:/
| Nicholas Skaggs (nskaggs) wrote : | # |
| Ian Weisser (ian-weisser) wrote : | # |
FYI: mhall119 has already touched this, and apparently gone live with a
version: http://
On Tue, 2015-01-13 at 15:19 +0000, Nicholas Skaggs wrote:
> Awesome! I'll have a play with this and send you some comments. Thanks Ian!
| Michael Hall (mhall119) wrote : | # |
Rejecting this from the branch because I've added it through Wordpress already: http://
Unmerged revisions
- 10. By Ian Weisser on 2015-01-04
-
Add AskNot job board tool as a php snippet.

Awesome! I'll have a play with this and send you some comments. Thanks Ian!