Merge ~ian-may/+git/autotest-client-tests:pts-numa-dev into ~canonical-kernel-team/+git/autotest-client-tests:master

Proposed by Ian May
Status: Merged
Merge reported by: Ian May
Merged at revision: 930bde6c0275c4c8e5de8039b4810e94d6a2e7c1
Proposed branch: ~ian-may/+git/autotest-client-tests:pts-numa-dev
Merge into: ~canonical-kernel-team/+git/autotest-client-tests:master
Diff against target: 34 lines (+13/-2)
1 file modified
ubuntu_performance_pts/ubuntu_performance_pts.py (+13/-2)
Reviewer Review Type Date Requested Status
Po-Hsu Lin Approve
Andrei Gherzan Approve
Review via email: mp+458496@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Andrei Gherzan (agherzan) wrote :

Looks good code-wise. NIT: I would have avoided a bit the duplication in cmd assignments.

review: Approve
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

+1 here with another nit about the comment.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/ubuntu_performance_pts/ubuntu_performance_pts.py b/ubuntu_performance_pts/ubuntu_performance_pts.py
2index 10ec868..1034a9a 100644
3--- a/ubuntu_performance_pts/ubuntu_performance_pts.py
4+++ b/ubuntu_performance_pts/ubuntu_performance_pts.py
5@@ -238,6 +238,8 @@ class ubuntu_performance_pts(test.test):
6 bpn = utils.system_output('dmidecode -s baseboard-product-name | head -1', retain_output=True)
7 if bpn == 'DGXA100':
8 return 'DGXA100'
9+ elif bpn == 'DGXH100':
10+ return 'DGXH100'
11 else:
12 return 'Default'
13
14@@ -261,9 +263,18 @@ class ubuntu_performance_pts(test.test):
15 self.print_stats(test_name, cmd)
16
17 def run_ttsiod_renderer(self, test_name, tag):
18+ platform = self.get_platform()
19 #if on DGXA100 bind cpu and mem to stable numa range
20- if self.get_platform() == 'DGXA100':
21- cmd = 'numactl -N 0-3 -m 0-3 %s phoronix-test-suite batch-benchmark ttsiod-renderer-1.7.0' % force_times_to_run
22+ if platform == 'DGXA100':
23+ #If series is greater than focal(20), remove OMP_PROC_BIND, kernel scheduling provides better results.
24+ #Improved numa support allows for better performance using a lower bind range.
25+ if self.get_platform_distro()[1].split('.')[0] > "20":
26+ cmd = 'export OMP_PROC_BIND=false; numactl -N 0-1 -m 0-1 %s phoronix-test-suite batch-benchmark ttsiod-renderer-1.7.0' % force_times_to_run
27+ else:
28+ cmd = 'numactl -N 0-3 -m 0-3 %s phoronix-test-suite batch-benchmark ttsiod-renderer-1.7.0' % force_times_to_run
29+ #if on DGXH100 bind cpu and mem to stable numa range
30+ elif platform == 'DGXH100':
31+ cmd = 'export OMP_PROC_BIND=false; numactl -N 0 -m 0 %s phoronix-test-suite batch-benchmark ttsiod-renderer-1.7.0' % force_times_to_run
32 else:
33 cmd = '%s phoronix-test-suite batch-benchmark ttsiod-renderer-1.7.0' % force_times_to_run
34 self.print_stats(test_name, cmd)

Subscribers

People subscribed via source and target branches

to all changes: