Merge ~ian-may/+git/autotest-client-tests:master into ~canonical-kernel-team/+git/autotest-client-tests:master

Proposed by Ian May
Status: Merged
Approved by: Po-Hsu Lin
Approved revision: bbb0ae4f945d252bb1e929439072eb9019168b3c
Merged at revision: https://git.launchpad.net/~canonical-kernel-team/+git/autotest-client-tests/commit/?id=03bf63d5809b0649f183a40578c442ca50040ebf
Proposed branch: ~ian-may/+git/autotest-client-tests:master
Merge into: ~canonical-kernel-team/+git/autotest-client-tests:master
Diff against target: 12 lines (+1/-0)
1 file modified
ubuntu_performance_pts/control (+1/-0)
Reviewer Review Type Date Requested Status
Po-Hsu Lin Approve
Review via email: mp+442689@code.launchpad.net

Description of the change

Seeing this error on latest Perf run on DGX2/focal:linux. Confirmed on Bionic/Focal/Jammy VMs. A simple initialization before doing '+=' resolves the error.

14:22:09 ERROR| JOB ERROR: Unhandled NameError: name 'results' is not defined
Traceback (most recent call last):
  File "/home/ubuntu/autotest.1318-IiHSuDxdck/autotest/client/job.py", line 1109, in step_engine
    execfile(self.control, global_control_vars, global_control_vars)
  File "/home/ubuntu/autotest.1318-IiHSuDxdck/autotest-client-tests/ubuntu_performance_pts/control", line 46, in <module>
    results += job.run_test_detail(NAME, test_name=j[0], tag=NAME + '_' + j[1], subtest=j[1], timeout=j[2] * 60)
NameError: name 'results' is not defined

To post a comment you must log in.
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Ah thanks for fixing this.
It was me when adding the "build-only" branch.

review: Approve
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/ubuntu_performance_pts/control b/ubuntu_performance_pts/control
2index f1a7458..9ccb7d7 100644
3--- a/ubuntu_performance_pts/control
4+++ b/ubuntu_performance_pts/control
5@@ -42,6 +42,7 @@ if result == 'GOOD':
6 [ 'osbench', 'osbench-memory', 10 ],
7 ]
8
9+ results = []
10 for j in jobs:
11 results += job.run_test_detail(NAME, test_name=j[0], tag=NAME + '_' + j[1], subtest=j[1], timeout=j[2] * 60)
12 else:

Subscribers

People subscribed via source and target branches

to all changes: