Code review comment for lp:~ian-clatworthy/bzr/faster-tags

Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

John A Meinel wrote:
>
> This only benefits the case of "no actual tags present". I thought we
> actually had something like this, but whatever.
>
Not true. OOo has tags (10-20) and its works fine.
> I'll mention that "bzr tags --show-ids" should always be the same speed
> (fast), and this is just avoiding loading the revision_id=>revno map
> until actually needed.
Right. But showing revnos is default behaviour so saying to users "but
tags --show-ids is fast" doesn't seem a good enough response.
> Unless revision_id_to_revno() also knows to try to determine mainline
> revnos first (which it can do by walking backwards from tip). So there
> is the chance that if all your tags are on the mainline (and recent) it
> won't load as much history.
>
It does exactly that.

Tagging things along the mainline is pretty common, particularly when
there's only a mainline. :-) So I think this is a win for many projects
using tags.

Ian C.

« Back to merge proposal