I am on skype
—
Sent from Mailbox for iPhone

On Sat, May 4, 2013 at 1:43 PM, Charlie Poole <email address hidden> wrote:

> Hi Tyrel,
> This all sounds good to me. I'm actually ready to start whenever you are.
> Charlie
> On Sat, May 4, 2013 at 10:02 AM, Tyrel Alastair Hunter <
> <email address hidden>> wrote:
>> Random Generator Change:
>>
>> ITest has an unneeded (and undesirable) reference to the Internal
>> namespace. Public APIs should avoid such references.
>>
>> I have removed this reference
>>
>> I see you use the Randomizer for the test method, which is used to
>> generate random arguments, to create the seed for the user-side
>> RandomGenerator. This will work well as far as guaranteeing a unique seed
>> but introduces a dependency: adding or removing other tests will change the
>> random seed used for any subsequently detected tests. Additionally, it
>> defeats the lazy initialization of randomizers, forcing creation of a
>> randomizer for every test method. I suggest we put it in this way but try
>> to find a better approach that preserves lazy initialization of Randomizers
>> and avoids test interactions.
>>
>> I am not sure i completely understand what you are saying here can we
>> disuss this while we are doing the release at 2:00 EST
>>
>> Please add some comments that distinguish the purpose of RandomGenerator
>> from Randomizer, now that we have both of them.
>>
>> Added comments to RandomGenerator and Randomizer
>>
>> RandomGenerator won't compile under .NET 1.1 as it is. The GetEnums
>> methods should all be controlled by #if CLR_2_0.
>>
>> I believe that I fixed this however I will have you check it while we are
>> doing the release at 2:00 EST
>>
>> The portability logic for enums in RandomGenerator duplicates what's
>> already in TypeHelper. See if you can use the TypeHelper enum methods - or
>> add what's needed there.
>>
>> Modified the code to use the TypeHelper instead
>>
>> I'm not seeing any tests for the new feature. It should be easy to copy
>> and edit RandomizerTests.cs for this purpose. Harder to test repeatability,
>> so maybe we should worry about that later.
>>
>> I have added tests for most of the functionality we can add more tests in
>> a later release. Tests left out are for repeatability, and for the Random
>> enum function
>>
>> Category Change:
>>
>> Code looks good but I'm not seeing any tests here either. Should be easy
>> to add to CommandLineOptionTests.cs.
>>
>> Overall... It needs some fixes but you can go ahead and merge when you
>> have done them.
>>
>> I have added tests to test that CommandLine Options works as expected.
>> There is no test to ensure the options function correctly but the test
>> ensure that the options are recognized.
>>
>> we can add a test later that ensures that the options are used to modify
>> the way nunit executes the tests.
>> --
>>
>> https://code.launchpad.net/~ialastairhunter/nunitlite/categoryfilter/+merge/161767
>> You are reviewing the proposed merge of
>> lp:~ialastairhunter/nunitlite/categoryfilter into lp:nunitlite.
>>
> -- 
> https://code.launchpad.net/~ialastairhunter/nunitlite/categoryfilter/+merge/161767
> You are the owner of lp:~ialastairhunter/nunitlite/categoryfilter.