Merge lp:~iahmad/messaging-app/autopilot_test_helpers into lp:messaging-app

[I Ahmad]

some new helpers for AP tests

Some new helpers are added to improve the messaging-app test coverage itself and to aid into the UX tests being written as an independent test suite.

These particular helper is needed to pop up the contact list when receipents needs to be added to the list.

1. Are there any related MPs required for this MP to build/function as expected? Please list. No

2. Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes) Yes

3. Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator? N/A

4. Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator? Yes - No new failures

5. If you changed the UI, was the change specified/approved by design? N/A

6. If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP? N/A

[Brendan Donegan (brendan-donegan)]

Any reason not to just have a helper called 'add_contact_to_message' which clicks on the appropriate icon? It could be build on a seperate get_toolbar_add_contact_icon (i.e. get the icon, click it), so you can keep that.

review: Needs Information

[lp:~iahmad/messaging-app/autopilot_test_helpers]

131. By I Ahmad on 2014-07-14

 Added click helper for add contact icon

[I Ahmad (iahmad)]

brendand, done, added one more helper to combine getting the add contact icon and clicking it.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:130
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~iahmad/messaging-app/autopilot_test_helpers/+merge/226662/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/messaging-app-ci/282/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1939
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1617
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-amd64-ci/76
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-armhf-ci/76
        deb: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-armhf-ci/76/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-i386-ci/76
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2187
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3051
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3051/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9784
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1353
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1820
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1820/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/282/rebuild

review: Needs Fixing (continuous-integration)

[Brendan Donegan (brendan-donegan)]

Looks good now to me

review: Approve

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:131
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/283/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1946
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1626
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-amd64-ci/77
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-armhf-ci/77
        deb: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-armhf-ci/77/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-i386-ci/77
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2194
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3058
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3058/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9794
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1362
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1829
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1829/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/283/rebuild

review: Approve (continuous-integration)

[Gustavo Pichorim Boiko (boiko)]

Can you please just fix the issue on the inline comment and after that do the MP submission checklist as described here:
https://wiki.ubuntu.com/Process/Merges/Checklists/system-apps

review: Needs Fixing

[I Ahmad (iahmad)]

> Can you please just fix the issue on the inline comment and after that do the
> MP submission checklist as described here:
> https://wiki.ubuntu.com/Process/Merges/Checklists/system-apps

Thanks for your review comment

re using wait_select_single, I think it is not needed in this case as it is expected that icon should appear by the time chat popover is revealed.

Added the submission checklist into description with answers.

[Gustavo Pichorim Boiko (boiko)]

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did CI run pass? If not, please explain why.
Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

Code looks good and works as expected!

review: Approve

=== modified file 'src/qml/NewRecipientPage.qml'
--- src/qml/NewRecipientPage.qml	2014-07-07 22:48:19 +0000
+++ src/qml/NewRecipientPage.qml	2014-07-14 14:26:27 +0000
@@ -47,7 +47,7 @@
 
     ContactListView {
         id: contactList
-
+        objectName: "newRecipientList"
         anchors {
             top: parent.top
             left: parent.left

=== modified file 'tests/autopilot/messaging_app/emulators.py'
--- tests/autopilot/messaging_app/emulators.py	2014-07-08 08:35:32 +0000
+++ tests/autopilot/messaging_app/emulators.py	2014-07-14 14:26:27 +0000
@@ -145,6 +145,27 @@
             objectName='addContactButton',
         )
 
+    def get_toolbar_add_contact_icon(self):
+        """Return toolbar icon with name new-contact"""
+
+        return self.select_single(
+            'Icon',
+            name='new-contact',
+        )
+
+    def click_add_contact_icon(self):
+        """Click the add contact icon"""
+
+        icon = self.get_toolbar_add_contact_icon()
+        self.pointing_device.click_object(icon)
+
+    def get_contact_list_view(self):
+        """Returns the ContactListView object"""
+        return self.select_single(
+            'ContactListView',
+            objectName='newRecipientList'
+        )
+
     def get_toolbar_contact_profile_button(self):
         """Return toolbar button with objectName contactProfileButton"""
 

=== modified file 'tests/autopilot/messaging_app/tests/test_messaging.py'
--- tests/autopilot/messaging_app/tests/test_messaging.py	2014-06-30 08:42:16 +0000
+++ tests/autopilot/messaging_app/tests/test_messaging.py	2014-07-14 14:26:27 +0000
@@ -90,6 +90,16 @@
 class TestMessaging(BaseMessagingTestCase):
     """Tests for the communication panel."""
 
+    def test_helper_get_contact_list_view(self):
+        """test get_contact_list_view() helper is working"""
+        # open the chat window
+        self.main_view.start_new_message()
+        self.main_view.click_add_contact_icon()
+
+        # pop up the contact list to choose recipient
+        contact_view = self.main_view.get_contact_list_view()
+        self.assertThat(contact_view.visible, Eventually(Equals(True)))
+
     def test_write_new_message_to_group(self):
         recipient_list = ["123", "321"]
         self.main_view.start_new_message()